[upgrade sonic] reduce number of installed sonic image before installing#605
Closed
yxieca wants to merge 1 commit intosonic-net:masterfrom
Closed
[upgrade sonic] reduce number of installed sonic image before installing#605yxieca wants to merge 1 commit intosonic-net:masterfrom
yxieca wants to merge 1 commit intosonic-net:masterfrom
Conversation
Before installing a new sonic image, reduce number of installed sonic images to make space on the harddrive. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
prsunny
reviewed
May 10, 2018
| elif line != "Available:" and len(line) > 0: | ||
| images.add(line) | ||
|
|
||
| return keep, images |
Contributor
There was a problem hiding this comment.
Just another thought is to return (images - keep) since the only check below is to skip images in keep.
Collaborator
Author
There was a problem hiding this comment.
The reason I kept that was that we need to count len(keep) to decide how many images to delete.
Contributor
There was a problem hiding this comment.
You are not using len(keep) but len(images)
jleveque
reviewed
May 10, 2018
| - name: define retain_copies if not defined | ||
| set_fact: | ||
| retain_copies: 2 | ||
| when: retain_copies is not defined |
Contributor
There was a problem hiding this comment.
I feel the word "copies" is a bit confusing. Something along the lines of max_images_to_retain (but maybe less verbose) is a more accurate name.
jleveque
reviewed
May 10, 2018
|
|
||
| discard = set() | ||
| for img in images: | ||
| if (len(images) - len(discard)) <= retain_copies: |
Contributor
There was a problem hiding this comment.
What happens if len(keep) > retain_copies? We will retain more than we were instructed. Should we at least output a message in case this is not expected?
Collaborator
Author
|
Will create a new PR after refactoring. |
wangxin
pushed a commit
to wangxin/sonic-mgmt
that referenced
this pull request
Oct 27, 2025
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…-net#3345) * [201811] advance sairedis, swss and utilities sub module heads Submodule src/sonic-utilities f28b720..0a3455b: > [neighbor_advertise]: Use the existing MIRROR ACL table (sonic-net#605) > [neighbor_advertiser] Use full vlan name for vxlan tunnel map programming (sonic-net#604) Submodule src/sonic-swss f44029d..950e9db: > [orchagent] Add support for Innovium platform (sonic-net#1026) > [policerorch]: Add the capability to update policer rate/size (sonic-net#1017) Submodule src/sonic-sairedis 992cdc0..4ee82cb: > [syncd] Add support for Innovium platform (sonic-net#496) Signed-off-by: Ying Xie <ying.xie@microsoft.com> * [201811][utilities] advance sub module head Submodule src/sonic-utilities 0a3455b..7460f5c: > [fast/warm reboot] kill radv docker before stopping BGP (sonic-net#608) Signed-off-by: Ying Xie <ying.xie@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ying Xie ying.xie@microsoft.com
Type of change
Approach
How did you do it?
Before installing a new sonic image, reduce number of installed sonic
images to make space on the harddrive.
How did you verify/test it?
Tested on Arista 7260 platform