[PFCWD] Cancel PFCWD action override on Th5#21088
Merged
bingwang-ms merged 1 commit intosonic-net:masterfrom Oct 24, 2025
Merged
[PFCWD] Cancel PFCWD action override on Th5#21088bingwang-ms merged 1 commit intosonic-net:masterfrom
bingwang-ms merged 1 commit intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
@sdszhang @kperumalbfn Can you help review please? |
11 tasks
bingwang-ms
added a commit
to Azure/sonic-mgmt.msft
that referenced
this pull request
Oct 24, 2025
Cherry-pick sonic-net/sonic-mgmt#21088 <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: This PR is to cancel PFCWD action override at ingress on Th5 platform. The change is required as PFCWD will work on S/W mode (ACL solution) on Th5 as a workaround for a known issue. ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [x] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 ### Approach #### What is the motivation for this PR? This PR is to cancel PFCWD action override at ingress on Th5 platform. #### How did you do it? Remove the code for overriding PFCWD action in `tests/pfcwd/test_pfcwd_function.py` #### How did you verify/test it? The change is verified on a physical testbed. ``` collected 5 items pfcwd/test_pfcwd_function.py::TestPfcwdFunc::test_pfcwd_actions[] PASSED [ 20%] pfcwd/test_pfcwd_function.py::TestPfcwdFunc::test_pfcwd_multi_port[] PASSED [ 40%] pfcwd/test_pfcwd_function.py::TestPfcwdFunc::test_pfcwd_mmu_change[] ... ``` #### Any platform specific information? Th5 platform specific change. #### Supported testbed topology if it's a new test case? Not a new test. ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
Collaborator
Author
|
PR for 202503 Azure/sonic-mgmt.msft#786 |
kperumalbfn
approved these changes
Oct 24, 2025
Collaborator
kperumalbfn
left a comment
There was a problem hiding this comment.
LGTM, pls add the other changes for s/w based PFCWD.
Collaborator
|
@bingwang-ms PR conflicts with 202505 branch |
11 tasks
yejianquan
pushed a commit
that referenced
this pull request
Nov 10, 2025
Description of PR Backport #21088 to 202505 This PR is to cancel PFCWD action override at ingress on Th5 platform. The change is required as PFCWD will work on S/W mode (ACL solution) on Th5 as a workaround for a known issue. Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Approach What is the motivation for this PR? This PR is to cancel PFCWD action override at ingress on Th5 platform. How did you do it? Remove the code for overriding PFCWD action in tests/pfcwd/test_pfcwd_function.py How did you verify/test it? The change is verified on a physical testbed. collected 5 items pfcwd/test_pfcwd_function.py::TestPfcwdFunc::test_pfcwd_actions[] PASSED [ 20%] pfcwd/test_pfcwd_function.py::TestPfcwdFunc::test_pfcwd_multi_port[] PASSED [ 40%] pfcwd/test_pfcwd_function.py::TestPfcwdFunc::test_pfcwd_mmu_change[] ... Any platform specific information? Th5 platform specific change. Supported testbed topology if it's a new test case? Not a new test. signed-off-by: jianquanye@microsoft.com
dcaugher
pushed a commit
to dcaugher/sonic-mgmt
that referenced
this pull request
Nov 12, 2025
dcaugher
pushed a commit
to dcaugher/sonic-mgmt
that referenced
this pull request
Nov 12, 2025
vikumarks
pushed a commit
to vikumarks/sonic-mgmt
that referenced
this pull request
Dec 1, 2025
Signed-off-by: vikumarks <vikumar7ks@gmail.com>
albertovillarreal-keys
pushed a commit
to albertovillarreal-keys/sonic-mgmt
that referenced
this pull request
Dec 2, 2025
Signed-off-by: Alberto Villarreal <alberto.villarreal@keysight.com>
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>
selldinesh
pushed a commit
to selldinesh/sonic-mgmt
that referenced
this pull request
Dec 11, 2025
Signed-off-by: selldinesh <dinesh.sellappan@keysight.com>
echuawu
pushed a commit
to echuawu/sonic-mgmt
that referenced
this pull request
Dec 12, 2025
saravanan-nexthop
pushed a commit
to saravanan-nexthop/sonic-mgmt
that referenced
this pull request
Dec 15, 2025
Signed-off-by: Saravanan <saravanan@nexthop.ai>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
Signed-off-by: Aharon Malkin <amalkin@nvidia.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Jan 13, 2026
yifan-nexthop
pushed a commit
to nexthop-ai/sonic-mgmt
that referenced
this pull request
Jan 14, 2026
Signed-off-by: YiFan Wang <yifan@nexthop.ai>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
lakshmi-nexthop
pushed a commit
to lakshmi-nexthop/sonic-mgmt
that referenced
this pull request
Jan 28, 2026
Signed-off-by: Lakshmi Yarramaneni <lakshmi@nexthop.ai>
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Jan 29, 2026
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Feb 2, 2026
Signed-off-by: Yael Tzur <ytzur@nvidia.com>
abhishek-nexthop
pushed a commit
to nexthop-ai/sonic-mgmt
that referenced
this pull request
Feb 6, 2026
rraghav-cisco
pushed a commit
to rraghav-cisco/sonic-mgmt
that referenced
this pull request
Feb 13, 2026
Signed-off-by: Raghavendran Ramanathan <rraghav@cisco.com>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
This PR is to cancel PFCWD action override at ingress on Th5 platform.
The change is required as PFCWD will work on S/W mode (ACL solution) on Th5 as a workaround for a known issue.
Type of change
Back port request
Approach
What is the motivation for this PR?
This PR is to cancel PFCWD action override at ingress on Th5 platform.
How did you do it?
Remove the code for overriding PFCWD action in
tests/pfcwd/test_pfcwd_function.pyHow did you verify/test it?
The change is verified on a physical testbed.
Any platform specific information?
Th5 platform specific change.
Supported testbed topology if it's a new test case?
Not a new test.
Documentation