Skip to content

[202505] Cancel PFCWD action override on Th5#21238

Merged
yejianquan merged 1 commit intosonic-net:202505from
kewei-arista:pr-sonic.1
Nov 10, 2025
Merged

[202505] Cancel PFCWD action override on Th5#21238
yejianquan merged 1 commit intosonic-net:202505from
kewei-arista:pr-sonic.1

Conversation

@kewei-arista
Copy link
Copy Markdown
Contributor

@kewei-arista kewei-arista commented Nov 7, 2025 •
edited
Loading

Description of PR

Backport #21088 to 202505

This PR is to cancel PFCWD action override at ingress on Th5 platform.
The change is required as PFCWD will work on S/W mode (ACL solution) on Th5 as a workaround for a known issue.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Approach

What is the motivation for this PR?

This PR is to cancel PFCWD action override at ingress on Th5 platform.

How did you do it?

Remove the code for overriding PFCWD action in tests/pfcwd/test_pfcwd_function.py

How did you verify/test it?

The change is verified on a physical testbed.

collected 5 items                                                                                                                                                                                                             

pfcwd/test_pfcwd_function.py::TestPfcwdFunc::test_pfcwd_actions[] 
PASSED                                                                                                                                                                                                                  [ 20%]
pfcwd/test_pfcwd_function.py::TestPfcwdFunc::test_pfcwd_multi_port[] 
PASSED                                                                                                                                                                                                                  [ 40%]
pfcwd/test_pfcwd_function.py::TestPfcwdFunc::test_pfcwd_mmu_change[] 
...

Any platform specific information?

Th5 platform specific change.

Supported testbed topology if it's a new test case?

Not a new test.

Documentation

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Nov 7, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Nov 7, 2025

Azure Pipelines successfully started running 1 pipeline(s).

sdszhang
sdszhang approved these changes Nov 10, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@sdszhang sdszhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@r12f
Copy link
Copy Markdown
Collaborator

r12f commented Nov 10, 2025

hi @kewei-arista , do you mind to update the PR description with the ones in the main PR?

@kewei-arista
Copy link
Copy Markdown
Contributor Author

kewei-arista commented Nov 10, 2025

hi @kewei-arista , do you mind to update the PR description with the ones in the main PR?

@r12f Sure, done.

@yejianquan yejianquan merged commit 8022a49 into sonic-net:202505 Nov 10, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sdszhang sdszhang sdszhang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kewei-arista @mssonicbld @r12f @sdszhang @yejianquan