[pytest]: add remove_ip.sh and arp_responder.py to ptfhost_utils#2001
Merged
theasianpianist merged 1 commit intosonic-net:masterfrom Jul 31, 2020
Merged
Conversation
- create new fixtures to copy remove_ip.sh and arp_responder.py to PTF container - change existing tests to use these fixtures Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
|
This pull request introduces 10 alerts when merging 4162eb6 into f73099c - view on LGTM.com new alerts:
|
daall
approved these changes
Jul 31, 2020
Contributor
Author
|
retest vsimage please |
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
dd71848 [GCU] Show default option for '--format' (sonic-net#2003) f296e76 [GCU] Disallowing DeleteInsteadOfReplaceMoveExtender from generating delete whole config move (sonic-net#2006) 731d643 [flow counter] Fix issue: should not compare str with int (sonic-net#2001) e628f01 Support CLI for buffer queue configuration (sonic-net#1965) 585fd40 Fix show ip bgp nei command rw required issue (sonic-net#2011)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Type of change
Approach
What is the motivation for this PR?
Make the use of pytest fixtures more consistent across tests
How did you do it?
Create fixtures for running
remove_ip.shand copyingarp_responder.pyon PTF hostHow did you verify/test it?
Running the changed tests gives the same results with and without the new fixtures.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation