Skip to content

[pytest]: add remove_ip.sh and arp_responder.py to ptfhost_utils#2001

Merged
theasianpianist merged 1 commit intosonic-net:masterfrom
theasianpianist:refactor-ptfhost-utils
Jul 31, 2020
Merged

[pytest]: add remove_ip.sh and arp_responder.py to ptfhost_utils#2001
theasianpianist merged 1 commit intosonic-net:masterfrom
theasianpianist:refactor-ptfhost-utils

Conversation

@theasianpianist
Copy link
Copy Markdown
Contributor

Description of PR

Summary:

  • create new fixtures to copy remove_ip.sh and arp_responder.py to PTF container
  • change existing tests to use these fixtures

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

Make the use of pytest fixtures more consistent across tests

How did you do it?

Create fixtures for running remove_ip.sh and copying arp_responder.py on PTF host

How did you verify/test it?

Running the changed tests gives the same results with and without the new fixtures.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

- create new fixtures to copy remove_ip.sh and arp_responder.py to PTF container
- change existing tests to use these fixtures

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Jul 31, 2020

This pull request introduces 10 alerts when merging 4162eb6 into f73099c - view on LGTM.com

new alerts:

  • 10 for Unused import

@theasianpianist
Copy link
Copy Markdown
Contributor Author

retest vsimage please

@theasianpianist theasianpianist merged commit b42beb3 into sonic-net:master Jul 31, 2020
@theasianpianist theasianpianist deleted the refactor-ptfhost-utils branch July 31, 2020 18:50
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
dd71848 [GCU] Show default option for '--format' (sonic-net#2003)
f296e76 [GCU] Disallowing DeleteInsteadOfReplaceMoveExtender from generating delete whole config move (sonic-net#2006)
731d643 [flow counter] Fix issue: should not compare str with int (sonic-net#2001)
e628f01 Support CLI for buffer queue configuration (sonic-net#1965)
585fd40 Fix show ip bgp nei command rw required issue (sonic-net#2011)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants