Fix pfcwd error setting poll interval#1965
Merged
neethajohn merged 1 commit intosonic-net:masterfrom Jul 27, 2020
Merged
Conversation
Signed-off-by: Neetha John <nejo@microsoft.com>
tahmed-dev
approved these changes
Jul 25, 2020
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
dd71848 [GCU] Show default option for '--format' (sonic-net#2003) f296e76 [GCU] Disallowing DeleteInsteadOfReplaceMoveExtender from generating delete whole config move (sonic-net#2006) 731d643 [flow counter] Fix issue: should not compare str with int (sonic-net#2001) e628f01 Support CLI for buffer queue configuration (sonic-net#1965) 585fd40 Fix show ip bgp nei command rw required issue (sonic-net#2011)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Neetha John nejo@microsoft.com
Description of PR
Fixes the error seen in test_pfc_config.py run on T1
"stderr": "unable to use polling interval = 400ms, value is bigger than one of the configured detection time values, please choose a smaller polling_interval",
Type of change
How did you verify/test it?
Ran the test with the change and it passed
platform linux2 -- Python 2.7.12, pytest-4.6.9, py-1.8.1, pluggy-0.13.1
ansible: 2.8.7
rootdir: /var/nejo/Networking-acs-sonic-mgmt/tests, inifile: pytest.ini
plugins: ansible-2.2.2
collected 8 items
pfcwd/test_pfc_config.py ........ [100%]
====================================================================================================== 8 passed in 129.54 seconds =======================================================================================================