Skip to content

Fixed 'referenced before assignment' in TestbedProcessing.py#1943

Merged
yxieca merged 1 commit intosonic-net:masterfrom
NazarTkachuk:fix_testbed_processing
Jul 22, 2020
Merged

Fixed 'referenced before assignment' in TestbedProcessing.py#1943
yxieca merged 1 commit intosonic-net:masterfrom
NazarTkachuk:fix_testbed_processing

Conversation

@NazarTkachuk
Copy link
Copy Markdown
Contributor

@NazarTkachuk NazarTkachuk commented Jul 21, 2020

Description of PR

Summary: Fixed issue with local variable ptf_ipv6 in TestbedProcessing.py due to latest changes. see traceback bellow

BACKUP PROCESS STARTED
Error: could not back up group_vars/eos/creds.yml
BACKUP PROCESS COMPLETED
LOADING PROCESS STARTED
LOADING: bfn-testbed.yaml
TestbedProcessing.py:532: YAMLLoadWarning: calling yaml.load() without Loader=... is deprecated, as the default Loader is unsafe. Please read https://msg.pyyaml.org/load for full details.
  doc = yaml.load(open(args.i, 'r'))
LOADING PROCESS COMPLETED
GENERATING FILES FROM CONFIG FILE
        CREATING SONIC LAB LINKS: files/sonic_lab_links.csv
        CREATING SONIC LAB DEVICES: files/sonic_lab_devices.csv
        CREATING TEST BED: testbed.csv
Traceback (most recent call last):
  File "TestbedProcessing.py", line 583, in <module>
    main()
  File "TestbedProcessing.py", line 559, in main
    makeTestbed(testbed, args.basedir + testbed_file)  # Generate testbed.csv (TESTBED)
  File "TestbedProcessing.py", line 230, in makeTestbed
    if not ptf_ipv6:
UnboundLocalError: local variable 'ptf_ipv6' referenced before assignment

Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

Fixed issue with local variable ptf_ipv6 in TestbedProcessing.py

How did you do it?

Define local variable before call

How did you verify/test it?

Run python TestbedProcessing.py -i testbed-new.yaml

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

[IPv6] Fixed 'referenced before assignment'in TestbedProcessing.py
22b757a 
Signed-off-by: Nazar Tkachuk <nazarx.tkachuk@intel.com>
@NazarTkachuk NazarTkachuk changed the title Fixed 'referenced before assignment'in TestbedProcessing.py Fixed 'referenced before assignment' in TestbedProcessing.py Jul 21, 2020
@NazarTkachuk NazarTkachuk force-pushed the fix_testbed_processing branch from f4ce0bf to 22b757a Compare July 21, 2020 15:40
@NazarTkachuk
Copy link
Copy Markdown
Contributor Author

NazarTkachuk commented Jul 21, 2020

@SuvarnaMeenakshi @lguohan @yxieca

@NazarTkachuk
Copy link
Copy Markdown
Contributor Author

NazarTkachuk commented Jul 22, 2020

Can anyone merge with write access?

@yxieca yxieca merged commit a731e23 into sonic-net:master Jul 22, 2020
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@abdosi
[Submodule Update] sonic-utilities
501a233 
f81043b1f9ff02196629655f4735b33afd7f0ae1 (HEAD -> 202111, origin/202111) [port2alias]: Fix to get right number of return values (sonic-net#1906)
bbbf65943ec46e9330eadaed8bcdf1612cb8bd55 [CLI][show bgp] On chassis don't show internal BGP sessions by default (sonic-net#1927)
e12de7e7bf6cff3ec127f261bf88e4d29776d27b [port] Fix port speed set (sonic-net#1952)
cae7af752d484956d7fe40e4c3a849ddad460976 Fix invalid output of syslog IPv6 servers (sonic-net#1933)
6009341ddf790094166be5f0a81b4c114f00220b Routed subinterface enhancements (sonic-net#1821)
6ab9d67ca6550c592b97afb513804be474f84eb0 Enhance sfputil for CMIS QSFP (sonic-net#1949)
76cc67ba4f81c69b20efb3341808037c9db8f703 [debug dump] Refactoring Modules and Unit Tests (sonic-net#1943)
cff58a8171423e4012bc8caf9748996a1e98b7e2 Add command reference for trap flow counters (sonic-net#1876)
71cf3ee43524d56ad57dd90b937cfbf4bf63ba6a [Reclaim buffer] [Mellanox] Db migrator support reclaiming reserved buffer for unused ports (sonic-net#1822)
e699b49fb722e6d6fe5a1d2dacd2d39eb085c1e4 Add show command for BFD sessions (sonic-net#1942)
bb6c5774c843dbfad5f1ba00ee76dae7720902d1 [warm-reboot] Fix failures of warm reboot on disconnect of ssh session (sonic-net#1529)
2e8bbb308477862a76d2327fcf696875e8f08650 Add trap flow counter support (sonic-net#1868)
58407c1386ef13772a9a9320a795e380f162ab2c [load_minigraph] Delay pfcwd start until the buffer templates are rendered (sonic-net#1937)
eb388e0584ba1fe8d8dba58f1c5a148036ffe047 [sonic-package-manager] support sonic-cli-gen and packages with YANG model (sonic-net#1650)
2371d84e7d281bdb9988b5a1a012498dbbfb89ec generic_config_updater: Filename changed & VLAN validator added (sonic-net#1919)
7c0718dfaf23289d4ecc3ada9332e465c9a4e56b [config reload] Update command reference (sonic-net#1941)

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yxieca yxieca yxieca approved these changes

@msosyak msosyak msosyak approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NazarTkachuk @yxieca @msosyak