Update topo_facts from configlet, if present. (#1270)#1529
Merged
renukamanavalan merged 1 commit intosonic-net:masterfrom Apr 2, 2020
Merged
Update topo_facts from configlet, if present. (#1270)#1529renukamanavalan merged 1 commit intosonic-net:masterfrom
renukamanavalan merged 1 commit intosonic-net:masterfrom
Conversation
* Update topo_facts from configlet, if present. * 1) Let any topology file for configlet has the toponame with suffix as "-clet" 2) For every configlet topo, there be a corresponding non-configlet version e.g. t1-64-lag & t1-64-lag-clet. The configlet version would be same as the other, except for few missing VMs that are added later through configlets. But for test data, like topo_facts, we need complete info, so we use the non-configlet version of the topo file. * Removed an unused code chunk and an import * Fixed few bugs.
yxieca
approved these changes
Apr 2, 2020
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
f81043b1f9ff02196629655f4735b33afd7f0ae1 (HEAD -> 202111, origin/202111) [port2alias]: Fix to get right number of return values (sonic-net#1906) bbbf65943ec46e9330eadaed8bcdf1612cb8bd55 [CLI][show bgp] On chassis don't show internal BGP sessions by default (sonic-net#1927) e12de7e7bf6cff3ec127f261bf88e4d29776d27b [port] Fix port speed set (sonic-net#1952) cae7af752d484956d7fe40e4c3a849ddad460976 Fix invalid output of syslog IPv6 servers (sonic-net#1933) 6009341ddf790094166be5f0a81b4c114f00220b Routed subinterface enhancements (sonic-net#1821) 6ab9d67ca6550c592b97afb513804be474f84eb0 Enhance sfputil for CMIS QSFP (sonic-net#1949) 76cc67ba4f81c69b20efb3341808037c9db8f703 [debug dump] Refactoring Modules and Unit Tests (sonic-net#1943) cff58a8171423e4012bc8caf9748996a1e98b7e2 Add command reference for trap flow counters (sonic-net#1876) 71cf3ee43524d56ad57dd90b937cfbf4bf63ba6a [Reclaim buffer] [Mellanox] Db migrator support reclaiming reserved buffer for unused ports (sonic-net#1822) e699b49fb722e6d6fe5a1d2dacd2d39eb085c1e4 Add show command for BFD sessions (sonic-net#1942) bb6c5774c843dbfad5f1ba00ee76dae7720902d1 [warm-reboot] Fix failures of warm reboot on disconnect of ssh session (sonic-net#1529) 2e8bbb308477862a76d2327fcf696875e8f08650 Add trap flow counter support (sonic-net#1868) 58407c1386ef13772a9a9320a795e380f162ab2c [load_minigraph] Delay pfcwd start until the buffer templates are rendered (sonic-net#1937) eb388e0584ba1fe8d8dba58f1c5a148036ffe047 [sonic-package-manager] support sonic-cli-gen and packages with YANG model (sonic-net#1650) 2371d84e7d281bdb9988b5a1a012498dbbfb89ec generic_config_updater: Filename changed & VLAN validator added (sonic-net#1919) 7c0718dfaf23289d4ecc3ada9332e465c9a4e56b [config reload] Update command reference (sonic-net#1941) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…tically (sonic-net#22215) #### Why I did it src/sonic-sairedis ``` * edd144b6 - (HEAD -> 202405, origin/202405) [syncd] Support SAI_SWITCH_ATTR_VXLAN_DEFAULT_ROUTER_MAC (sonic-net#1529) (sonic-net#1568) (2 days ago) [Kamil Cudnik] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update topo_facts from configlet, if present.
e.g. t1-64-lag & t1-64-lag-clet.
The configlet version would be same as the other, except for few missing
VMs that are added later through configlets.
But for test data, like topo_facts, we need complete info, so we use the
non-configlet version of the topo file.
Removed an unused code chunk and an import
Fixed few bugs.
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation