Skip to content

fix PT0 template in t0-isolated topology.#18995

Merged
Blueve merged 4 commits intosonic-net:masterfrom
sdszhang:pt0_topo
Jun 13, 2025
Merged

fix PT0 template in t0-isolated topology.#18995
Blueve merged 4 commits intosonic-net:masterfrom
sdszhang:pt0_topo

Conversation

@sdszhang
Copy link
Copy Markdown
Contributor

@sdszhang sdszhang commented Jun 13, 2025 •
edited
Loading

Description of PR

Summary:
Two issues:

  1. PT0 should use different template with T1 neighbors.
  2. the current bp_interface subnet is: 10.10.246.0/22 (10.10.244.0-10.10.247.255). while in t0-isolated topology, the bp_interface may choose 10.10.248.2 or 10.10.248.3 which is outside the range.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Approach

What is the motivation for this PR?

Fix bp_interface and PT0 template for t0-isolated topology

How did you do it?

How did you verify/test it?

Before the fix:

admin@str4-sn5640-2:~$ show ip bgp summary
.....
Neighbhor      V     AS    MsgRcvd    MsgSent    TblVer    InQ    OutQ  Up/Down      State/PfxRcd  NeighborName
-----------  ---  -----  ---------  ---------  --------  -----  ------  ---------  --------------  --------------
......
10.0.4.1       4  65101        230        227    160852      0       0  03:11:47                0  ARISTA01PT0
10.0.4.3       4  65102        232        227    160852      0       0  03:11:52                0  ARISTA02PT0

Total number of neighbors 34
admin@str4-sn5640-2:~$ 
admin@str4-sn5640-2:~$ show ip bgp neighbor 10.0.4.1 routes

admin@str4-sn5640-2:~$

After the fix:

admin@str5-7060x6-512-3:~$ show ip bgp summary
......
Neighbhor      V     AS    MsgRcvd    MsgSent    TblVer    InQ    OutQ  Up/Down      State/PfxRcd  NeighborName
-----------  ---  -----  ---------  ---------  --------  -----  ------  ---------  --------------  --------------
......
10.0.4.1       4  65101       9676        169     46533      0       0  00:10:47                1  ARISTA01PT0
10.0.4.3       4  65102       9688        181     46533      0       0  00:10:46                1  ARISTA02PT0

admin@str5-7060x6-512-3:~$ show ip bgp neighbors 10.0.4.1 routes 
BGP table version is 46533, local router ID is 10.1.0.32, vrf id 0
Default local pref 100, local AS 65100
Status codes:  s suppressed, d damped, h history, u unsorted, * valid, > best, = multipath,
               i internal, r RIB-failure, S Stale, R Removed
Nexthop codes: @NNN nexthop's vrf id, < announce-nh-self
Origin codes:  i - IGP, e - EGP, ? - incomplete
RPKI validation codes: V valid, I invalid, N Not found

    Network          Next Hop            Metric LocPrf Weight Path
 *= 0.0.0.0/0        10.0.4.1                               0 65101 65534 6666 6667 i

Displayed 1 routes and 203780 total paths
admin@str5-7060x6-512-3:~$

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Jun 13, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Jun 13, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@sdszhang
Copy link
Copy Markdown
Contributor Author

sdszhang commented Jun 13, 2025

@r12f @w1nda @Blueve for review

@sdszhang sdszhang changed the title Correct PT0 template for t0-isolated topology. fix PT0 template in t0-isolated topology. Jun 13, 2025
Blueve
Blueve previously approved these changes Jun 13, 2025
View reviewed changes
@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Jun 13, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Jun 13, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Jun 13, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Jun 13, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Jun 13, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Jun 13, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Jun 13, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Jun 13, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@Blueve Blueve enabled auto-merge (squash) June 13, 2025 15:26
@Blueve Blueve merged commit 939485f into sonic-net:master Jun 13, 2025
18 checks passed
sdszhang added a commit to sdszhang/sonic-mgmt that referenced this pull request Jun 14, 2025
@sdszhang
fix PT0 template in t0-isolated topology (sonic-net#18995)
74854e9 
Summary:
Two issues:
PT0 should use different template with T1 neighbors.
the current bp_interface subnet is: 10.10.246.0/22 (10.10.244.0-10.10.247.255). while in t0-isolated topology, the bp_interface may choose 10.10.248.2 or 10.10.248.3 which is outside the range.

What is the motivation for this PR?
Fix bp_interface and PT0 template for t0-isolated topology

(cherry picked from commit 939485f)
@sdszhang
Copy link
Copy Markdown
Contributor Author

sdszhang commented Jun 14, 2025

msft-202412 cherry-pick: Azure/sonic-mgmt.msft#402

@sdszhang sdszhang mentioned this pull request Jun 16, 2025
Closed
11 tasks
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Jun 16, 2025
@sdszhang @mssonicbld
fix PT0 template in t0-isolated topology (sonic-net#18995)
4d9b366 
Summary:
Two issues:
PT0 should use different template with T1 neighbors.
the current bp_interface subnet is: 10.10.246.0/22 (10.10.244.0-10.10.247.255). while in t0-isolated topology, the bp_interface may choose 10.10.248.2 or 10.10.248.3 which is outside the range.

What is the motivation for this PR?
Fix bp_interface and PT0 template for t0-isolated topology
@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Jun 16, 2025

Cherry-pick PR to 202505: #19012

@mssonicbld mssonicbld mentioned this pull request Jun 16, 2025
Merged
11 tasks
mssonicbld pushed a commit that referenced this pull request Jun 19, 2025
@sdszhang @mssonicbld
fix PT0 template in t0-isolated topology (#18995)
ce16579 
Summary:
Two issues:
PT0 should use different template with T1 neighbors.
the current bp_interface subnet is: 10.10.246.0/22 (10.10.244.0-10.10.247.255). while in t0-isolated topology, the bp_interface may choose 10.10.248.2 or 10.10.248.3 which is outside the range.

What is the motivation for this PR?
Fix bp_interface and PT0 template for t0-isolated topology
sdszhang added a commit to sdszhang/sonic-mgmt that referenced this pull request Jun 30, 2025
@sdszhang
[202412] fix PT0 template in t0-isolated topology (sonic-net#18995) (s…
b2387c0 
…onic-net#402)

Summary:
Two issues:
PT0 should use different template with T1 neighbors. the current
bp_interface subnet is: 10.10.246.0/22 (10.10.244.0-10.10.247.255).
while in t0-isolated topology, the bp_interface may choose 10.10.248.2
or 10.10.248.3 which is outside the range.

What is the motivation for this PR?
Fix bp_interface and PT0 template for t0-isolated topology

(cherry picked from commit 939485f)
nissampa pushed a commit to nissampa/sonic-mgmt_dpu_test that referenced this pull request Aug 7, 2025
@sdszhang @nissampa
fix PT0 template in t0-isolated topology (sonic-net#18995)
9a08cb4 
Summary:
Two issues:
PT0 should use different template with T1 neighbors.
the current bp_interface subnet is: 10.10.246.0/22 (10.10.244.0-10.10.247.255). while in t0-isolated topology, the bp_interface may choose 10.10.248.2 or 10.10.248.3 which is outside the range.

What is the motivation for this PR?
Fix bp_interface and PT0 template for t0-isolated topology
opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025
@sdszhang
fix PT0 template in t0-isolated topology (sonic-net#18995)
9b2a94b 
Summary:
Two issues:
PT0 should use different template with T1 neighbors.
the current bp_interface subnet is: 10.10.246.0/22 (10.10.244.0-10.10.247.255). while in t0-isolated topology, the bp_interface may choose 10.10.248.2 or 10.10.248.3 which is outside the range.

What is the motivation for this PR?
Fix bp_interface and PT0 template for t0-isolated topology

Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 16, 2025
@sdszhang @gshemesh2
fix PT0 template in t0-isolated topology (sonic-net#18995)
f967c5e 
Summary:
Two issues:
PT0 should use different template with T1 neighbors.
the current bp_interface subnet is: 10.10.246.0/22 (10.10.244.0-10.10.247.255). while in t0-isolated topology, the bp_interface may choose 10.10.248.2 or 10.10.248.3 which is outside the range.

What is the motivation for this PR?
Fix bp_interface and PT0 template for t0-isolated topology

Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Dec 16, 2025
@sdszhang @AharonMalkin
fix PT0 template in t0-isolated topology (sonic-net#18995)
cdd62a3 
Summary:
Two issues:
PT0 should use different template with T1 neighbors.
the current bp_interface subnet is: 10.10.246.0/22 (10.10.244.0-10.10.247.255). while in t0-isolated topology, the bp_interface may choose 10.10.248.2 or 10.10.248.3 which is outside the range.

What is the motivation for this PR?
Fix bp_interface and PT0 template for t0-isolated topology

Signed-off-by: Aharon Malkin <amalkin@nvidia.com>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
@sdszhang @gshemesh2
fix PT0 template in t0-isolated topology (sonic-net#18995)
623dfed 
Summary:
Two issues:
PT0 should use different template with T1 neighbors.
the current bp_interface subnet is: 10.10.246.0/22 (10.10.244.0-10.10.247.255). while in t0-isolated topology, the bp_interface may choose 10.10.248.2 or 10.10.248.3 which is outside the range.

What is the motivation for this PR?
Fix bp_interface and PT0 template for t0-isolated topology

Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Jan 13, 2026
@sdszhang @venu-nexthop
fix PT0 template in t0-isolated topology (sonic-net#18995)
c58a91b 
Summary:
Two issues:
PT0 should use different template with T1 neighbors.
the current bp_interface subnet is: 10.10.246.0/22 (10.10.244.0-10.10.247.255). while in t0-isolated topology, the bp_interface may choose 10.10.248.2 or 10.10.248.3 which is outside the range.

What is the motivation for this PR?
Fix bp_interface and PT0 template for t0-isolated topology
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026
@sdszhang @gshemesh2
fix PT0 template in t0-isolated topology (sonic-net#18995)
d89e6ba 
Summary:
Two issues:
PT0 should use different template with T1 neighbors.
the current bp_interface subnet is: 10.10.246.0/22 (10.10.244.0-10.10.247.255). while in t0-isolated topology, the bp_interface may choose 10.10.248.2 or 10.10.248.3 which is outside the range.

What is the motivation for this PR?
Fix bp_interface and PT0 template for t0-isolated topology

Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
ytzur1 pushed a commit to ytzur1/sonic-mgmt that referenced this pull request Feb 2, 2026
@sdszhang @ytzur1
fix PT0 template in t0-isolated topology (sonic-net#18995)
5eb5f15 
Summary:
Two issues:
PT0 should use different template with T1 neighbors.
the current bp_interface subnet is: 10.10.246.0/22 (10.10.244.0-10.10.247.255). while in t0-isolated topology, the bp_interface may choose 10.10.248.2 or 10.10.248.3 which is outside the range.

What is the motivation for this PR?
Fix bp_interface and PT0 template for t0-isolated topology

Signed-off-by: Yael Tzur <ytzur@nvidia.com>
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Mar 27, 2026
@sdszhang
fix PT0 template in t0-isolated topology (sonic-net#18995)
0fd742e 
Summary:
Two issues:
PT0 should use different template with T1 neighbors.
the current bp_interface subnet is: 10.10.246.0/22 (10.10.244.0-10.10.247.255). while in t0-isolated topology, the bp_interface may choose 10.10.248.2 or 10.10.248.3 which is outside the range.

What is the motivation for this PR?
Fix bp_interface and PT0 template for t0-isolated topology
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Blueve Blueve Blueve approved these changes

Assignees

No one assigned

Labels

Approved for msft-202412 Branch Approved for 202505 branch Cherry Pick Conflict_msft-202412 Included in msft-202412 Branch Included in 202505 branch Request for msft-202412 Branch Request for 202505 branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sdszhang @mssonicbld @Blueve @r12f @yejianquan