Skip to content

[action] [PR:18995] fix PT0 template in t0-isolated topology.#19012

Merged
mssonicbld merged 1 commit intosonic-net:202505from
mssonicbld:cherry/202505/18995
Jun 19, 2025
Merged

[action] [PR:18995] fix PT0 template in t0-isolated topology.#19012
mssonicbld merged 1 commit intosonic-net:202505from
mssonicbld:cherry/202505/18995

Conversation

@mssonicbld
Copy link
Copy Markdown
Collaborator

@mssonicbld mssonicbld commented Jun 16, 2025

Description of PR

Summary:
Two issues:

  1. PT0 should use different template with T1 neighbors.
  2. the current bp_interface subnet is: 10.10.246.0/22 (10.10.244.0-10.10.247.255). while in t0-isolated topology, the bp_interface may choose 10.10.248.2 or 10.10.248.3 which is outside the range.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
  • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Approach

What is the motivation for this PR?

Fix bp_interface and PT0 template for t0-isolated topology

How did you do it?

How did you verify/test it?

Before the fix:

admin@str4-sn5640-2:~$ show ip bgp summary
.....
Neighbhor V AS MsgRcvd MsgSent TblVer InQ OutQ Up/Down State/PfxRcd NeighborName
----------- --- ----- --------- --------- -------- ----- ------ --------- -------------- --------------
......
10.0.4.1 4 65101 230 227 160852 0 0 03:11:47 0 ARISTA01PT0
10.0.4.3 4 65102 232 227 160852 0 0 03:11:52 0 ARISTA02PT0

Total number of neighbors 34
admin@str4-sn5640-2:~$ 
admin@str4-sn5640-2:~$ show ip bgp neighbor 10.0.4.1 routes

admin@str4-sn5640-2:~$

After the fix:

admin@str5-7060x6-512-3:~$ show ip bgp summary
......
Neighbhor V AS MsgRcvd MsgSent TblVer InQ OutQ Up/Down State/PfxRcd NeighborName
----------- --- ----- --------- --------- -------- ----- ------ --------- -------------- --------------
......
10.0.4.1 4 65101 9676 169 46533 0 0 00:10:47 1 ARISTA01PT0
10.0.4.3 4 65102 9688 181 46533 0 0 00:10:46 1 ARISTA02PT0

admin@str5-7060x6-512-3:~$ show ip bgp neighbors 10.0.4.1 routes 
BGP table version is 46533, local router ID is 10.1.0.32, vrf id 0
Default local pref 100, local AS 65100
Status codes: s suppressed, d damped, h history, u unsorted, LICENSE README.md SECURITY.md ansible azure-pipelines.yml docs git pylintrc pyproject.toml sdn_tests setup-container.sh spytest test_reporting tests valid, > best, = multipath,
 i internal, r RIB-failure, S Stale, R Removed
Nexthop codes: @NNN nexthop's vrf id, < announce-nh-self
Origin codes: i - IGP, e - EGP, ? - incomplete
RPKI validation codes: V valid, I invalid, N Not found

 Network Next Hop Metric LocPrf Weight Path
 *= 0.0.0.0/0 10.0.4.1 0 65101 65534 6666 6667 i

Displayed 1 routes and 203780 total paths
admin@str5-7060x6-512-3:~$

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@sdszhang @mssonicbld
fix PT0 template in t0-isolated topology (sonic-net#18995)
4d9b366 
Summary:
Two issues:
PT0 should use different template with T1 neighbors.
the current bp_interface subnet is: 10.10.246.0/22 (10.10.244.0-10.10.247.255). while in t0-isolated topology, the bp_interface may choose 10.10.248.2 or 10.10.248.3 which is outside the range.

What is the motivation for this PR?
Fix bp_interface and PT0 template for t0-isolated topology
@mssonicbld mssonicbld mentioned this pull request Jun 16, 2025
Merged
11 tasks
@mssonicbld
Copy link
Copy Markdown
Collaborator Author

mssonicbld commented Jun 16, 2025

Original PR: #18995

@mssonicbld
Copy link
Copy Markdown
Collaborator Author

mssonicbld commented Jun 16, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Jun 16, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@yejianquan
Copy link
Copy Markdown
Collaborator

yejianquan commented Jun 18, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Jun 18, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld mssonicbld merged commit ce16579 into sonic-net:202505 Jun 19, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

automerge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mssonicbld @yejianquan @sdszhang