Integrating IO with continuous warm reboot test#1880
Merged
vaibhavhd merged 7 commits intosonic-net:masterfrom Jul 17, 2020
Merged
Integrating IO with continuous warm reboot test#1880vaibhavhd merged 7 commits intosonic-net:masterfrom
vaibhavhd merged 7 commits intosonic-net:masterfrom
Conversation
|
This pull request introduces 2 alerts and fixes 1 when merging 6caaa07 into 49e6236 - view on LGTM.com new alerts:
fixed alerts:
|
wangxin
requested changes
Jul 13, 2020
yxieca
reviewed
Jul 13, 2020
|
This pull request introduces 2 alerts and fixes 1 when merging a27998a into aec9f58 - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request introduces 2 alerts and fixes 1 when merging 728975e into aec9f58 - view on LGTM.com new alerts:
fixed alerts:
|
wangxin
approved these changes
Jul 15, 2020
tahmed-dev
reviewed
Jul 15, 2020
|
|
||
| for _ in range(continuous_reboot_count): | ||
| # Start advancedReboot script on the ptf host to enable continuous I/O | ||
| advancedReboot = get_advanced_reboot(rebootType='warm-reboot', enableContinuousIO=enable_continuous_io) |
Contributor
There was a problem hiding this comment.
I believe with this change the AdvancedReboot class/Fixture name should be changed as it is not doing reboot anymore!
Contributor
Author
There was a problem hiding this comment.
Based on the discussion offline - In general, the AdvancedReboot class(and in turn advanced-reboot script) is doing more than just reboot - starting I/O, monitor control/data plane, verifies BGP sessions and more.
The script now needs to be broken down to meaningful modules for simplicity and better organization.
These changes are outside the context of the PR1880 and will be taken care of in a different PR in the near future.
|
This pull request introduces 2 alerts and fixes 1 when merging c954173 into b22f3cf - view on LGTM.com new alerts:
fixed alerts:
|
yxieca
approved these changes
Jul 17, 2020
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Why I did it Update the sonic-swss submodule for the 202012 branch. The following is the new commit in the submodule. c1cb2ca [202012] Backport SAI failure handling to 202012 branch (sonic-net#1880) How I did it Update the sonic-swss submodule pointer for the 202012 branch.
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
snmpagent * 187aa10 2021-09-16 | [201811][RFC1213]: Initialize lag oid map in reinit_data (sonic-net#233) (github/201811) [SuvarnaMeenakshi] swss: * 3503705 2021-09-05 | [201811][Cherry-pick] [acl mirror action] Mirror session ref count fix at acl rule attachment (sonic-net#1898) (HEAD -> 201811, github/201811) [bingwang-ms] utilities: * f3f8667 2021-10-15 | [201811] disk_check.py: Allow remote user access when disk is read-only (sonic-net#1873) (HEAD -> 201811, github/201811) [Renuka Manavalan] * 6b351c9 2021-10-14 | [201811] Remove exec from platform_reboot_plugin call to handle any hang issue. (sonic-net#1880) [Sujin Kang] * d8d0461 2021-07-29 | [minigraph][port_config] Consume port_config.json while reloading minigraph (sonic-net#1726) [Blueve] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
* Add DHCPv6 minigraph parsing support Co-authored-by: shlomibitton <60430976+shlomibitton@users.noreply.github.com> Logrotate for wtmp and btmp files to fix size getting too large. (sonic-net#8744) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com> [201811][utilities][swss][snmpagent] advance sub module head snmpagent * 187aa10 2021-09-16 | [201811][RFC1213]: Initialize lag oid map in reinit_data (sonic-net#233) (github/201811) [SuvarnaMeenakshi] swss: * 3503705 2021-09-05 | [201811][Cherry-pick] [acl mirror action] Mirror session ref count fix at acl rule attachment (sonic-net#1898) (HEAD -> 201811, github/201811) [bingwang-ms] utilities: * f3f8667 2021-10-15 | [201811] disk_check.py: Allow remote user access when disk is read-only (sonic-net#1873) (HEAD -> 201811, github/201811) [Renuka Manavalan] * 6b351c9 2021-10-14 | [201811] Remove exec from platform_reboot_plugin call to handle any hang issue. (sonic-net#1880) [Sujin Kang] * d8d0461 2021-07-29 | [minigraph][port_config] Consume port_config.json while reloading minigraph (sonic-net#1726) [Blueve] Signed-off-by: Ying Xie <ying.xie@microsoft.com> [201811] Invoke disk check periodically (sonic-net#8951) * Invoke disk check periodically. (sonic-net#7374) Why I did it Helps with periodic scan of disk for RO state. If found, this script makes transient fix and raise error message. Save DB dump after warm/fast reboot (sonic-net#8913) Back porting the master branch change - sonic-net#8803 Save the redis DB dump after warm reboot. [201811][swss] advance swss submodule head (sonic-net#9049) * e0b115a 2021-10-22 | [copp] add dhcpv6 copp rules (sonic-net#1979) (HEAD -> 201811, github/201811) [Ying Xie] Signed-off-by: Ying Xie <ying.xie@microsoft.com> [swssconfig] load dhcpv6 copp rules by default (sonic-net#9047) Why I did it Need to enable DHCPv6 copp rule How I did it Add a separate DHCPv6 copp rule config file and load it during cold reboot. How to verify it cold reboot, and verify config being loaded and dhcpv6 rules got installed. Signed-off-by: Ying Xie ying.xie@microsoft.com [warmboot finalizer] load dhcpv6 copp rules when missing (sonic-net#9048) Why I did it Need to enable DHCPv6 COPP rules. How I did it Load the separate DHCPv6 COPP rules after warm reboot if the rules are missing. How to verify it Warm reboot from an image doesn't have DHCPv6 COPP rules installed. Warm reboot from an image have DHCPv6 COPP rules already installed. In either case, the script did the right thing and only install the COPP rules if it is missing. Signed-off-by: Ying Xie ying.xie@microsoft.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Enable continuous I/O support for continuous warm reboot testcase.
Fixes # (issue)
Type of change
Approach
The advanced-reboot script contains a state-machine logic to enable/start/stop the I/O on a PTF host.
A hook is placed to enable continuous I/O to enable useful monitoring the control/data planes while the DUT is continuously warm-rebooting.
The
enable_continuous_ioparameter stops the advanced-reboot script right when I/O monitors have begun.When cont_warm_reboot test finishes, the daemon running advanced-reboot script is signalled to stop the I/O monitoring.
What is the motivation for this PR?
To enable I/O monitoring as part of test_cont_warm_reboot test.
How did you do it?
Added a new parameter -
enable_continuous_io.Added a signaling mechanism between
cont_warm_rebootandadvanced-rebootscripts running ontestbedandptfhostrespectively.How did you verify/test it?
Tested on a DUT successfully with warm-reboot and I/O monitor going concurrently.
Documentation