Remove skip condition for test_cacl_application since issue was fixed#7374
Merged
ZhaohuiS merged 1 commit intosonic-net:masterfrom Feb 2, 2023
Merged
Conversation
Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>
lipxu
approved these changes
Feb 1, 2023
SuvarnaMeenakshi
approved these changes
Feb 1, 2023
kellyyeh
pushed a commit
to kellyyeh/sonic-mgmt
that referenced
this pull request
Mar 31, 2023
…sonic-net#7374) What is the motivation for this PR? Issue sonic-net#12464 was fixed in sonic-net#7092. How did you do it? Remove skip condition for test_cacl_application.py How did you verify/test it? Run test_cacl_application.py against master image. Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zhaohui Sun zhaohuisun@microsoft.com
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Issue #12464 was fixed in #7092.
How did you do it?
Remove skip condition for
test_cacl_application.pyHow did you verify/test it?
Run
test_cacl_application.pyagainst master image.Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation