Add variables for fanout creds and fix FanoutHost shutdown/no_shutdown issue#1805
Merged
yxieca merged 1 commit intosonic-net:masterfrom Jun 23, 2020
wangxin:fanout-network-creds
Merged
Add variables for fanout creds and fix FanoutHost shutdown/no_shutdown issue#1805yxieca merged 1 commit intosonic-net:masterfrom wangxin:fanout-network-creds
yxieca merged 1 commit intosonic-net:masterfrom
wangxin:fanout-network-creds
Conversation
…n issue PR #1742 introduced two sets of fanout variables as credentials for accessing the fanout network cli and linux shell. This change explicitly define the variables in ansible/group_vars/fanout/secrets.yml. After this PR is merged, please remember to update the credentials in ansible/group_vars/fanout/secrets.yml file to the actual values of your lab configuration. Another change in this PR is to fix the issue of getting results of FanoutHost shutdown and no_shutdown methods. The results are directly returned by inner function call. It's unnecessary and wrong to get results using dictionary `key self.hostname`. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
yxieca
approved these changes
Jun 23, 2020
tahmed-dev
reviewed
Jun 23, 2020
tahmed-dev
approved these changes
Jun 23, 2020
neethajohn
approved these changes
Jun 23, 2020
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
25f7c79 [sonic-package-manager] remove make_python_identifier (sonic-net#1801) 84a7602 [sonic-package-manager] stop service explicitelly before uninstalling package (sonic-net#1805)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
PR #1742 introduced two sets of fanout variables as credentials for accessing
the fanout network cli and linux shell. This change explicitly define the variables
in ansible/group_vars/fanout/secrets.yml.
After this PR is merged, please remember to update the credentials in
ansible/group_vars/fanout/secrets.yml file to the actual values of your
lab configuration.
Another change in this PR is to fix the issue of getting results of
FanoutHost shutdown and no_shutdown methods. The results
are directly returned by inner function call. It's unnecessary and
wrong to get results using dictionary
key self.hostname.Type of change
Approach
What is the motivation for this PR?
Explicitly define variables introduced by #1742 in ansible/group_vars/fanout/secrets.yml and fix issue in FanoutHost shutdown/no_shutdown methods.
How did you do it?
fanout_network_user,fanout_network_password,fanout_shell_userandfanout_shell_passwordinansible/group_vars/fanout/secrets.yml.self.hostname.How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation