Add topology-marker override logic #1801
Merged
bingwang-ms merged 1 commit intosonic-net:masterfrom Jun 24, 2020
Merged
Conversation
neethajohn
reviewed
Jun 22, 2020
Contributor
|
Can you also update this doc to specify the marker override behavior in the test categorization section? |
1c334c5 to
ea9175a
Compare
Collaborator
Author
Done. |
neethajohn
reviewed
Jun 23, 2020
tests/docs/pytest.org.md
Outdated
Contributor
There was a problem hiding this comment.
specify dummy names for inventory, hostname, tb, tb_file
neethajohn
approved these changes
Jun 23, 2020
ea9175a to
f7c3b04
Compare
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
25f7c79 [sonic-package-manager] remove make_python_identifier (sonic-net#1801) 84a7602 [sonic-package-manager] stop service explicitelly before uninstalling package (sonic-net#1805)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Add marker override logic in test framework.
Type of change
Approach
What is the motivation for this PR?
We need to find a easier way to organize testcases according to topologies.
How did you do it?
Update check_topology in tests/common/plugins/custom_markers/_ init _.py.
Basicly, topology marker is given to a module, but the higher level topology marker is overrided when a lower topology marker is given. For example, the testcase level marker overrides the marker on module level.
How did you verify/test it?
Run testcases with different topo markers.
Any platform specific information?
No.
Supported testbed topology if it's a new test case?
No.
Documentation
https://github.com/Azure/sonic-mgmt/blob/master/tests/docs/pytest.org.md (updated in this pr)