Skip to content

[everflow] provide j2 templates for pytest#1681

Merged
daall merged 1 commit intosonic-net:masterfrom
mykolaf:everflow
May 19, 2020
Merged

[everflow] provide j2 templates for pytest#1681
daall merged 1 commit intosonic-net:masterfrom
mykolaf:everflow

Conversation

@mykolaf
Copy link
Copy Markdown
Contributor

@mykolaf mykolaf commented May 18, 2020

Change-Id: Ia9826b092ba49a3b24853fbd2ea2351fc59d33a8
Signed-off-by: Mykola Faryma mykolaf@mellanox.com

Description of PR

After recent reorg tests info subfolder the everflow testcase setup failed, due to missing templates.
The templates were left in test/templates. Created symlinks in tests/everflow/templates

Summary:
Fixes # (issue)

 \"cmd\": [\"acl-loader\", \"update\", \"full\", \"/home/admin/everflow_tests/acl_rule_persistent.json\", \"--session_name=test_session_1\", \"--mirror_stage=egress\"], \"failed\": true, \"delta\": \"0:00:00.261270\", \"stderr\": \"Usage: acl-loader update full [OPTIONS] FILENAME\\\\n\\\\nError: Invalid value for \\\\\"filename\\\\\": Path \\\\\"/home/admin/everflow_tests/acl_rule_persistent.json\\\\\" does not exist.\", \"rc\": 2

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Change-Id: Ia9826b092ba49a3b24853fbd2ea2351fc59d33a8
Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
@akokhan
Copy link
Copy Markdown
Contributor

akokhan commented May 18, 2020

Comes as a part of
#1675

@abdosi abdosi requested review from abdosi and daall May 19, 2020 16:57
@daall
Copy link
Copy Markdown
Contributor

daall commented May 19, 2020

@mykolaf we're going to try to get #1675 merged so there's no merge conflicts to deal with.

Copy link
Copy Markdown
Contributor

@daall daall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still cleans up the general templates folder so we should still merge it. :)

@daall daall merged commit 6202b4d into sonic-net:master May 19, 2020
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
Update submodule for sonic-utilities to include the following PRs:

Make the soft-reboot available in the SONiC image on master (sonic-net#1681)
[config]: Update environment file during config reload (sonic-net#1673)
Enable pr checker form 202012 (sonic-net#1649)
[config] support for configuring muxcable to manual mode of operation (sonic-net#1642)
[config] Fix config int add incorrect ip (sonic-net#1414)

Signed-off-by: Dror Prital <drorp@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants