Conversation
| ttl=ttl) | ||
| dst_port_2_id = self.get_rx_port( | ||
| src_port_id, pkt_dst_mac, dst_port_2_ip, src_port_ip, dst_port_2_id, src_port_vlan | ||
| src_port_id, pkt_dst_mac2, dst_port_2_ip, src_port_ip, dst_port_2_id, src_port_vlan |
There was a problem hiding this comment.
No, tests pass with this fix also on t1 topology, also this fix is included in 202305 Xon test code, this is not new code to the test.
There was a problem hiding this comment.
pkt2 = construct_ip_pkt(packet_length,
pkt_dst_mac,
src_port_mac,
src_port_ip,
dst_port_2_ip,
dscp,
src_port_vlan,
ecn=ecn,
ttl=ttl)
@slutati1536 shouldn't we be passing pkt_dst_mac2 here as well instead of pkt_dst_mac? We are seeing this same failure on Arista-7050CX3-32S-C32 and just this addition to your fix fixes that for us.
And again this additional change already exists in 202305 so it won't break T1.
|
Cherry picked to 202311: #12648 with additional fix. |
Raised #12649 for this additional fix to master. Keeping @StormLiangMS in the loop. |
Without this PR the Qos tests would fail on testQosSaiPfcXonLimit, because step 1 of the tests, which disable TX for dst_port_id, dst_port_2_id, dst_port_3_id is getting incorrect DST ports Test was broken by sonic-net#9780
|
Cherry-pick PR to 202311: #12885 |
Without this PR the Qos tests would fail on testQosSaiPfcXonLimit, because step 1 of the tests, which disable TX for dst_port_id, dst_port_2_id, dst_port_3_id is getting incorrect DST ports Test was broken by #9780
Description of PR
Without this PR the Qos tests would fail on testQosSaiPfcXonLimit, because step 1 of the tests, which disable TX for dst_port_id, dst_port_2_id, dst_port_3_id is getting incorrect DST ports
Test was broken by: #9780
Type of change
Back port request
Approach
What is the motivation for this PR?
With my fix:
step 1: disable TX for dst_port_id, dst_port_2_id, dst_port_3_id
[dst_port_id, dst_port_2_id, dst_port_3_id] = [1, 3, 4]
Without my fix:
step 1: disable TX for dst_port_id, dst_port_2_id, dst_port_3_id
[dst_port_id, dst_port_2_id, dst_port_3_id] = [1, 1, 1]
How did you do it?
Run the tests to find the root cause of the failure
How did you verify/test it?
Run the tests with my fix to see that the tests are passing
Any platform-specific information?
tests only failed on SN2700 with t0 topology
and SN4700 with t0-56-o8v48/t1-28-lag