[action] [PR:12151] Fix Qos Xon Test#12885
Merged
mssonicbld merged 1 commit intosonic-net:202311from May 17, 2024
Merged
Conversation
Without this PR the Qos tests would fail on testQosSaiPfcXonLimit, because step 1 of the tests, which disable TX for dst_port_id, dst_port_2_id, dst_port_3_id is getting incorrect DST ports Test was broken by sonic-net#9780
Collaborator
Author
|
Original PR: #12151 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Without this PR the Qos tests would fail on testQosSaiPfcXonLimit, because step 1 of the tests, which disable TX for dst_port_id, dst_port_2_id, dst_port_3_id is getting incorrect DST ports
Test was broken by: #9780
Type of change
Back port request
Approach
What is the motivation for this PR?
With my fix:
step 1: disable TX for dst_port_id, dst_port_2_id, dst_port_3_id
[dst_port_id, dst_port_2_id, dst_port_3_id] = [1, 3, 4]
Without my fix:
step 1: disable TX for dst_port_id, dst_port_2_id, dst_port_3_id
[dst_port_id, dst_port_2_id, dst_port_3_id] = [1, 1, 1]
How did you do it?
Run the tests to find the root cause of the failure
How did you verify/test it?
Run the tests with my fix to see that the tests are passing
Any platform-specific information?
tests only failed on SN2700 with t0 topology
and SN4700 with t0-56-o8v48/t1-28-lag