[simx vt] add infra to skip tests not suitable on virtual testbed#1158
Merged
liat-grozovik merged 1 commit intosonic-net:masterfrom Nov 17, 2019
Merged
[simx vt] add infra to skip tests not suitable on virtual testbed#1158liat-grozovik merged 1 commit intosonic-net:masterfrom
liat-grozovik merged 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
liat-grozovik
approved these changes
Oct 16, 2019
Collaborator
|
Is that correct that by default if this line is not present 'vtestbed_compatible: no' it means that a test can run on virtual environment. |
neethajohn
approved these changes
Oct 17, 2019
lguohan
reviewed
Oct 18, 2019
|
|
||
| - block: | ||
| - name: include snmp cpu test | ||
| include: roles/test/tasks/snmp/cpu.yml |
Contributor
There was a problem hiding this comment.
why cpu test is not available in simx?
Collaborator
There was a problem hiding this comment.
the tests seems not to working mostly does not look that it does what it aims to do
More investigation is required and will be done regardless of this PR.
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Submodule src/sonic-swss e237e12d..0329b678: > [restore_neighbors.py] build arp packet with correct hwsrc and psrc (sonic-net#1158) Submodule src/sonic-utilities 23cc3094..49ab6b1f: > [acl-loader] Use V6 ethertype for IPv6 ACL rule (sonic-net#788) Signed-off-by: Ying Xie <ying.xie@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mykola Faryma mykolaf@mellanox.com
Description of PR
Summary:
Fixes # (issue)
Related to #1157
Some tests can not be run on a virtual topology, due to missing fanout(PFC for example) or those relying on platform stuff (sensors, platform).
Need a way to skip execution of these tests.
Type of change
Approach
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation