Skip to content

[simx vt] Add Mellanox SimX virtual testbed infra #1157

Merged
liat-grozovik merged 6 commits intosonic-net:masterfrom
mykolaf:vt_infra
Nov 17, 2019
Merged

[simx vt] Add Mellanox SimX virtual testbed infra #1157
liat-grozovik merged 6 commits intosonic-net:masterfrom
mykolaf:vt_infra

Conversation

@mykolaf
Copy link
Copy Markdown
Contributor

@mykolaf mykolaf commented Oct 15, 2019

Description of PR

Summary:
Fixes # (issue)

Add a few playbooks which allow to use t0 virtual testbed with Mellanox SimX simulator.
SimX is a functional simulation of Mellanox PCI devices

  • It simulates
    • Mellanox NICs
    • Switch: Spectrum-1, Spectrum-2, Spectrum-3
  • It simulates both FW and HW
  • All flows are supported (controll + data path)

Mellanox only provides the simulator to it's customers.
Without the simulator none of this scripts are relevant.

Type of change

  • [] Bug fix
  • Testbed and Framework(new/improvement)
  • [] Test case(new/improvement)

Approach

How did you do it?

Add start/stop playbooks for new DUT type=simx.
The playbook starts the Simulator inside a docker container(for ease of deployment) and then wm-topology module can connect it to the topology.

How did you verify/test it?

$ ./testbed-cli.sh -m veos.vtb start-vms server_1 password.txt
$ ./testbed-cli.sh -t vtestbed.csv -m veos.vtb add-topo vms-kvm-t0 password.txt
  • run BGP test

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
@mykolaf mykolaf changed the title Add Mellanox SimX virtual testbed infra [simx vt] Add Mellanox SimX virtual testbed infra Oct 15, 2019
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this path is not public and you cannot use it.
You probably need to provide a generic instructions once a user get it from Mellanox under NDA.
Please change

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SImX is a typo?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest using SONiC all over the documentation

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have mellanox as prefix to the file name. this is not generic but only relevant and available for mellanox switches.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is 33 stands for? can you provide some kind of description?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is spc stands for any spectrum-x based?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now will use sonic.img for any spectrum-x based system.

ansible/veos.vtb Outdated
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about spectrum-2 based systems?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added entry for MSN3700

Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
Mykola Faryma added 3 commits November 15, 2019 15:34
Change-Id: I30afb7897e1f2eb9b1ff8427d9962b86adab5749
Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
Change-Id: Ida547dd54bf990fa7b447ee1cd86f6ae3a755175
Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
Change-Id: Ie1fde9f813ee4a1d074a0db07354b1459d16f3ee
Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
@liat-grozovik liat-grozovik merged commit 437eb78 into sonic-net:master Nov 17, 2019
@mykolaf mykolaf deleted the vt_infra branch February 18, 2020 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants