Skip to content

Add log_flood test#1067

Open
joej164 wants to merge 6 commits intosonic-net:masterfrom
IGNW:add-log_flood-to-test
Open

Add log_flood test#1067
joej164 wants to merge 6 commits intosonic-net:masterfrom
IGNW:add-log_flood-to-test

Conversation

@joej164
Copy link
Copy Markdown
Contributor

@joej164 joej164 commented Aug 13, 2019

log_flood_t1_eight_output.log
log_flood_t0_eight_output.log

Add log_flood test to the repo

Summary:
No Fixes

Type of change

  • [] Bug fix
  • [] Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

How did you do it?

Created a new test called log_flood. I check the CPU and memory of the DUT. I copy a script to the DUT and execute it. The script creates the specified number of syslog messaages using the logger command. Then wait 10 seconds and verify the CPU and Memory usage is approximately close to what it was prior to starting the test.

How did you verify/test it?

Using a SeastoneDX010 switch running Sonic software: SONiC.HEAD.15-23fb00c

Any platform specific information?

None

Supported testbed topology if it's a new test case?

Tested on t1-8 and t0-8 that was provided by LinkedIn but should work on all t0 and t1 topologies.
Both the t0-8 and the t1-8 tests passed

Documentation

Added doc update to the tests page for this new test

Test Output

Below is the test command used and the results of the test for the t0-8 and the t1-8 tests

ansible-playbook -i lab test_sonic.yml -e testbed_name=t0-eight -e testcase_name=log_flood

lab-ignw-seastone-dut-li1  : ok=56   changed=12   unreachable=0    failed=0   

Monday 12 August 2019  21:22:49 +0000 (0:00:00.085)       0:01:33.361 ********* 
=============================================================================== 
TASK: test : Send a script to the remote device ------------------------ 43.84s
TASK: test : wait 10 seconds for the cpu to calm down ------------------ 10.15s
TASK: test : pull CPU utilization via shell ----------------------------- 5.57s
TASK: test : pull CPU utilization via shell ----------------------------- 5.57s
TASK: test : Verify port channel interfaces are up correctly ------------ 2.10s
TASK: test : validate all interfaces are up after test ------------------ 1.75s
TASK: test : gather system version information -------------------------- 1.49s
TASK: test : Verify port channel interfaces are up correctly ------------ 1.20s
TASK: test : get used memory info before -------------------------------- 1.04s
TASK: test : get used memory info --------------------------------------- 1.03s
TASK: setup ------------------------------------------------------------- 1.02s
TASK: test : Get interface facts ---------------------------------------- 0.96s
TASK: test : validate all interfaces are up ----------------------------- 0.91s
TASK: test : Get interface facts ---------------------------------------- 0.87s
TASK: test : do basic sanity check after each test ---------------------- 0.84s
TASK: test : Get process information in syncd docker -------------------- 0.78s
TASK: test : Get process information in syncd docker -------------------- 0.70s
TASK: test : Verify VLAN interfaces are up correctly -------------------- 0.57s
TASK: test : Gather minigraph facts about the device -------------------- 0.56s
TASK: test : Gather minigraph facts about the device -------------------- 0.54s

ansible-playbook -i lab test_sonic.yml -e testbed_name=t1-eight -e testcase_name=log_flood

"PLAY RECAP *********************************************************************
lab-ignw-seastone-dut-li1  : ok=52   changed=12   unreachable=0    failed=0   

Monday 12 August 2019  19:06:11 +0000 (0:00:00.076)       0:01:29.049 ********* 
=============================================================================== 
TASK: test : Send a script to the remote device ------------------------ 43.81s
TASK: test : wait 10 seconds for the cpu to calm down ------------------ 10.13s
TASK: test : pull CPU utilization via shell ----------------------------- 5.56s
TASK: test : pull CPU utilization via shell ----------------------------- 5.55s
TASK: test : validate all interfaces are up after test ------------------ 1.73s
TASK: test : gather system version information -------------------------- 1.52s
TASK: setup ------------------------------------------------------------- 1.12s
TASK: test : get used memory info before -------------------------------- 1.07s
TASK: test : get used memory info --------------------------------------- 1.04s
TASK: test : validate all interfaces are up ----------------------------- 0.90s
TASK: test : do basic sanity check after each test ---------------------- 0.81s
TASK: test : Get interface facts ---------------------------------------- 0.79s
TASK: test : Get interface facts ---------------------------------------- 0.78s
TASK: test : Get process information in syncd docker -------------------- 0.76s
TASK: test : Get process information in syncd docker -------------------- 0.68s
TASK: test : Gather minigraph facts about the device -------------------- 0.55s
TASK: test : Gather minigraph facts about the device -------------------- 0.54s
TASK: test : Gathering minigraph facts about the device ----------------- 0.52s
TASK: test : do basic sanity check before each test --------------------- 0.47s
TASK: test : Gathering testbed information ------------------------------ 0.44s"

Signed-off-by: Joseph Jacobs joej@ignw.io (my work email address)

Joe Lazaro and others added 4 commits July 25, 2019 15:52
@msftclas
Copy link
Copy Markdown

msftclas commented Aug 13, 2019

CLA assistant check
All CLA requirements met.

vasant17
vasant17 previously approved these changes Aug 21, 2019

##### Log flood test
```
ansible-playbook test_sonic.yml -i {INVENTORY} -e testcase_name=log_flood -e testbed_name={TESTBED_NAME}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor update.
kindly add the "--limit" as an option providing flexibility to users to select the DUT they want to use to run tests.

ansible-playbook test_sonic.yml -i {INVENTORY} --limit {DUT_NAME} -e testcase_name=log_flood -e testbed_name={TESTBED_NAME} 
ansible-playbook test_sonic.yml -i {INVENTORY} --limit {DUT_NAME} -e testcase_name=log_flood -e testbed_name={TESTBED_NAME} -e qty_flood_messages=100

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made the requested changes

Copy link
Copy Markdown

@samaity samaity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@joej164 joej164 requested a review from a team as a code owner March 2, 2022 17:37
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
Fix error when running 'show lldp table' or 'show lldp neighbor'
through SSH command. (sonic-net#1067)
[201911]: Multi asic show interface support (sonic-net#1070)
[counterpoll] Add new FC group for port buffer drop counters
(sonic-net#1024)
[201911] show interface portchannel support for Multi ASIC
(sonic-net#1071)
Fix a typo in mellanox_buffer_migrator (sonic-net#1090)
Fix pfcwd stats crash with invalid queue name (sonic-net#1077)
[PFCWD] Fix issue with "pfcwd show stats" command during SONiC init
(sonic-net#1018)
enable watchdog before running platform specific reboot plugin
(sonic-net#1037)
Add namespace of the process in the coredump filename. (sonic-net#1091)
Pterosaur pushed a commit to Pterosaur/sonic-mgmt that referenced this pull request Mar 25, 2026
…ngleasic call

PR sonic-net#1067 cherry-picked the otel feature enablement from upstream PR sonic-net#22341,
but the upstream overwrite_feature_golden_config_db_singleasic() accepts
optional auto_restart and state parameters, while the 202412 branch version
only accepts (config, feature_key) and hardcodes both as 'enabled'.

This causes a TypeError at runtime:
  TypeError: overwrite_feature_golden_config_db_singleasic() takes 3
  positional arguments but 5 were given

Fix by removing the extra arguments since the 202412 branch already
hardcodes the desired 'enabled' values.

Signed-off-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Dashuai Zhang <dashuaizhang@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants