[fast/warm reboot] check the existence of correct file as stated#1018
Merged
yxieca merged 1 commit intosonic-net:masterfrom Jul 18, 2019
Merged
[fast/warm reboot] check the existence of correct file as stated#1018yxieca merged 1 commit intosonic-net:masterfrom
yxieca merged 1 commit intosonic-net:masterfrom
Conversation
The check is to gate removing a line in known_hosts file, so the check needs to be checking /root/.ssh/known_hosts. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
neethajohn
approved these changes
Jul 18, 2019
pavel-shirshov
approved these changes
Jul 18, 2019
yxieca
added a commit
that referenced
this pull request
Jul 19, 2019
The check is to gate removing a line in known_hosts file, so the check needs to be checking /root/.ssh/known_hosts. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
fraserg-arista
pushed a commit
to fraserg-arista/sonic-mgmt
that referenced
this pull request
Feb 24, 2026
…ew test on th5 (sonic-net#1018) <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: Fixes # (issue) ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [x] 202412 - [ ] 202505 - [x] 202511 ### Approach #### What is the motivation for this PR? In the last portion of the trimming counters test, all buffer profiles have trimming turned off. The test expects the trimming counters to stay the same after this happens. This fails on th5 because the Broadcom SAI clears counters when the trimming feature has been turned off. Microsoft has requested that Broadcom change the SAI implementation, but until that happens we need to ensure this issue doesn't affect the pass rate. #### How did you do it? Split the problematic portion of the test into it's own testcase. We will be skipping this new testcase on th5 until the SAI implementation is changed to support the expected behavior. #### How did you verify/test it? Tested internally, verifying the new testcase was skipped and the existing testcase was not failing with the previously described issue. #### Any platform specific information? We are only skipping for th5, other vendors may need to add to the skip condition if they have the same issue. #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Fix error when running 'show lldp table' or 'show lldp neighbor' through SSH command. (sonic-net#1067) [201911]: Multi asic show interface support (sonic-net#1070) [counterpoll] Add new FC group for port buffer drop counters (sonic-net#1024) [201911] show interface portchannel support for Multi ASIC (sonic-net#1071) Fix a typo in mellanox_buffer_migrator (sonic-net#1090) Fix pfcwd stats crash with invalid queue name (sonic-net#1077) [PFCWD] Fix issue with "pfcwd show stats" command during SONiC init (sonic-net#1018) enable watchdog before running platform specific reboot plugin (sonic-net#1037) Add namespace of the process in the coredump filename. (sonic-net#1091)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes # (issue)
Type of change
Approach
How did you do it?
The check is to gate removing a line in known_hosts file, so the check
needs to be checking /root/.ssh/known_hosts.
Signed-off-by: Ying Xie ying.xie@microsoft.com
How did you verify/test it?
Noticed some nightly tests failed because not able to reboot the DUT because the known_hosts has conflicting entry.
Executed some test locally.