[device/celestica]: Add thermalctld support on Haliburton platform APIs by mudsut4ke · Pull Request #6493 · sonic-net/sonic-buildimage

mudsut4ke · 2021-01-19T09:04:30Z

- Why I did it

The thermalctld daemon on the Pmon docker requires support from the thermal manager API.

- How I did it

Removed the old function for detecting a faulty fan.
Removed the old function for detecting excess temperature.
Implement thermal_manager APIs based on ThermalManagerBase
Implement thermal_conditions APIs based on ThermalPolicyConditionBase
Implement thermal_actions APIs based on ThermalPolicyActionBase
Implement thermal_info APIs based on ThermalPolicyInfoBase
Add thermal_policy.json

- How to verify it

Check the fan speed during temperature changes.
Examine events that will occur after the temperature has exceeded the threshold.
Check for events that will occur after the fan is removed or the fan is not working properly.

- Which release branch to backport (provide reason below if selected)

201811
201911
202006
202012

lgtm-com · 2021-01-19T09:24:29Z

This pull request introduces 9 alerts and fixes 7 when merging 2d01309d5db4870c937e55cd3d691911abec605a into afee1a8 - view on LGTM.com

new alerts:

6 for Unused import
3 for 'import *' may pollute namespace

fixed alerts:

5 for Wrong number of arguments in a class instantiation
1 for Except block handles 'BaseException'
1 for Unused import

lgtm-com · 2021-01-21T13:52:32Z

This pull request introduces 10 alerts and fixes 7 when merging bb5edc6 into df29773 - view on LGTM.com

new alerts:

6 for Unused import
3 for 'import *' may pollute namespace
1 for Unreachable code

fixed alerts:

5 for Wrong number of arguments in a class instantiation
1 for Except block handles 'BaseException'
1 for Unused import

lgtm-com · 2021-01-21T14:14:30Z

This pull request introduces 4 alerts and fixes 32 when merging c2a9893 into df29773 - view on LGTM.com

new alerts:

3 for 'import *' may pollute namespace
1 for Unreachable code

fixed alerts:

14 for Unused import
9 for Except block handles 'BaseException'
5 for Wrong number of arguments in a class instantiation
2 for Unused local variable
1 for Module imports itself
1 for 'import *' may pollute namespace

lgtm-com · 2021-01-22T11:48:16Z

This pull request introduces 3 alerts and fixes 32 when merging 9eb5384 into 8729fdc - view on LGTM.com

new alerts:

3 for 'import *' may pollute namespace

fixed alerts:

14 for Unused import
9 for Except block handles 'BaseException'
5 for Wrong number of arguments in a class instantiation
2 for Unused local variable
1 for Module imports itself
1 for 'import *' may pollute namespace

lgtm-com · 2021-01-29T07:38:31Z

This pull request introduces 3 alerts and fixes 32 when merging 0635109 into ff8cc49 - view on LGTM.com

new alerts:

3 for 'import *' may pollute namespace

fixed alerts:

14 for Unused import
9 for Except block handles 'BaseException'
5 for Wrong number of arguments in a class instantiation
2 for Unused local variable
1 for Module imports itself
1 for 'import *' may pollute namespace

lgtm-com · 2021-02-09T08:28:04Z

This pull request introduces 3 alerts and fixes 32 when merging fd81c07 into 3015de1 - view on LGTM.com

new alerts:

3 for 'import *' may pollute namespace

fixed alerts:

14 for Unused import
9 for Except block handles 'BaseException'
5 for Wrong number of arguments in a class instantiation
2 for Unused local variable
1 for Module imports itself
1 for 'import *' may pollute namespace

lgtm-com · 2021-02-16T04:56:34Z

This pull request introduces 3 alerts and fixes 32 when merging 8411d43 into f6bee73 - view on LGTM.com

new alerts:

3 for 'import *' may pollute namespace

fixed alerts:

14 for Unused import
9 for Except block handles 'BaseException'
5 for Wrong number of arguments in a class instantiation
2 for Unused local variable
1 for Module imports itself
1 for 'import *' may pollute namespace

jleveque · 2021-02-16T20:22:00Z

platform/broadcom/sonic-platform-modules-cel/debian/platform-modules-haliburton.init

+        # echo dps200 0x5a > /sys/bus/i2c/devices/i2c-12/new_device
+        # echo dps200 0x5b > /sys/bus/i2c/devices/i2c-13/new_device


Remove commented code or add a TODO comment if you plan to uncomment later

updated: 0664a4f

lgtm-com · 2021-03-12T04:55:26Z

This pull request introduces 3 alerts and fixes 26 when merging c1f06f6 into 721948f - view on LGTM.com

new alerts:

3 for 'import *' may pollute namespace

fixed alerts:

13 for Unused import
9 for Except block handles 'BaseException'
2 for Unused local variable
1 for Module imports itself
1 for 'import *' may pollute namespace

lgtm-com · 2021-03-18T09:52:47Z

This pull request introduces 3 alerts and fixes 26 when merging 1668157 into 9d9503e - view on LGTM.com

new alerts:

3 for 'import *' may pollute namespace

fixed alerts:

13 for Unused import
9 for Except block handles 'BaseException'
2 for Unused local variable
1 for Module imports itself
1 for 'import *' may pollute namespace

azure-pipelines · 2021-03-29T10:33:10Z

Commenter does not have sufficient privileges for PR 6493 in repo Azure/sonic-buildimage

mudsut4ke · 2021-03-29T10:35:52Z

@jleveque , Please help to re-review this PR

jleveque · 2021-03-29T17:50:42Z

/azp run

azure-pipelines · 2021-03-29T17:50:57Z

Azure Pipelines successfully started running 1 pipeline(s).

mudsut4ke · 2021-04-30T05:28:17Z

@jleveque , Can you merge this PR ?

jleveque · 2021-05-03T16:13:07Z

@mudsut4ke: Should this PR also be cherry-picked to the 202012 branch?

…Is (sonic-net#6493) - Removed the old function for detecting a faulty fan. - Removed the old function for detecting excess temperature. - Implement thermal_manager APIs based on ThermalManagerBase - Implement thermal_conditions APIs based on ThermalPolicyConditionBase - Implement thermal_actions APIs based on ThermalPolicyActionBase - Implement thermal_info APIs based on ThermalPolicyInfoBase - Add thermal_policy.json

mudsut4ke · 2021-07-13T07:20:21Z

@mudsut4ke: Should this PR also be cherry-picked to the 202012 branch?

@jleveque , Yes, Please help cherry-pick to the 202012 branch

…Is (sonic-net#6493) - Removed the old function for detecting a faulty fan. - Removed the old function for detecting excess temperature. - Implement thermal_manager APIs based on ThermalManagerBase - Implement thermal_conditions APIs based on ThermalPolicyConditionBase - Implement thermal_actions APIs based on ThermalPolicyActionBase - Implement thermal_info APIs based on ThermalPolicyInfoBase - Add thermal_policy.json

…Is (#6493) - Removed the old function for detecting a faulty fan. - Removed the old function for detecting excess temperature. - Implement thermal_manager APIs based on ThermalManagerBase - Implement thermal_conditions APIs based on ThermalPolicyConditionBase - Implement thermal_actions APIs based on ThermalPolicyActionBase - Implement thermal_info APIs based on ThermalPolicyInfoBase - Add thermal_policy.json

…Is (#6493) (#8217) - Why I did it The thermalctld daemon on the Pmon docker requires support from the thermal manager API - How I did it Cherry picked from : cfda77b Removed the old function for detecting a faulty fan. Removed the old function for detecting excess temperature. Implement thermal_manager APIs based on ThermalManagerBase Implement thermal_conditions APIs based on ThermalPolicyConditionBase Implement thermal_actions APIs based on ThermalPolicyActionBase Implement thermal_info APIs based on ThermalPolicyInfoBase Add thermal_policy.json - How to verify it Check the fan speed during temperature changes. Examine events that will occur after the temperature has exceeded the threshold. Check for events that will occur after the fan is removed or the fan is not working properly. - Which release branch to backport (provide reason below if selected) 202012

…Is (sonic-net#6493) - Removed the old function for detecting a faulty fan. - Removed the old function for detecting excess temperature. - Implement thermal_manager APIs based on ThermalManagerBase - Implement thermal_conditions APIs based on ThermalPolicyConditionBase - Implement thermal_actions APIs based on ThermalPolicyActionBase - Implement thermal_info APIs based on ThermalPolicyInfoBase - Add thermal_policy.json

[device/celestica-e1031]: add thermalctld api support

bb5edc6

mudsut4ke force-pushed the master-e1031-add-thermalctld-support branch from 2d01309 to bb5edc6 Compare January 21, 2021 13:33

[device/celestica-e1031]: clean api code follow lgtm

c2a9893

[device/celestica-e1031]: clean code

9eb5384

[device/celestica-e1031]: fix outdate pwmconfig error

0635109

Wirut Getbamrung added 2 commits February 1, 2021 14:50

[platform/cel]: add sonic_platform in python3

d86cd6d

[device/celestica-e1031]: add thermal_overload_control script

fd81c07

mudsut4ke marked this pull request as ready for review February 16, 2021 04:37

mudsut4ke requested review from jleveque and lguohan as code owners February 16, 2021 04:37

Merge branch 'master' into master-e1031-add-thermalctld-support

8411d43

jleveque suggested changes Feb 16, 2021

View reviewed changes

Wirut Getbamrung added 3 commits March 11, 2021 17:23

add todo comment

0664a4f

Merge branch 'master' into master-e1031-add-thermalctld-support

2458e1e

remove vscode config

c1f06f6

mudsut4ke requested a review from jleveque March 12, 2021 04:36

Merge branch 'master' into master-e1031-add-thermalctld-support

1668157

jleveque added Enhancement ➕ Platform: Celestica Request for 201911 Branch Request for 202006 Branch labels May 3, 2021

jleveque approved these changes May 3, 2021

View reviewed changes

jleveque merged commit cfda77b into sonic-net:master May 3, 2021

mudsut4ke mentioned this pull request Jul 13, 2021

[device/celestica]: Fix failed test cases of Haliburton platform API #7579

Merged

4 tasks

yxieca added Request for 202012 Branch Request for 202106 Branch and removed Request for 201911 Branch Request for 202006 Branch labels Jul 16, 2021

qiluo-msft added the Included in 202012 Branch label Jul 20, 2021

judyjoseph added the Included in 202106 Branch label Aug 7, 2021

		# echo dps200 0x5a > /sys/bus/i2c/devices/i2c-12/new_device
		# echo dps200 0x5b > /sys/bus/i2c/devices/i2c-13/new_device

Conversation

mudsut4ke commented Jan 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lgtm-com bot commented Jan 19, 2021

Uh oh!

lgtm-com bot commented Jan 21, 2021

Uh oh!

lgtm-com bot commented Jan 21, 2021

Uh oh!

lgtm-com bot commented Jan 22, 2021

Uh oh!

lgtm-com bot commented Jan 29, 2021

Uh oh!

lgtm-com bot commented Feb 9, 2021

Uh oh!

lgtm-com bot commented Feb 16, 2021

Uh oh!

jleveque Feb 16, 2021

Choose a reason for hiding this comment

Uh oh!

mudsut4ke Mar 12, 2021

Choose a reason for hiding this comment

Uh oh!

lgtm-com bot commented Mar 12, 2021

Uh oh!

lgtm-com bot commented Mar 18, 2021

Uh oh!

azure-pipelines bot commented Mar 29, 2021

Uh oh!

mudsut4ke commented Mar 29, 2021

Uh oh!

jleveque commented Mar 29, 2021

Uh oh!

azure-pipelines bot commented Mar 29, 2021

Uh oh!

mudsut4ke commented Apr 30, 2021

Uh oh!

jleveque commented May 3, 2021

Uh oh!

mudsut4ke commented Jul 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mudsut4ke commented Jan 19, 2021 •

edited

Loading

mudsut4ke commented Jul 13, 2021 •

edited

Loading