Skip to content

[202012][device/celestica]: Add thermalctld support on Haliburton platform APIs#8217

Merged
sujinmkang merged 1 commit intosonic-net:202012from
mudsut4ke:202012-e1031-add-thermalctld-support
Jul 23, 2021
Merged

[202012][device/celestica]: Add thermalctld support on Haliburton platform APIs#8217
sujinmkang merged 1 commit intosonic-net:202012from
mudsut4ke:202012-e1031-add-thermalctld-support

Conversation

@mudsut4ke
Copy link
Copy Markdown
Contributor

- Why I did it

  • The thermalctld daemon on the Pmon docker requires support from the thermal manager API

- How I did it

  • Removed the old function for detecting a faulty fan.
  • Removed the old function for detecting excess temperature.
  • Implement thermal_manager APIs based on ThermalManagerBase
  • Implement thermal_conditions APIs based on ThermalPolicyConditionBase
  • Implement thermal_actions APIs based on ThermalPolicyActionBase
  • Implement thermal_info APIs based on ThermalPolicyInfoBase
  • Add thermal_policy.json

- How to verify it

  • Check the fan speed during temperature changes.
  • Examine events that will occur after the temperature has exceeded the threshold.
  • Check for events that will occur after the fan is removed or the fan is not working properly.

- Which release branch to backport (provide reason below if selected)

  • 202012

…Is (sonic-net#6493)

- Removed the old function for detecting a faulty fan.
- Removed the old function for detecting excess temperature.
- Implement thermal_manager APIs based on ThermalManagerBase
- Implement thermal_conditions APIs based on ThermalPolicyConditionBase
- Implement thermal_actions APIs based on ThermalPolicyActionBase
- Implement thermal_info APIs based on ThermalPolicyInfoBase
- Add thermal_policy.json
@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Jul 19, 2021

This pull request introduces 3 alerts and fixes 26 when merging 80e611c into 01efb54 - view on LGTM.com

new alerts:

  • 3 for 'import *' may pollute namespace

fixed alerts:

  • 13 for Unused import
  • 9 for Except block handles 'BaseException'
  • 2 for Unused local variable
  • 1 for Module imports itself
  • 1 for 'import *' may pollute namespace

@yxieca
Copy link
Copy Markdown
Contributor

yxieca commented Jul 19, 2021

@mudsut4ke why did you removed platform.json? With this change, will platform test pass?

@mudsut4ke
Copy link
Copy Markdown
Contributor Author

@yxieca , For platform test , required PR #7579

@sujinmkang sujinmkang merged commit d191dcd into sonic-net:202012 Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants