[pcie-check] Make pcie-check.sh executable#5256
Merged
jleveque merged 1 commit intosonic-net:masterfrom Aug 29, 2020
jleveque:pcie_check_exe
Merged
[pcie-check] Make pcie-check.sh executable#5256jleveque merged 1 commit intosonic-net:masterfrom jleveque:pcie_check_exe
jleveque merged 1 commit intosonic-net:masterfrom
jleveque:pcie_check_exe
Conversation
tahmed-dev
approved these changes
Aug 27, 2020
judyjoseph
approved these changes
Aug 27, 2020
Contributor
Author
|
Retest vsimage please |
1 similar comment
Contributor
Author
|
Retest vsimage please |
yxieca
approved these changes
Aug 27, 2020
Contributor
Author
|
Retest vsimage please |
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
The pcie-check.sh script was added in sonic-net#4771, but was not given executable permission. Therefore, we would see messages like: ``` Aug 26 22:54:05.536248 sonic ERR systemd[664]: pcie-check.service: Failed to execute command: Permission denied Aug 26 22:54:05.536386 sonic ERR systemd[664]: pcie-check.service: Failed at step EXEC spawning /usr/bin/pcie-check.sh: Permission denied Aug 26 22:54:05.536600 sonic WARNING systemd[1]: pcie-check.service: Failed with result 'exit-code'. ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- Why I did it
The pcie-check.sh script was added in #4771, but was not given executable permission. Therefore, we would see messages like:
- How I did it
Add executable permission to pcie-check.sh.
- How to verify it
Ensure the above error messages are not seen in the syslog.
- Which release branch to backport (provide reason below if selected)