Add pcie-check service to check PCIe devices at boot#4771
Merged
sujinmkang merged 14 commits intosonic-net:masterfrom Jul 13, 2020
sujinmkang:pcie-mon
Merged
Add pcie-check service to check PCIe devices at boot#4771sujinmkang merged 14 commits intosonic-net:masterfrom sujinmkang:pcie-mon
sujinmkang merged 14 commits intosonic-net:masterfrom
sujinmkang:pcie-mon
Conversation
jleveque
suggested changes
Jun 19, 2020
jleveque
suggested changes
Jun 19, 2020
Collaborator
Author
|
retest this please |
2 similar comments
Collaborator
Author
|
retest this please |
Collaborator
Author
|
retest this please |
jleveque
reviewed
Jun 29, 2020
| [Service] | ||
| Type=simple | ||
| ExecStart=/usr/bin/pcie-check.sh | ||
|
|
|
|
||
| VERBOSE="no" | ||
| RESULTS="PCIe Device Checking All Test" | ||
| PCIE_CHK_CMD=`sudo pcieutil pcie-check |grep "$RESULTS"` |
Contributor
There was a problem hiding this comment.
Can this be done based on pcie_check_sysfs() like API rather than thru' CLI ?
This will also help in avoiding to check the CLI string output for EXPECTED.
paavaanan
reviewed
Jun 30, 2020
| exit | ||
| else | ||
| debug "PCIe check failed, try pci bus rescan" | ||
| echo 1 > /sys/bus/pci/rescan |
Contributor
There was a problem hiding this comment.
Here rescan is instantiated for all-devices. (sys/bus/pci/rescan). Rescan should be device specific.
Contributor
There was a problem hiding this comment.
Discussed offline. For now, we will rescan the entire bus. Rescanning individual devices will be a future enhancement.
| exit | ||
| fi | ||
|
|
||
| for i in $(seq 1 1 $MAX_RESCAN) |
Contributor
There was a problem hiding this comment.
MAX_RESCAN – This also should be device specific. Each PCIE peripheral do have a different tunable retry timeout. We can have an entry in *.yaml or STATE_DB and we import here
jleveque
suggested changes
Jul 3, 2020
jleveque
suggested changes
Jul 6, 2020
jleveque
suggested changes
Jul 6, 2020
jleveque
suggested changes
Jul 7, 2020
Collaborator
Author
|
retest mellanox please |
jleveque
approved these changes
Jul 13, 2020
3 tasks
jleveque
added a commit
that referenced
this pull request
Aug 29, 2020
The pcie-check.sh script was added in #4771, but was not given executable permission. Therefore, we would see messages like: ``` Aug 26 22:54:05.536248 sonic ERR systemd[664]: pcie-check.service: Failed to execute command: Permission denied Aug 26 22:54:05.536386 sonic ERR systemd[664]: pcie-check.service: Failed at step EXEC spawning /usr/bin/pcie-check.sh: Permission denied Aug 26 22:54:05.536600 sonic WARNING systemd[1]: pcie-check.service: Failed with result 'exit-code'. ```
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
The pcie-check.sh script was added in sonic-net#4771, but was not given executable permission. Therefore, we would see messages like: ``` Aug 26 22:54:05.536248 sonic ERR systemd[664]: pcie-check.service: Failed to execute command: Permission denied Aug 26 22:54:05.536386 sonic ERR systemd[664]: pcie-check.service: Failed at step EXEC spawning /usr/bin/pcie-check.sh: Permission denied Aug 26 22:54:05.536600 sonic WARNING systemd[1]: pcie-check.service: Failed with result 'exit-code'. ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- Why I did it
To monitor the PCIe device status during boot time and initiate the rescan if the status fails
- How I did it
Created a systemd service to monitor the PCIe device using pcieutil
- How to verify it
check the syslog to see the service execution spawn off periodically and perform expectedly.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)