Skip to content

Support new field "supporting_bulk_counter_groups" in DEVICE_METADATA|localhost for Mellanox-SN5600-V256#20548

Merged
qiluo-msft merged 5 commits intosonic-net:masterfrom
stephenxs:supporting_bulk_counter_groups
Nov 28, 2024
Merged

Support new field "supporting_bulk_counter_groups" in DEVICE_METADATA|localhost for Mellanox-SN5600-V256#20548
qiluo-msft merged 5 commits intosonic-net:masterfrom
stephenxs:supporting_bulk_counter_groups

Conversation

@stephenxs
Copy link
Copy Markdown
Collaborator

Why I did it

Support new field "supporting_bulk_counter_groups" in DEVICE_METADATA|localhost for Mellanox-SN5600-V256

Work item tracking
  • Microsoft ADO (number only):

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@stephenxs stephenxs changed the title Support new field "supporting_bulk_counter_groups" in DEVICE_METADATA|localhost for Mellanox-SN5600-V256 Support new field "supporting_bulk_counter_groups" in DEVICE_METADATA|localhost for Mellanox-SN5600-V256 and Mellanox-SN5600-C256x1 Oct 23, 2024
@bingwang-ms
Copy link
Copy Markdown
Contributor

@r12f Can you help review this PR?

Copy link
Copy Markdown
Contributor

@r12f r12f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks straight-forward good to me. Since it changes config and YANG model, I am going to request @qiluo-msft to look at it as well.

Copy link
Copy Markdown
Contributor

@xincunli-sonic xincunli-sonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

qiluo-msft
qiluo-msft previously approved these changes Nov 13, 2024
@qiluo-msft
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@stephenxs
Copy link
Copy Markdown
Collaborator Author

/azpw run

@mssonicbld
Copy link
Copy Markdown
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
@stephenxs stephenxs force-pushed the supporting_bulk_counter_groups branch from c962c80 to c5315a5 Compare November 15, 2024 13:03
@stephenxs stephenxs changed the title Support new field "supporting_bulk_counter_groups" in DEVICE_METADATA|localhost for Mellanox-SN5600-V256 and Mellanox-SN5600-C256x1 Support new field "supporting_bulk_counter_groups" in DEVICE_METADATA|localhost for Mellanox-SN5600-V256 Nov 15, 2024
@stephenxs
Copy link
Copy Markdown
Collaborator Author

/ms_conflict

3 similar comments
@stephenxs
Copy link
Copy Markdown
Collaborator Author

/ms_conflict

@bingwang-ms
Copy link
Copy Markdown
Contributor

/ms_conflict

@stephenxs
Copy link
Copy Markdown
Collaborator Author

/ms_conflict

@liat-grozovik
Copy link
Copy Markdown
Collaborator

@bingwang-ms who can assist with ms_conflict and merge this one?

@bingwang-ms
Copy link
Copy Markdown
Contributor

/azpw ms_conflict

@stephenxs stephenxs requested a review from qiluo-msft November 21, 2024 00:43
@stephenxs
Copy link
Copy Markdown
Collaborator Author

@qiluo-msft would you please help to review and merge it? thanks

@qiluo-msft qiluo-msft merged commit 1307952 into sonic-net:master Nov 28, 2024
@stephenxs stephenxs deleted the supporting_bulk_counter_groups branch November 28, 2024 02:20
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Dec 2, 2024
…|localhost for Mellanox-SN5600-V256 (sonic-net#20548)

Why I did it
Support new field "supporting_bulk_counter_groups" in DEVICE_METADATA|localhost for Mellanox-SN5600-V256
@mssonicbld
Copy link
Copy Markdown
Collaborator

Cherry-pick PR to 202405: #20993

mssonicbld pushed a commit that referenced this pull request Dec 4, 2024
…|localhost for Mellanox-SN5600-V256 (#20548)

Why I did it
Support new field "supporting_bulk_counter_groups" in DEVICE_METADATA|localhost for Mellanox-SN5600-V256
VladimirKuk pushed a commit to Marvell-switching/sonic-buildimage that referenced this pull request Jan 21, 2025
…|localhost for Mellanox-SN5600-V256 (sonic-net#20548)

Why I did it
Support new field "supporting_bulk_counter_groups" in DEVICE_METADATA|localhost for Mellanox-SN5600-V256
liat-grozovik pushed a commit that referenced this pull request Feb 5, 2025
…alization for SN5640 (port #20548 to ACS-SN5640) (#21474)

This is to port #20548 to ACS-SN5640

Signed-off-by: Stephen Sun <stephens@nvidia.com>
yuazhe pushed a commit to yuazhe/sonic-buildimage that referenced this pull request Feb 12, 2025
…during initialization for SN5640 (port sonic-net#20548 to ACS-SN5640)
saiarcot895 pushed a commit to saiarcot895/sonic-buildimage that referenced this pull request Feb 13, 2025
…alization for SN5640 (port sonic-net#20548 to ACS-SN5640) (sonic-net#592)

<!--
 Please make sure you've read and understood our contributing guidelines:
 https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md

 failure_prs.log Make sure all your commits include a signature generated with `git commit -s` **

 If this is a bug fix, make sure your description includes "fixes #xxxx", or
 "closes #xxxx" or "resolves #xxxx"

 Please provide the following information:
-->

#### Why I did it

This is to port sonic-net#20548 to ACS-SN5640

##### Work item tracking
- Microsoft ADO **(number only)**:

#### How I did it

#### How to verify it

<!--
If PR needs to be backported, then the PR must be tested against the base branch and the earliest backport release branch and provide tested image version on these two branches. For example, if the PR is requested for master, 202211 and 202012, then the requester needs to provide test results on master and 202012.
-->

#### Which release branch to backport (provide reason below if selected)

<!--
- Note we only backport fixes to a release branch, *not* features!
- Please also provide a reason for the backporting below.
- e.g.
- [x] 202006
-->

- [ ] 201811
- [ ] 201911
- [ ] 202006
- [ ] 202012
- [ ] 202106
- [ ] 202111
- [ ] 202205
- [ ] 202211
- [ ] 202305

#### Tested branch (Please provide the tested image version)

<!--
- Please provide tested image version
- e.g.
- [x] 20201231.100
-->

- [ ] <!-- image version 1 -->
- [ ] <!-- image version 2 -->

#### Description for the changelog
<!--
Write a short (one line) summary that describes the changes in this
pull request for inclusion in the changelog:
-->

<!--
 Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
-->

#### Link to config_db schema for YANG module changes
<!--
Provide a link to config_db schema for the table for which YANG model
is defined
Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md
-->

#### A picture of a cute animal (not mandatory but encouraged)
yuazhe pushed a commit to yuazhe/sonic-buildimage that referenced this pull request Feb 18, 2025
…during initialization for SN5640 (port sonic-net#20548 to ACS-SN5640) (%21474)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants