Skip to content

[Mellanox] Do not double check bulk counter capabilities during initialization for SN5640 (port #20548 to ACS-SN5640)#21474

Merged
liat-grozovik merged 2 commits intosonic-net:masterfrom
stephenxs:not-double-check-bulk-counter-on-5640
Feb 5, 2025
Merged

[Mellanox] Do not double check bulk counter capabilities during initialization for SN5640 (port #20548 to ACS-SN5640)#21474
liat-grozovik merged 2 commits intosonic-net:masterfrom
stephenxs:not-double-check-bulk-counter-on-5640

Conversation

@stephenxs
Copy link
Copy Markdown
Collaborator

@stephenxs stephenxs commented Jan 20, 2025

Why I did it

This is to port #20548 to ACS-SN5640

Work item tracking
  • Microsoft ADO (number only):

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@stephenxs
Do not double check bulk counter capabilities during initialization f…
8e1e0c4 
…or SN5640

Signed-off-by: Stephen Sun <stephens@nvidia.com>
@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Jan 20, 2025

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Jan 20, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@stephenxs stephenxs changed the title Do not double check bulk counter capabilities during initialization for SN5640 Do not double check bulk counter capabilities during initialization for SN5640 (port #20548 to ACS-SN5640) Jan 20, 2025
@stephenxs
Copy link
Copy Markdown
Collaborator Author

stephenxs commented Jan 20, 2025

Broadcom image compile failed due the the following issue which doesn't look like relevant to the PR. Will retry once more.

dpkg-buildpackage -rfakeroot -b -us -uc -j4
popd
mv flashrom_0.9.7_amd64.deb /sonic/target/debs/bookworm/
Cloning into 'flashrom-0.9.7'...
/sonic/src/flashrom/flashrom-0.9.7 /sonic/src/flashrom
fatal: 'tags/0.9.7' is not a commit and a branch 'flashrom-src' cannot be created from it
make[1]: *** [Makefile:9: /sonic/target/debs/bookworm/flashrom_0.9.7_amd64.deb] Error 128
make[1]: Leaving directory '/sonic/src/flashrom'
[  FAIL LOG END  ] [ target/debs/bookworm/flashrom_0.9.7_amd64.deb ]
make: *** [slave.mk:750: target/debs/bookworm/flashrom_0.9.7_amd64.deb] Error 1
make: *** Waiting for unfinished jobs....
[ finished ] [ target/debs/bookworm/libtac2_1.4.1-1_amd64.deb-install ] 
[ finished ] [ target/python-wheels/bookworm/redis_dump_load-1.1-py3-none-any.whl-install ] 
[ finished ] [ target/debs/bookworm/libnl-3-200_3.7.0-0.2+b1sonic1_amd64.deb-install ] 
make[1]: *** [Makefile.work:611: target/sonic-aboot-broadcom.swi] Error 2
make[1]: Leaving directory '/data/agent/1/s'
make: *** [Makefile:50: target/sonic-aboot-broadcom.swi] Error 2

@stephenxs
Support queue and port counter for bulk
7d9f150 
Signed-off-by: Stephen Sun <stephens@nvidia.com>
@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Jan 25, 2025

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Jan 25, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@bingwang-ms
Copy link
Copy Markdown
Contributor

bingwang-ms commented Jan 27, 2025

@r12f @Pterosaur Can you help review?

@liat-grozovik liat-grozovik changed the title Do not double check bulk counter capabilities during initialization for SN5640 (port #20548 to ACS-SN5640) [Mellanox] Do not double check bulk counter capabilities during initialization for SN5640 (port #20548 to ACS-SN5640) Feb 5, 2025
@liat-grozovik liat-grozovik merged commit ed5e748 into sonic-net:master Feb 5, 2025
@stephenxs stephenxs deleted the not-double-check-bulk-counter-on-5640 branch February 8, 2025 11:04
@mssonicbld mssonicbld mentioned this pull request Feb 8, 2025
Merged
11 tasks
@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Feb 8, 2025

Cherry-pick PR to msft-202412: Azure/sonic-buildimage-msft#592

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keboliu keboliu keboliu approved these changes

@liat-grozovik liat-grozovik liat-grozovik approved these changes

Assignees

@r12f r12f

@Pterosaur Pterosaur

Labels

Approved for msft-202412 Branch Included in msft-202412 Branch Request for msft-202412 Branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@stephenxs @mssonicbld @bingwang-ms @keboliu @liat-grozovik @r12f @Pterosaur