Testing sync_labels (#35172) by soehms · Pull Request #2 · soehms/sage

soehms · 2023-03-08T07:04:07Z

📚 Description

The purpose of this PR is just to test sagemath#35172

📝 Checklist

I have made sure that the title is self-explanatory and the description concisely explains the PR.
I have linked an issue or discussion.
I have created tests covering the changes.
I have updated the documentation accordingly.

⌛ Dependencies

gitpod-io · 2023-03-08T07:04:14Z

soehms · 2023-03-08T07:07:18Z

Starting tests for sync_labels

soehms · 2023-03-08T07:07:20Z

Test action opened

soehms · 2023-03-08T07:07:22Z

Test action reopened

soehms · 2023-03-08T07:07:25Z

Test action closed

soehms · 2023-03-08T07:07:27Z

Test action labeled

github-actions · 2023-03-08T07:07:41Z

Label s: positive review can not be added. Please use the corresponding functionality of GitHub

github-actions · 2023-03-08T07:07:43Z

Label s: needs work can not be added. Please use the corresponding functionality of GitHub

soehms · 2023-03-08T07:07:44Z

Test action unlabeled

github-actions · 2023-03-08T07:07:44Z

Label s: needs work can not be added. Please use the corresponding functionality of GitHub

soehms · 2023-03-08T07:07:47Z

Test action ready_for_review

github-actions · 2023-03-08T07:18:44Z

Label s: positive review can not be added. Please use the corresponding functionality of GitHub

github-actions · 2023-03-08T07:18:45Z

Label s: positive review can not be added. Please use the corresponding functionality of GitHub

soehms

Test review

github-actions · 2023-03-08T08:49:43Z

Documentation preview for this PR is ready! 🎉
Built with commit: 17bea0a

soehms · 2023-03-09T07:30:16Z

Almost all of the above comments and label changes have be created by the run_tests method of class GhLabelSynchronizer. Here are the log-messages of the run:

sage$ .github/sync_labels.py  https://github.com/soehms/sage/pull/2 sagetrac-github-bot
INFO:root:cmdline_args (2) ['https://github.com/soehms/sage/pull/2', 'sagetrac-github-bot']
INFO:root:url: https://github.com/soehms/sage/pull/2
INFO:root:actor: sagetrac-github-bot
INFO:root:Create label handler for pull request #2 and actor sagetrac-github-bot
INFO:root:Execute command: gh pr comment https://github.com/soehms/sage/pull/2 -b "Starting tests for sync_labels"
https://github.com/soehms/sage/pull/2#issuecomment-1459640905
INFO:root:Add comment to pull request #2: Starting tests for sync_labels
INFO:root:Execute command: gh pr comment https://github.com/soehms/sage/pull/2 -b "Test action opened"
https://github.com/soehms/sage/pull/2#issuecomment-1459640936
INFO:root:Add comment to pull request #2: Test action opened
INFO:root:Issue pull request #2 is draft False
INFO:root:List of labels for pull request #2: ['s: needs review']
INFO:root:Active partners of  State.needs_review: []
INFO:root:Execute command: gh pr comment https://github.com/soehms/sage/pull/2 -b "Test action reopened"
https://github.com/soehms/sage/pull/2#issuecomment-1459640984
INFO:root:Add comment to pull request #2: Test action reopened
INFO:root:Execute command: gh pr edit https://github.com/soehms/sage/pull/2 --remove-label "s: needs review"
https://github.com/soehms/sage/pull/2
INFO:root:Remove label from pull request #2: s: needs review
INFO:root:Execute command: gh pr comment https://github.com/soehms/sage/pull/2 -b "Test action closed"
https://github.com/soehms/sage/pull/2#issuecomment-1459641051
INFO:root:Add comment to pull request #2: Test action closed
INFO:root:Execute command: gh pr edit https://github.com/soehms/sage/pull/2 --remove-label "s: needs review"
https://github.com/soehms/sage/pull/2
INFO:root:Remove label from pull request #2: s: needs review
INFO:root:Execute command: gh pr comment https://github.com/soehms/sage/pull/2 -b "Test action labeled"
https://github.com/soehms/sage/pull/2#issuecomment-1459641093
INFO:root:Add comment to pull request #2: Test action labeled
INFO:root:Execute command: gh pr edit https://github.com/soehms/sage/pull/2 --add-label "s: positive review"
https://github.com/soehms/sage/pull/2
INFO:root:Add label to pull request #2: s: positive review
INFO:root:Execute command: gh pr edit https://github.com/soehms/sage/pull/2 --add-label "s: needs work"
https://github.com/soehms/sage/pull/2
INFO:root:Add label to pull request #2: s: needs work
INFO:root:Execute command: gh pr edit https://github.com/soehms/sage/pull/2 --add-label "s: needs info"
https://github.com/soehms/sage/pull/2
INFO:root:Add label to pull request #2: s: needs info
INFO:root:Execute command: gh pr edit https://github.com/soehms/sage/pull/2 --add-label "p: blocker /1"
https://github.com/soehms/sage/pull/2
INFO:root:Add label to pull request #2: p: blocker /1
INFO:root:Execute command: gh pr edit https://github.com/soehms/sage/pull/2 --add-label "p: critical /2"
https://github.com/soehms/sage/pull/2
INFO:root:Add label to pull request #2: p: critical /2
INFO:root:Execute command: gh pr edit https://github.com/soehms/sage/pull/2 --add-label "p: major /3"
https://github.com/soehms/sage/pull/2
INFO:root:Add label to pull request #2: p: major /3
INFO:root:Execute command: gh pr edit https://github.com/soehms/sage/pull/2 --add-label "p: minor /4"
https://github.com/soehms/sage/pull/2
INFO:root:Add label to pull request #2: p: minor /4
INFO:root:Execute command: gh pr edit https://github.com/soehms/sage/pull/2 --add-label "p: trivial /5"
https://github.com/soehms/sage/pull/2
INFO:root:Add label to pull request #2: p: trivial /5
INFO:root:Execute command: gh pr comment https://github.com/soehms/sage/pull/2 -b "Test action unlabeled"
https://github.com/soehms/sage/pull/2#issuecomment-1459641327
INFO:root:Add comment to pull request #2: Test action unlabeled
INFO:root:Execute command: gh pr edit https://github.com/soehms/sage/pull/2 --remove-label "s: needs review"
https://github.com/soehms/sage/pull/2
INFO:root:Remove label from pull request #2: s: needs review
INFO:root:Execute command: gh pr comment https://github.com/soehms/sage/pull/2 -b "Test action ready_for_review"
https://github.com/soehms/sage/pull/2#issuecomment-1459641369
INFO:root:Add comment to pull request #2: Test action ready_for_review
INFO:root:Review decision for pull request #2: COMMENTED
INFO:root:PR pull request #2 doesn't need work (by decision)
INFO:root:PR pull request #2 doesn't have positve review (by decision)
INFO:root:PR pull request #2 needs review
INFO:root:Execute command: gh pr comment https://github.com/soehms/sage/pull/2 -b "Test action synchronize"
https://github.com/soehms/sage/pull/2#issuecomment-1459641410
INFO:root:Add comment to pull request #2: Test action synchronize
INFO:root:PR pull request #2 doesn't need work (by decision)
INFO:root:PR pull request #2 doesn't have positve review (by decision)
INFO:root:PR pull request #2 needs review
INFO:root:Execute command: gh pr comment https://github.com/soehms/sage/pull/2 -b "Test action review_requested"
https://github.com/soehms/sage/pull/2#issuecomment-1459641437
INFO:root:Add comment to pull request #2: Test action review_requested
INFO:root:Execute command: gh pr comment https://github.com/soehms/sage/pull/2 -b "Test action converted_to_draft"
https://github.com/soehms/sage/pull/2#issuecomment-1459641454
INFO:root:Add comment to pull request #2: Test action converted_to_draft
INFO:root:Execute command: gh pr edit https://github.com/soehms/sage/pull/2 --remove-label "s: needs review"
https://github.com/soehms/sage/pull/2
INFO:root:Remove label from pull request #2: s: needs review
INFO:root:Execute command: gh pr comment https://github.com/soehms/sage/pull/2 -b "Test action submitted"
https://github.com/soehms/sage/pull/2#issuecomment-1459641501
INFO:root:Add comment to pull request #2: Test action submitted
INFO:root:Execute command: gh pr review https://github.com/soehms/sage/pull/2 -b "sagetrac-github-bot approved this PR" "--approve"
failed to create review: Message: Can not approve your own pull request, Locations: [{Line:1 Column:66}]
WARNING:root:Execution of gh pr review https://github.com/soehms/sage/pull/2 -b "sagetrac-github-bot approved this PR" "--approve" failed with exit code: 256
INFO:root:PR pull request #2 approved by sagetrac-github-bot
INFO:root:PR pull request #2 doesn't have positve review (by decision)
INFO:root:Execute command: gh pr review https://github.com/soehms/sage/pull/2 -b "sagetrac-github-bot requested changes for this PR" "--request-changes"
failed to create review: Message: Can not request changes on your own pull request, Locations: [{Line:1 Column:66}]
WARNING:root:Execution of gh pr review https://github.com/soehms/sage/pull/2 -b "sagetrac-github-bot requested changes for this PR" "--request-changes" failed with exit code: 256
INFO:root:Changes requested for PR pull request #2 by sagetrac-github-bot
INFO:root:PR pull request #2 doesn't need work (by decision)

* Improve camera positioning for threejs * Changes to sagedoc, stopgap and superseded; one mass replacement * Another mass replacement * Another mass replacement * Another replacement * Another replacement * Remove comment numbers * Fix a couple of strays * trac ticket -> github issue * Change checksums back, fix meta-ticket * Another mass replacement * Another mass replacement * Another mass replacement * Manual fixes * Small replacement * Small replacement * Fix typo * Add github role to tox * add explicit formulas to documentation of WeierstrassIsomorphism * lift documentation from .__init__() to class and tweak * add doctest for sagemath#20847 * add .torsion_basis() method to EllipticCurve_finite_field * Revert "Remove comment numbers" This reverts commit 27cdf3e. * Revert changes to git_trac.rst * Switch :github: to :issue: * Switch from sage-prod to sage in attachment links * Change trac_number to issue_number * cross linked matrix method * Add construction of strongly regular digraph * A few manual fixes * Another automatic change * Undo a bunch of changes in the doc directory * Another fix * Try to fix sphinx problem * Move comment tag inside * allowing iterables as input * Fix code style * generalized fix * converting iterables * added is_supergreedy() function * implemented diff algo, for borderline cases * correcting function for disjoint set of points * correcting function * documentation changes * minor chagnges * fixing_failing_tests * minor documentation correction * Update linear_extensions.py * corrected TeX maths in docstrings * further fixes to supergreedy docstring * Added Reference * adding reference * minor updates * correcting documentation errors * correct a wrong change to :trac: * remove spurrious blank line * another spurrious line removed * compute matrix kernels modulo composites * fix doctests * docstring style tweak * adding doctests * correct the import location (duh...) * adding colored permutation doctests * doctests fixes * replaced "Combining Caron"+c with one unicode character * Updated SageMath version to 10.0.beta1 --------- Co-authored-by: Kwankyu Lee <ekwankyu@gmail.com> Co-authored-by: David Roe <roed.math@gmail.com> Co-authored-by: Lorenz Panny <lorenz@yx7.cc> Co-authored-by: Marc Mezzarobba <marc@mezzarobba.net> Co-authored-by: Tobias Diez <code@tobiasdiez.com> Co-authored-by: Sandstorm831 <gargrohan138@gmail.com> Co-authored-by: Rohan Garg <76916164+Sandstorm831@users.noreply.github.com> Co-authored-by: Dima Pasechnik <dima@pasechnik.info> Co-authored-by: Release Manager <release@sagemath.org>

sagemathgh-35114: libgap: Remove some GC hazards ### 📚 Description Trac branch `u/gh-collares/gap-gc` from sagemath#34701, now migrated to GitHub. Currently based atop sagemath#35093; will rebase once that is merged. The rest of the description below is copied from sagemath#34701: A refactor in sagemath#27946 introduced "unprotected" (not surrounded by `GAP_Enter`/`GAP_Leave`) `GAP_ValueGlobalVariable` calls. I believe this might be a GC hazard, because after updating to GAP 4.12.1 I started seeing aarch64 crashes on NixOS infrastructure such as: ``` #0 0x0000fffff79740e8 in wait4 () #1 0x0000fffff5dc6b78 in print_enhanced_backtrace () #2 0x0000fffff5dc8190 in sigdie () #3 0x0000fffff5dcb1c0 in cysigs_signal_handler () #4 0x0000fffff7ffb7cc in __kernel_rt_sigreturn () #5 0x0000ffff99a0bf28 in ConvString () #6 0x0000000000000000 in ?? () #7 0x0000000000000000 in ?? () #8 0x0000000000000000 in ?? () #9 0x0000ffff99989930 in Pr () #10 0x0000ffff9998aa18 in CloseOutput () #11 0x0000ffff99884828 in capture_stdout () at /build/sage- src-9.7/pkgs/sagemath-standard/sage/libs/gap/element.pyx:154 ... ``` I also see cases where `capture_stdout` throws errors such as `sage.libs.gap.util.GAPError: Error, Length: <list> must be a list (not the integer 255)` and then crashes. Both types of errors are fixed by this ticket. Note that I am nesting `GAP_Enter`/`GAP_Leave` calls because I didn't remove the preexisting calls inside `capture_stdout`. That's because I feared removing the innermost calls might create a new footgun (and I believe nested `GAP_Enter`/`GAP_Leave` calls are explicitly supported), but removing them should cause no problem. Removing them might even be preferable for performance reasons, I don't know. Fixes sagemath#34701 ### 📝 Checklist    - [x] I have made sure that the title is self-explanatory and the description concisely explains the PR. - [x] I have linked an issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies   - sagemath#35093: GAP 4.12.2 upgrade, which touches the same function and should land first. URL: sagemath#35114 Reported by: Mauricio Collares Reviewer(s): Dima Pasechnik

Make sure sagemath#26968 is not unfixed after sagemath#35707.

Update reference [HKL2021]: Appeared in 2022

Libgd reduce deps

Remove excessive blank lines around INPUT, OUTPUT, EXAMPLES, and before docstring ending """. (#2)

* Add some `except`s For C-return-type functions that raise exceptions (and their heirs). * Use `except?` for `_rank`

bump up external meson's minimal version for scipy

documentation fixes

sync_labels refactoring and extension

17bea0a

github-actions bot added the s: needs review label Mar 8, 2023

soehms removed the s: needs review label Mar 8, 2023

soehms added s: positive review s: needs work s: needs info p: blocker /1 p: critical /2 p: major /3 labels Mar 8, 2023

soehms added p: minor /4 p: trivial /5 labels Mar 8, 2023

github-actions bot added the s: needs review label Mar 8, 2023

github-actions bot removed s: positive review s: needs work labels Mar 8, 2023

soehms removed the s: needs review label Mar 8, 2023

github-actions bot removed p: critical /2 s: needs info labels Mar 8, 2023

github-actions bot removed the p: major /3 label Mar 8, 2023

soehms marked this pull request as draft March 8, 2023 07:16

github-actions bot removed the s: needs review label Mar 8, 2023

soehms added the p: minor /4 label Mar 8, 2023

github-actions bot removed the p: critical /2 label Mar 8, 2023

soehms marked this pull request as ready for review March 8, 2023 07:17

github-actions bot added s: needs review labels Mar 8, 2023

soehms added the s: positive review label Mar 8, 2023

github-actions bot removed the s: positive review label Mar 8, 2023

soehms commented Mar 8, 2023

View reviewed changes

soehms merged commit 00de6bd into sync_labels Mar 8, 2023

soehms deleted the sync_labels_temp branch March 8, 2023 17:34

github-actions bot removed the s: needs review label Mar 8, 2023

soehms restored the sync_labels_temp branch March 8, 2023 20:16

soehms deleted the sync_labels_temp branch March 8, 2023 20:16

soehms mentioned this pull request Mar 9, 2023

New workflow for synchronization of labels sagemath/sage#35172

Merged

4 tasks

soehms pushed a commit that referenced this pull request Jul 3, 2023

Merge pull request #2 from tornaria/maxima-5.47.0

808ab47

Make sure sagemath#26968 is not unfixed after sagemath#35707.

soehms pushed a commit that referenced this pull request Jul 30, 2023

Merge pull request #2 from cheuberg/update-reference-hkl2021

90ca467

Update reference [HKL2021]: Appeared in 2022

soehms pushed a commit that referenced this pull request Sep 8, 2023

Merge pull request #2 from mkoeppe/libgd_reduce_deps

92baa65

Libgd reduce deps

soehms pushed a commit that referenced this pull request Aug 4, 2024

Docstring edits

d41de45

Remove excessive blank lines around INPUT, OUTPUT, EXAMPLES, and before docstring ending """. (#2)

soehms pushed a commit that referenced this pull request Sep 13, 2024

Remove whitespace #2

131837e

soehms pushed a commit that referenced this pull request Sep 13, 2024

Use except? for _rank (#2)

d943edc

* Add some `except`s For C-return-type functions that raise exceptions (and their heirs). * Use `except?` for `_rank`

soehms pushed a commit that referenced this pull request Mar 24, 2025

Merge pull request #2 from dimpase/p39676

6e06b66

bump up external meson's minimal version for scipy

soehms pushed a commit that referenced this pull request Sep 17, 2025

Merge pull request #2 from vneiger/doc_enhancements

f21b298

documentation fixes

Conversation

soehms commented Mar 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📚 Description

📝 Checklist

⌛ Dependencies

Uh oh!

gitpod-io bot commented Mar 8, 2023

Uh oh!

soehms commented Mar 8, 2023

Uh oh!

soehms commented Mar 8, 2023

Uh oh!

soehms commented Mar 8, 2023

Uh oh!

soehms commented Mar 8, 2023

Uh oh!

soehms commented Mar 8, 2023

Uh oh!

github-actions bot commented Mar 8, 2023

Uh oh!

github-actions bot commented Mar 8, 2023

Uh oh!

soehms commented Mar 8, 2023

Uh oh!

github-actions bot commented Mar 8, 2023

Uh oh!

soehms commented Mar 8, 2023

Uh oh!

github-actions bot commented Mar 8, 2023

Uh oh!

github-actions bot commented Mar 8, 2023

Uh oh!

soehms left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 8, 2023

Uh oh!

soehms commented Mar 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

soehms commented Mar 8, 2023 •

edited

Loading