Skip to content

Trigger label addition by review comments#6

Merged
soehms merged 3 commits intosync_labelsfrom
sync_labels_add_on_review_comment
Mar 20, 2023
Merged

Trigger label addition by review comments#6
soehms merged 3 commits intosync_labelsfrom
sync_labels_add_on_review_comment

Conversation

@soehms
Copy link
Copy Markdown
Owner

@soehms soehms commented Mar 20, 2023

📚 Description

This PR implements the suggestion in sagemath#35172 (comment)

Furthermore, it improves the workflows on label addition. The previous implementation assumes that the GitHub review state was reset after a push. Since this is not the case, some changes have been necessary.

📝 Checklist

  • I have made sure that the title is self-explanatory and the description concisely explains the PR.
  • I have linked an issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Mar 20, 2023

@soehms soehms marked this pull request as draft March 20, 2023 17:07
@soehms soehms marked this pull request as ready for review March 20, 2023 17:08
@soehms
Copy link
Copy Markdown
Owner Author

soehms commented Mar 20, 2023

Starting tests for sync_labels

@soehms
Copy link
Copy Markdown
Owner Author

soehms commented Mar 20, 2023

Test action opened

@soehms
Copy link
Copy Markdown
Owner Author

soehms commented Mar 20, 2023

Test action reopened

@soehms
Copy link
Copy Markdown
Owner Author

soehms commented Mar 20, 2023

Test action closed

@soehms
Copy link
Copy Markdown
Owner Author

soehms commented Mar 20, 2023

Test action labeled

@soehms
Copy link
Copy Markdown
Owner Author

soehms commented Mar 20, 2023

Label s: positive review can not be added. Please use the corresponding functionality of GitHub

@github-actions
Copy link
Copy Markdown

Label s: needs review can not be removed. Please add the state-label which should replace it

1 similar comment
@github-actions
Copy link
Copy Markdown

Label s: needs review can not be removed. Please add the state-label which should replace it

@github-actions
Copy link
Copy Markdown

Label s: positive review can not be added due to s: needs work!

@soehms
Copy link
Copy Markdown
Owner Author

soehms commented Mar 20, 2023

Label s: needs review can not be added due to s: needs work!

@github-actions
Copy link
Copy Markdown

Label s: positive review can not be removed. Please add the state-label which should replace it

1 similar comment
@github-actions
Copy link
Copy Markdown

Label s: positive review can not be removed. Please add the state-label which should replace it

@github-actions
Copy link
Copy Markdown

Label s: positive review can not be added due to s: needs work!

@soehms
Copy link
Copy Markdown
Owner Author

soehms commented Mar 20, 2023

Test action converted_to_draft

@soehms
Copy link
Copy Markdown
Owner Author

soehms commented Mar 20, 2023

Test action submitted

Copy link
Copy Markdown
Owner Author

@soehms soehms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s: positive review

Copy link
Copy Markdown
Owner Author

@soehms soehms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s: needs work

Copy link
Copy Markdown
Owner Author

@soehms soehms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s: needs review

@github-actions
Copy link
Copy Markdown

Label s: needs review can not be removed. Please add the state-label which should replace it

1 similar comment
@github-actions
Copy link
Copy Markdown

Label s: needs review can not be removed. Please add the state-label which should replace it

@soehms
Copy link
Copy Markdown
Owner Author

soehms commented Mar 20, 2023

Label s: needs review can not be added. Please use the corresponding functionality of GitHub

Copy link
Copy Markdown
Owner Author

@soehms soehms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s: needs info

@github-actions
Copy link
Copy Markdown

Label s: needs review can not be added due to s: needs info!

@github-actions
Copy link
Copy Markdown

Label s: needs review can not be removed. Please add the state-label which should replace it

1 similar comment
@github-actions
Copy link
Copy Markdown

Label s: needs review can not be removed. Please add the state-label which should replace it

@github-actions
Copy link
Copy Markdown

Label s: needs work can not be added. Please use the corresponding functionality of GitHub

1 similar comment
@github-actions
Copy link
Copy Markdown

Label s: needs work can not be added. Please use the corresponding functionality of GitHub

@soehms
Copy link
Copy Markdown
Owner Author

soehms commented Mar 20, 2023

Log-Messages of run_tests:

.github/sync_labels.py https://github.com/soehms/sage/pull/6 sagetrac-github-bot
INFO:root:cmdline_args (2) ['https://github.com/soehms/sage/pull/6', 'sagetrac-github-bot']
INFO:root:url: https://github.com/soehms/sage/pull/6
INFO:root:actor: sagetrac-github-bot
INFO:root:Create label handler for pull request #6 and actor sagetrac-github-bot
INFO:root:Execute command: gh pr comment https://github.com/soehms/sage/pull/6 -b "Starting tests for sync_labels"
https://github.com/soehms/sage/pull/6#issuecomment-1476721302
INFO:root:Add comment to pull request #6: Starting tests for sync_labels
INFO:root:Execute command: gh pr comment https://github.com/soehms/sage/pull/6 -b "Test action opened"
https://github.com/soehms/sage/pull/6#issuecomment-1476721330
INFO:root:Add comment to pull request #6: Test action opened
INFO:root:Issue pull request #6 is draft False
INFO:root:List of labels for pull request #6: ['s: needs review']
INFO:root:Active partners of  State.needs_review: []
INFO:root:Execute command: gh pr comment https://github.com/soehms/sage/pull/6 -b "Test action reopened"
https://github.com/soehms/sage/pull/6#issuecomment-1476721388
INFO:root:Add comment to pull request #6: Test action reopened
INFO:root:List of labels for pull request #6: ['s: needs review']
INFO:root:Execute command: gh pr edit https://github.com/soehms/sage/pull/6 --remove-label "s: needs review"
https://github.com/soehms/sage/pull/6
INFO:root:Remove label from pull request #6: s: needs review
INFO:root:Execute command: gh pr comment https://github.com/soehms/sage/pull/6 -b "Test action closed"
https://github.com/soehms/sage/pull/6#issuecomment-1476721469
INFO:root:Add comment to pull request #6: Test action closed
INFO:root:List of labels for pull request #6: []
INFO:root:Execute command: gh pr comment https://github.com/soehms/sage/pull/6 -b "Test action labeled"
https://github.com/soehms/sage/pull/6#issuecomment-1476721525
INFO:root:Add comment to pull request #6: Test action labeled
INFO:root:Execute command: gh pr edit https://github.com/soehms/sage/pull/6 --add-label "s: positive review"
https://github.com/soehms/sage/pull/6
INFO:root:Add label to pull request #6: s: positive review
INFO:root:List of labels for pull request #6: ['s: positive review']
INFO:root:Reviews for pull request #6: []
INFO:root:PR pull request #6 can't be approved because of missing member review
INFO:root:Execute command: gh pr comment https://github.com/soehms/sage/pull/6 -b "Label *s: positive review* can not be added. Please use the corresponding functionality of GitHub"
https://github.com/soehms/sage/pull/6#issuecomment-1476721644
INFO:root:Add comment to pull request #6: Label *s: positive review* can not be added. Please use the corresponding functionality of GitHub
INFO:root:Execute command: gh pr edit https://github.com/soehms/sage/pull/6 --remove-label "s: positive review"
https://github.com/soehms/sage/pull/6
INFO:root:Remove label from pull request #6: s: positive review
INFO:root:Execute command: gh pr edit https://github.com/soehms/sage/pull/6 --add-label "s: needs work"
https://github.com/soehms/sage/pull/6
INFO:root:Add label to pull request #6: s: needs work
INFO:root:List of labels for pull request #6: ['s: needs review', 's: needs work']
INFO:root:Reviews for pull request #6: []
INFO:root:Issue pull request #6 is draft False
INFO:root:Execute command: gh pr review https://github.com/soehms/sage/pull/6 -b "sagetrac-github-bot requested changes for this PR" "--request-changes"
failed to create review: Message: Can not request changes on your own pull request, Locations: [{Line:1 Column:66}]
WARNING:root:Execution of gh pr review https://github.com/soehms/sage/pull/6 -b "sagetrac-github-bot requested changes for this PR" "--request-changes" failed with exit code: 256
INFO:root:Changes requested for PR pull request #6 by sagetrac-github-bot
INFO:root:Execute command: gh pr edit https://github.com/soehms/sage/pull/6 --remove-label "s: needs review"
https://github.com/soehms/sage/pull/6
INFO:root:Remove label from pull request #6: s: needs review
INFO:root:List of labels for pull request #6: ['s: needs work']
INFO:root:Active partners of  State.needs_review: [<State.needs_work: 's: needs work'>]
INFO:root:Execute command: gh pr comment https://github.com/soehms/sage/pull/6 -b "Label *s: needs review* can not be added due to *s: needs work*!"
https://github.com/soehms/sage/pull/6#issuecomment-1476722010
INFO:root:Add comment to pull request #6: Label *s: needs review* can not be added due to *s: needs work*!
INFO:root:Execute command: gh pr edit https://github.com/soehms/sage/pull/6 --add-label "s: needs info"
https://github.com/soehms/sage/pull/6
INFO:root:Add label to pull request #6: s: needs info
INFO:root:List of labels for pull request #6: ['s: needs info', 's: needs work']
INFO:root:Execute command: gh pr edit https://github.com/soehms/sage/pull/6 --remove-label "s: needs work"
https://github.com/soehms/sage/pull/6
INFO:root:Remove label from pull request #6: s: needs work
INFO:root:Execute command: gh pr edit https://github.com/soehms/sage/pull/6 --add-label "p: blocker /1"
https://github.com/soehms/sage/pull/6
INFO:root:Add label to pull request #6: p: blocker /1
INFO:root:List of labels for pull request #6: ['p: blocker /1', 's: needs info', 's: positive review']
INFO:root:Execute command: gh pr edit https://github.com/soehms/sage/pull/6 --add-label "p: critical /2"
https://github.com/soehms/sage/pull/6
INFO:root:Add label to pull request #6: p: critical /2
INFO:root:List of labels for pull request #6: ['p: critical /2', 'p: blocker /1', 's: positive review']
INFO:root:Execute command: gh pr edit https://github.com/soehms/sage/pull/6 --remove-label "p: blocker /1"
https://github.com/soehms/sage/pull/6
INFO:root:Remove label from pull request #6: p: blocker /1
INFO:root:Execute command: gh pr edit https://github.com/soehms/sage/pull/6 --add-label "p: major /3"
https://github.com/soehms/sage/pull/6
INFO:root:Add label to pull request #6: p: major /3
INFO:root:List of labels for pull request #6: ['p: major /3', 'p: critical /2', 's: needs review', 's: positive review']
INFO:root:Execute command: gh pr edit https://github.com/soehms/sage/pull/6 --remove-label "p: critical /2"
https://github.com/soehms/sage/pull/6
INFO:root:Remove label from pull request #6: p: critical /2
INFO:root:Execute command: gh pr edit https://github.com/soehms/sage/pull/6 --add-label "p: minor /4"
https://github.com/soehms/sage/pull/6
INFO:root:Add label to pull request #6: p: minor /4
INFO:root:List of labels for pull request #6: ['p: minor /4', 'p: major /3', 's: needs review', 's: needs work', 's: positive review']
INFO:root:Execute command: gh pr edit https://github.com/soehms/sage/pull/6 --remove-label "p: major /3"
https://github.com/soehms/sage/pull/6
INFO:root:Remove label from pull request #6: p: major /3
INFO:root:Execute command: gh pr edit https://github.com/soehms/sage/pull/6 --add-label "p: trivial /5"
https://github.com/soehms/sage/pull/6
INFO:root:Add label to pull request #6: p: trivial /5
INFO:root:List of labels for pull request #6: ['p: trivial /5', 'p: minor /4', 's: needs review', 's: needs work', 's: positive review']
INFO:root:Execute command: gh pr edit https://github.com/soehms/sage/pull/6 --remove-label "p: minor /4"
https://github.com/soehms/sage/pull/6
INFO:root:Remove label from pull request #6: p: minor /4
INFO:root:Execute command: gh pr edit https://github.com/soehms/sage/pull/6 --add-label "r: worksforme"
https://github.com/soehms/sage/pull/6
INFO:root:Add label to pull request #6: r: worksforme
INFO:root:List of labels for pull request #6: ['p: trivial /5', 'p: blocker /1', 's: needs review', 's: needs work', 's: positive review', 'r: worksforme']
INFO:root:Execute command: gh pr edit https://github.com/soehms/sage/pull/6 --remove-label "p: blocker /1"
https://github.com/soehms/sage/pull/6
INFO:root:Remove label from pull request #6: p: blocker /1
INFO:root:Execute command: gh pr comment https://github.com/soehms/sage/pull/6 -b "Test action unlabeled"
https://github.com/soehms/sage/pull/6#issuecomment-1476722846
INFO:root:Add comment to pull request #6: Test action unlabeled
INFO:root:Execute command: gh pr edit https://github.com/soehms/sage/pull/6 --remove-label "s: positive review"
https://github.com/soehms/sage/pull/6
INFO:root:Remove label from pull request #6: s: positive review
INFO:root:Execute command: gh pr comment https://github.com/soehms/sage/pull/6 -b "Label *s: positive review* can not be removed. Please add the state-label which should replace it"
https://github.com/soehms/sage/pull/6#issuecomment-1476722982
INFO:root:Add comment to pull request #6: Label *s: positive review* can not be removed. Please add the state-label which should replace it
INFO:root:List of labels for pull request #6: ['p: trivial /5', 'p: major /3', 'p: critical /2', 's: needs review', 's: needs work', 'r: worksforme']
INFO:root:Execute command: gh pr edit https://github.com/soehms/sage/pull/6 --add-label "s: positive review"
https://github.com/soehms/sage/pull/6
INFO:root:Add label to pull request #6: s: positive review
INFO:root:Execute command: gh pr edit https://github.com/soehms/sage/pull/6 --remove-label "s: needs work"
https://github.com/soehms/sage/pull/6
INFO:root:Remove label from pull request #6: s: needs work
INFO:root:Execute command: gh pr comment https://github.com/soehms/sage/pull/6 -b "Label *s: needs work* can not be removed. Please add the state-label which should replace it"
https://github.com/soehms/sage/pull/6#issuecomment-1476723202
INFO:root:Add comment to pull request #6: Label *s: needs work* can not be removed. Please add the state-label which should replace it
INFO:root:List of labels for pull request #6: ['p: minor /4', 's: needs review', 's: positive review', 'r: worksforme']
INFO:root:Execute command: gh pr edit https://github.com/soehms/sage/pull/6 --add-label "s: needs work"
https://github.com/soehms/sage/pull/6
INFO:root:Add label to pull request #6: s: needs work
INFO:root:Execute command: gh pr edit https://github.com/soehms/sage/pull/6 --remove-label "s: needs review"
https://github.com/soehms/sage/pull/6
INFO:root:Remove label from pull request #6: s: needs review
INFO:root:Execute command: gh pr comment https://github.com/soehms/sage/pull/6 -b "Label *s: needs review* can not be removed. Please add the state-label which should replace it"
https://github.com/soehms/sage/pull/6#issuecomment-1476723400
INFO:root:Add comment to pull request #6: Label *s: needs review* can not be removed. Please add the state-label which should replace it
INFO:root:List of labels for pull request #6: ['p: minor /4', 'p: blocker /1', 's: needs work', 's: positive review', 'r: worksforme']
INFO:root:Execute command: gh pr edit https://github.com/soehms/sage/pull/6 --add-label "s: needs review"
https://github.com/soehms/sage/pull/6
INFO:root:Add label to pull request #6: s: needs review
INFO:root:List of labels for pull request #6: ['p: minor /4', 'p: blocker /1', 's: needs review', 's: needs work', 's: positive review', 'r: worksforme']
INFO:root:Execute command: gh pr edit https://github.com/soehms/sage/pull/6 --remove-label "p: blocker /1"
https://github.com/soehms/sage/pull/6
INFO:root:Remove label from pull request #6: p: blocker /1
INFO:root:Execute command: gh pr comment https://github.com/soehms/sage/pull/6 -b "Label *p: blocker /1* can not be removed. Please add the priority-label which should replace it"
https://github.com/soehms/sage/pull/6#issuecomment-1476723533
INFO:root:Add comment to pull request #6: Label *p: blocker /1* can not be removed. Please add the priority-label which should replace it
INFO:root:List of labels for pull request #6: ['p: minor /4', 's: needs review', 's: needs work', 'r: worksforme']
INFO:root:Execute command: gh pr edit https://github.com/soehms/sage/pull/6 --add-label "p: blocker /1"
https://github.com/soehms/sage/pull/6
INFO:root:Add label to pull request #6: p: blocker /1
INFO:root:Execute command: gh pr comment https://github.com/soehms/sage/pull/6 -b "Label *p: critical /2* can not be removed. Please add the priority-label which should replace it"
https://github.com/soehms/sage/pull/6#issuecomment-1476723638
INFO:root:Add comment to pull request #6: Label *p: critical /2* can not be removed. Please add the priority-label which should replace it
INFO:root:List of labels for pull request #6: ['p: minor /4', 'p: blocker /1', 's: needs review', 'r: worksforme']
INFO:root:Execute command: gh pr edit https://github.com/soehms/sage/pull/6 --add-label "p: critical /2"
https://github.com/soehms/sage/pull/6
INFO:root:Add label to pull request #6: p: critical /2
INFO:root:Execute command: gh pr comment https://github.com/soehms/sage/pull/6 -b "Label *p: major /3* can not be removed. Please add the priority-label which should replace it"
https://github.com/soehms/sage/pull/6#issuecomment-1476723722
INFO:root:Add comment to pull request #6: Label *p: major /3* can not be removed. Please add the priority-label which should replace it
INFO:root:List of labels for pull request #6: ['p: minor /4', 'p: critical /2', 'p: blocker /1', 'r: worksforme']
INFO:root:Execute command: gh pr edit https://github.com/soehms/sage/pull/6 --add-label "p: major /3"
https://github.com/soehms/sage/pull/6
INFO:root:Add label to pull request #6: p: major /3
INFO:root:Execute command: gh pr edit https://github.com/soehms/sage/pull/6 --remove-label "p: minor /4"
https://github.com/soehms/sage/pull/6
INFO:root:Remove label from pull request #6: p: minor /4
INFO:root:Execute command: gh pr comment https://github.com/soehms/sage/pull/6 -b "Label *p: minor /4* can not be removed. Please add the priority-label which should replace it"
https://github.com/soehms/sage/pull/6#issuecomment-1476723821
INFO:root:Add comment to pull request #6: Label *p: minor /4* can not be removed. Please add the priority-label which should replace it
INFO:root:List of labels for pull request #6: ['p: major /3', 'p: blocker /1', 'r: worksforme']
INFO:root:Execute command: gh pr edit https://github.com/soehms/sage/pull/6 --add-label "p: minor /4"
https://github.com/soehms/sage/pull/6
INFO:root:Add label to pull request #6: p: minor /4
INFO:root:Execute command: gh pr comment https://github.com/soehms/sage/pull/6 -b "Label *p: trivial /5* can not be removed. Please add the priority-label which should replace it"
https://github.com/soehms/sage/pull/6#issuecomment-1476723893
INFO:root:Add comment to pull request #6: Label *p: trivial /5* can not be removed. Please add the priority-label which should replace it
INFO:root:List of labels for pull request #6: ['p: blocker /1', 'r: worksforme']
INFO:root:Execute command: gh pr edit https://github.com/soehms/sage/pull/6 --add-label "p: trivial /5"
https://github.com/soehms/sage/pull/6
INFO:root:Add label to pull request #6: p: trivial /5
INFO:root:Execute command: gh pr comment https://github.com/soehms/sage/pull/6 -b "Test action ready_for_review"
https://github.com/soehms/sage/pull/6#issuecomment-1476723961
INFO:root:Add comment to pull request #6: Test action ready_for_review
INFO:root:Issue pull request #6 is draft False
INFO:root:Reviews for pull request #6: [{'author': {'login': 'github-actions'}, 'authorAssociation': 'NONE', 'body': 'soehms requested changes for this PR', 'submittedAt': '2023-03-20T18:17:18Z', 'includesCreatedEdit': False, 'reactionGroups': [], 'state': 'CHANGES_REQUESTED'}]
INFO:root:Commits until 2023-03-20T08:07:42Z for pull request #6: [{'authoredDate': '2023-03-20T06:58:49Z', 'authors': [{'email': 'seb.oehms@gmail.com', 'id': 'MDQ6VXNlcjQ3MzA1ODQ1', 'login': 'soehms', 'name': 'Sebastian'}], 'committedDate': '2023-03-20T06:58:49Z', 'messageBody': '', 'messageHeadline': "Merge branch 'sync_labels' of github.com:soehms/sage into sync_labels", 'oid': '981b9d59acaee84322eb2e77eaf2fac092dda76f'}, {'authoredDate': '2023-03-20T07:12:35Z', 'authors': [{'email': 'seb.oehms@gmail.com', 'id': 'MDQ6VXNlcjQ3MzA1ODQ1', 'login': 'soehms', 'name': 'Sebastian'}], 'committedDate': '2023-03-20T07:12:35Z', 'messageBody': '', 'messageHeadline': 'sync_labels_add_on_review_comment initial', 'oid': 'e7209c42397896d1050cf5988a39ad37a5b79ebe'}, {'authoredDate': '2023-03-20T08:07:42Z', 'authors': [{'email': 'seb.oehms@gmail.com', 'id': 'MDQ6VXNlcjQ3MzA1ODQ1', 'login': 'soehms', 'name': 'Sebastian Oehms'}], 'committedDate': '2023-03-20T08:07:42Z', 'messageBody': '', 'messageHeadline': "Merge branch 'sync_labels' into sync_labels_add_on_review_comment", 'oid': '28b5d0f4058747409726292cd6cbe3192463e47b'}]
INFO:root:Proper reviews after 2023-03-20T08:07:42Z for pull request #6: [{'author': {'login': 'github-actions'}, 'authorAssociation': 'NONE', 'body': 'soehms requested changes for this PR', 'submittedAt': '2023-03-20T18:17:18Z', 'includesCreatedEdit': False, 'reactionGroups': [], 'state': 'CHANGES_REQUESTED'}]
INFO:root:Review decision for pull request #6: CHANGES_REQUESTED
INFO:root:PR pull request #6 needs work (by decision)
INFO:root:PR pull request #6 already under review (needs work)
INFO:root:Execute command: gh pr comment https://github.com/soehms/sage/pull/6 -b "Test action synchronize"
https://github.com/soehms/sage/pull/6#issuecomment-1476724064
INFO:root:Add comment to pull request #6: Test action synchronize
INFO:root:Issue pull request #6 is draft False
INFO:root:Reviews for pull request #6: [{'author': {'login': 'github-actions'}, 'authorAssociation': 'NONE', 'body': 'soehms requested changes for this PR', 'submittedAt': '2023-03-20T18:17:18Z', 'includesCreatedEdit': False, 'reactionGroups': [], 'state': 'CHANGES_REQUESTED'}]
INFO:root:Commits until 2023-03-20T08:07:42Z for pull request #6: [{'authoredDate': '2023-03-20T06:58:49Z', 'authors': [{'email': 'seb.oehms@gmail.com', 'id': 'MDQ6VXNlcjQ3MzA1ODQ1', 'login': 'soehms', 'name': 'Sebastian'}], 'committedDate': '2023-03-20T06:58:49Z', 'messageBody': '', 'messageHeadline': "Merge branch 'sync_labels' of github.com:soehms/sage into sync_labels", 'oid': '981b9d59acaee84322eb2e77eaf2fac092dda76f'}, {'authoredDate': '2023-03-20T07:12:35Z', 'authors': [{'email': 'seb.oehms@gmail.com', 'id': 'MDQ6VXNlcjQ3MzA1ODQ1', 'login': 'soehms', 'name': 'Sebastian'}], 'committedDate': '2023-03-20T07:12:35Z', 'messageBody': '', 'messageHeadline': 'sync_labels_add_on_review_comment initial', 'oid': 'e7209c42397896d1050cf5988a39ad37a5b79ebe'}, {'authoredDate': '2023-03-20T08:07:42Z', 'authors': [{'email': 'seb.oehms@gmail.com', 'id': 'MDQ6VXNlcjQ3MzA1ODQ1', 'login': 'soehms', 'name': 'Sebastian Oehms'}], 'committedDate': '2023-03-20T08:07:42Z', 'messageBody': '', 'messageHeadline': "Merge branch 'sync_labels' into sync_labels_add_on_review_comment", 'oid': '28b5d0f4058747409726292cd6cbe3192463e47b'}]
INFO:root:Proper reviews after 2023-03-20T08:07:42Z for pull request #6: [{'author': {'login': 'github-actions'}, 'authorAssociation': 'NONE', 'body': 'soehms requested changes for this PR', 'submittedAt': '2023-03-20T18:17:18Z', 'includesCreatedEdit': False, 'reactionGroups': [], 'state': 'CHANGES_REQUESTED'}]
INFO:root:Review decision for pull request #6: CHANGES_REQUESTED
INFO:root:PR pull request #6 needs work (by decision)
INFO:root:PR pull request #6 already under review (needs work)
INFO:root:Execute command: gh pr comment https://github.com/soehms/sage/pull/6 -b "Test action review_requested"
https://github.com/soehms/sage/pull/6#issuecomment-1476724138
INFO:root:Add comment to pull request #6: Test action review_requested
INFO:root:List of labels for pull request #6: ['p: minor /4', 'r: worksforme']
INFO:root:Execute command: gh pr edit https://github.com/soehms/sage/pull/6 --add-label "s: needs review"
https://github.com/soehms/sage/pull/6
INFO:root:Add label to pull request #6: s: needs review
INFO:root:Execute command: gh pr comment https://github.com/soehms/sage/pull/6 -b "Test action converted_to_draft"
https://github.com/soehms/sage/pull/6#issuecomment-1476724250
INFO:root:Add comment to pull request #6: Test action converted_to_draft
INFO:root:List of labels for pull request #6: ['p: minor /4', 's: needs review', 'r: worksforme']
INFO:root:Execute command: gh pr edit https://github.com/soehms/sage/pull/6 --remove-label "s: needs review"
https://github.com/soehms/sage/pull/6
INFO:root:Remove label from pull request #6: s: needs review
INFO:root:Execute command: gh pr comment https://github.com/soehms/sage/pull/6 -b "Test action submitted"
https://github.com/soehms/sage/pull/6#issuecomment-1476724330
INFO:root:Add comment to pull request #6: Test action submitted
INFO:root:Execute command: gh pr review https://github.com/soehms/sage/pull/6 -b "s: positive review" "--comment"
- Reviewed pull request #6
INFO:root:Add review comment for PR pull request #6: s: positive review
INFO:root:Reviews for pull request #6: [{'author': {'login': 'github-actions'}, 'authorAssociation': 'NONE', 'body': 'soehms requested changes for this PR', 'submittedAt': '2023-03-20T18:17:18Z', 'includesCreatedEdit': False, 'reactionGroups': [], 'state': 'CHANGES_REQUESTED'}, {'author': {'login': 'soehms'}, 'authorAssociation': 'OWNER', 'body': 's: positive review', 'submittedAt': '2023-03-20T18:18:45Z', 'includesCreatedEdit': False, 'reactionGroups': [], 'state': 'COMMENTED'}]
INFO:root:Execute command: gh pr review https://github.com/soehms/sage/pull/6 -b "s: needs work" "--comment"
- Reviewed pull request #6
INFO:root:Add review comment for PR pull request #6: s: needs work
INFO:root:Reviews for pull request #6: [{'author': {'login': 'github-actions'}, 'authorAssociation': 'NONE', 'body': 'soehms requested changes for this PR', 'submittedAt': '2023-03-20T18:17:18Z', 'includesCreatedEdit': False, 'reactionGroups': [], 'state': 'CHANGES_REQUESTED'}, {'author': {'login': 'soehms'}, 'authorAssociation': 'OWNER', 'body': 's: positive review', 'submittedAt': '2023-03-20T18:18:45Z', 'includesCreatedEdit': False, 'reactionGroups': [], 'state': 'COMMENTED'}, {'author': {'login': 'soehms'}, 'authorAssociation': 'OWNER', 'body': 's: needs work', 'submittedAt': '2023-03-20T18:18:47Z', 'includesCreatedEdit': False, 'reactionGroups': [], 'state': 'COMMENTED'}]
INFO:root:Execute command: gh pr review https://github.com/soehms/sage/pull/6 -b "s: needs review" "--comment"
- Reviewed pull request #6
INFO:root:Add review comment for PR pull request #6: s: needs review
INFO:root:Reviews for pull request #6: [{'author': {'login': 'github-actions'}, 'authorAssociation': 'NONE', 'body': 'soehms requested changes for this PR', 'submittedAt': '2023-03-20T18:17:18Z', 'includesCreatedEdit': False, 'reactionGroups': [], 'state': 'CHANGES_REQUESTED'}, {'author': {'login': 'soehms'}, 'authorAssociation': 'OWNER', 'body': 's: positive review', 'submittedAt': '2023-03-20T18:18:45Z', 'includesCreatedEdit': False, 'reactionGroups': [], 'state': 'COMMENTED'}, {'author': {'login': 'soehms'}, 'authorAssociation': 'OWNER', 'body': 's: needs work', 'submittedAt': '2023-03-20T18:18:47Z', 'includesCreatedEdit': False, 'reactionGroups': [], 'state': 'COMMENTED'}, {'author': {'login': 'soehms'}, 'authorAssociation': 'OWNER', 'body': 's: needs review', 'submittedAt': '2023-03-20T18:18:49Z', 'includesCreatedEdit': False, 'reactionGroups': [], 'state': 'COMMENTED'}]
INFO:root:List of labels for pull request #6: ['p: minor /4', 'r: worksforme']
INFO:root:Execute command: gh pr edit https://github.com/soehms/sage/pull/6 --add-label "s: needs review"
https://github.com/soehms/sage/pull/6
INFO:root:Add label to pull request #6: s: needs review
INFO:root:List of labels for pull request #6: ['p: minor /4', 's: needs review', 'r: worksforme']
INFO:root:Issue pull request #6 is draft False
INFO:root:Reviews for pull request #6: [{'author': {'login': 'github-actions'}, 'authorAssociation': 'NONE', 'body': 'soehms requested changes for this PR', 'submittedAt': '2023-03-20T18:17:18Z', 'includesCreatedEdit': False, 'reactionGroups': [], 'state': 'CHANGES_REQUESTED'}, {'author': {'login': 'soehms'}, 'authorAssociation': 'OWNER', 'body': 's: positive review', 'submittedAt': '2023-03-20T18:18:45Z', 'includesCreatedEdit': False, 'reactionGroups': [], 'state': 'COMMENTED'}, {'author': {'login': 'soehms'}, 'authorAssociation': 'OWNER', 'body': 's: needs work', 'submittedAt': '2023-03-20T18:18:47Z', 'includesCreatedEdit': False, 'reactionGroups': [], 'state': 'COMMENTED'}, {'author': {'login': 'soehms'}, 'authorAssociation': 'OWNER', 'body': 's: needs review', 'submittedAt': '2023-03-20T18:18:49Z', 'includesCreatedEdit': False, 'reactionGroups': [], 'state': 'COMMENTED'}]
INFO:root:Commits until 2023-03-20T08:07:42Z for pull request #6: [{'authoredDate': '2023-03-20T06:58:49Z', 'authors': [{'email': 'seb.oehms@gmail.com', 'id': 'MDQ6VXNlcjQ3MzA1ODQ1', 'login': 'soehms', 'name': 'Sebastian'}], 'committedDate': '2023-03-20T06:58:49Z', 'messageBody': '', 'messageHeadline': "Merge branch 'sync_labels' of github.com:soehms/sage into sync_labels", 'oid': '981b9d59acaee84322eb2e77eaf2fac092dda76f'}, {'authoredDate': '2023-03-20T07:12:35Z', 'authors': [{'email': 'seb.oehms@gmail.com', 'id': 'MDQ6VXNlcjQ3MzA1ODQ1', 'login': 'soehms', 'name': 'Sebastian'}], 'committedDate': '2023-03-20T07:12:35Z', 'messageBody': '', 'messageHeadline': 'sync_labels_add_on_review_comment initial', 'oid': 'e7209c42397896d1050cf5988a39ad37a5b79ebe'}, {'authoredDate': '2023-03-20T08:07:42Z', 'authors': [{'email': 'seb.oehms@gmail.com', 'id': 'MDQ6VXNlcjQ3MzA1ODQ1', 'login': 'soehms', 'name': 'Sebastian Oehms'}], 'committedDate': '2023-03-20T08:07:42Z', 'messageBody': '', 'messageHeadline': "Merge branch 'sync_labels' into sync_labels_add_on_review_comment", 'oid': '28b5d0f4058747409726292cd6cbe3192463e47b'}]
INFO:root:Proper reviews after 2023-03-20T08:07:42Z for pull request #6: [{'author': {'login': 'github-actions'}, 'authorAssociation': 'NONE', 'body': 'soehms requested changes for this PR', 'submittedAt': '2023-03-20T18:17:18Z', 'includesCreatedEdit': False, 'reactionGroups': [], 'state': 'CHANGES_REQUESTED'}]
INFO:root:Review decision for pull request #6: CHANGES_REQUESTED
INFO:root:PR pull request #6 needs work (by decision)
INFO:root:PR pull request #6 already under review (needs work)
INFO:root:Execute command: gh pr comment https://github.com/soehms/sage/pull/6 -b "Label *s: needs review* can not be added. Please use the corresponding functionality of GitHub"
https://github.com/soehms/sage/pull/6#issuecomment-1476724613
INFO:root:Add comment to pull request #6: Label *s: needs review* can not be added. Please use the corresponding functionality of GitHub
INFO:root:Execute command: gh pr edit https://github.com/soehms/sage/pull/6 --remove-label "s: needs review"
https://github.com/soehms/sage/pull/6
INFO:root:Remove label from pull request #6: s: needs review
INFO:root:Execute command: gh pr review https://github.com/soehms/sage/pull/6 -b "s: needs info" "--comment"
- Reviewed pull request #6
INFO:root:Add review comment for PR pull request #6: s: needs info
INFO:root:Reviews for pull request #6: [{'author': {'login': 'github-actions'}, 'authorAssociation': 'NONE', 'body': 'soehms requested changes for this PR', 'submittedAt': '2023-03-20T18:17:18Z', 'includesCreatedEdit': False, 'reactionGroups': [], 'state': 'CHANGES_REQUESTED'}, {'author': {'login': 'soehms'}, 'authorAssociation': 'OWNER', 'body': 's: positive review', 'submittedAt': '2023-03-20T18:18:45Z', 'includesCreatedEdit': False, 'reactionGroups': [], 'state': 'COMMENTED'}, {'author': {'login': 'soehms'}, 'authorAssociation': 'OWNER', 'body': 's: needs work', 'submittedAt': '2023-03-20T18:18:47Z', 'includesCreatedEdit': False, 'reactionGroups': [], 'state': 'COMMENTED'}, {'author': {'login': 'soehms'}, 'authorAssociation': 'OWNER', 'body': 's: needs review', 'submittedAt': '2023-03-20T18:18:49Z', 'includesCreatedEdit': False, 'reactionGroups': [], 'state': 'COMMENTED'}, {'author': {'login': 'soehms'}, 'authorAssociation': 'OWNER', 'body': 's: needs info', 'submittedAt': '2023-03-20T18:19:00Z', 'includesCreatedEdit': False, 'reactionGroups': [], 'state': 'COMMENTED'}]
INFO:root:List of labels for pull request #6: ['p: minor /4', 'r: worksforme']
INFO:root:Execute command: gh pr edit https://github.com/soehms/sage/pull/6 --add-label "s: needs info"
https://github.com/soehms/sage/pull/6
INFO:root:Add label to pull request #6: s: needs info
INFO:root:List of labels for pull request #6: ['p: minor /4', 's: needs info', 'r: worksforme']
INFO:root:Execute command: gh pr review https://github.com/soehms/sage/pull/6 -b "sagetrac-github-bot approved this PR" "--approve"
failed to create review: Message: Can not approve your own pull request, Locations: [{Line:1 Column:66}]
WARNING:root:Execution of gh pr review https://github.com/soehms/sage/pull/6 -b "sagetrac-github-bot approved this PR" "--approve" failed with exit code: 256
INFO:root:PR pull request #6 approved by sagetrac-github-bot
INFO:root:Reviews for pull request #6: [{'author': {'login': 'github-actions'}, 'authorAssociation': 'NONE', 'body': 'soehms requested changes for this PR', 'submittedAt': '2023-03-20T18:17:18Z', 'includesCreatedEdit': False, 'reactionGroups': [], 'state': 'CHANGES_REQUESTED'}, {'author': {'login': 'soehms'}, 'authorAssociation': 'OWNER', 'body': 's: positive review', 'submittedAt': '2023-03-20T18:18:45Z', 'includesCreatedEdit': False, 'reactionGroups': [], 'state': 'COMMENTED'}, {'author': {'login': 'soehms'}, 'authorAssociation': 'OWNER', 'body': 's: needs work', 'submittedAt': '2023-03-20T18:18:47Z', 'includesCreatedEdit': False, 'reactionGroups': [], 'state': 'COMMENTED'}, {'author': {'login': 'soehms'}, 'authorAssociation': 'OWNER', 'body': 's: needs review', 'submittedAt': '2023-03-20T18:18:49Z', 'includesCreatedEdit': False, 'reactionGroups': [], 'state': 'COMMENTED'}, {'author': {'login': 'soehms'}, 'authorAssociation': 'OWNER', 'body': 's: needs info', 'submittedAt': '2023-03-20T18:19:00Z', 'includesCreatedEdit': False, 'reactionGroups': [], 'state': 'COMMENTED'}]
INFO:root:Commits until 2023-03-20T08:07:42Z for pull request #6: [{'authoredDate': '2023-03-20T06:58:49Z', 'authors': [{'email': 'seb.oehms@gmail.com', 'id': 'MDQ6VXNlcjQ3MzA1ODQ1', 'login': 'soehms', 'name': 'Sebastian'}], 'committedDate': '2023-03-20T06:58:49Z', 'messageBody': '', 'messageHeadline': "Merge branch 'sync_labels' of github.com:soehms/sage into sync_labels", 'oid': '981b9d59acaee84322eb2e77eaf2fac092dda76f'}, {'authoredDate': '2023-03-20T07:12:35Z', 'authors': [{'email': 'seb.oehms@gmail.com', 'id': 'MDQ6VXNlcjQ3MzA1ODQ1', 'login': 'soehms', 'name': 'Sebastian'}], 'committedDate': '2023-03-20T07:12:35Z', 'messageBody': '', 'messageHeadline': 'sync_labels_add_on_review_comment initial', 'oid': 'e7209c42397896d1050cf5988a39ad37a5b79ebe'}, {'authoredDate': '2023-03-20T08:07:42Z', 'authors': [{'email': 'seb.oehms@gmail.com', 'id': 'MDQ6VXNlcjQ3MzA1ODQ1', 'login': 'soehms', 'name': 'Sebastian Oehms'}], 'committedDate': '2023-03-20T08:07:42Z', 'messageBody': '', 'messageHeadline': "Merge branch 'sync_labels' into sync_labels_add_on_review_comment", 'oid': '28b5d0f4058747409726292cd6cbe3192463e47b'}]
INFO:root:Proper reviews after 2023-03-20T08:07:42Z for pull request #6: [{'author': {'login': 'github-actions'}, 'authorAssociation': 'NONE', 'body': 'soehms requested changes for this PR', 'submittedAt': '2023-03-20T18:17:18Z', 'includesCreatedEdit': False, 'reactionGroups': [], 'state': 'CHANGES_REQUESTED'}]
INFO:root:Review decision for pull request #6: CHANGES_REQUESTED
INFO:root:PR pull request #6 doesn't have positve review (by decision)
INFO:root:Execute command: gh pr review https://github.com/soehms/sage/pull/6 -b "sagetrac-github-bot requested changes for this PR" "--request-changes"
failed to create review: Message: Can not request changes on your own pull request, Locations: [{Line:1 Column:66}]
WARNING:root:Execution of gh pr review https://github.com/soehms/sage/pull/6 -b "sagetrac-github-bot requested changes for this PR" "--request-changes" failed with exit code: 256
INFO:root:Changes requested for PR pull request #6 by sagetrac-github-bot
INFO:root:Reviews for pull request #6: [{'author': {'login': 'github-actions'}, 'authorAssociation': 'NONE', 'body': 'soehms requested changes for this PR', 'submittedAt': '2023-03-20T18:17:18Z', 'includesCreatedEdit': False, 'reactionGroups': [], 'state': 'CHANGES_REQUESTED'}, {'author': {'login': 'soehms'}, 'authorAssociation': 'OWNER', 'body': 's: positive review', 'submittedAt': '2023-03-20T18:18:45Z', 'includesCreatedEdit': False, 'reactionGroups': [], 'state': 'COMMENTED'}, {'author': {'login': 'soehms'}, 'authorAssociation': 'OWNER', 'body': 's: needs work', 'submittedAt': '2023-03-20T18:18:47Z', 'includesCreatedEdit': False, 'reactionGroups': [], 'state': 'COMMENTED'}, {'author': {'login': 'soehms'}, 'authorAssociation': 'OWNER', 'body': 's: needs review', 'submittedAt': '2023-03-20T18:18:49Z', 'includesCreatedEdit': False, 'reactionGroups': [], 'state': 'COMMENTED'}, {'author': {'login': 'soehms'}, 'authorAssociation': 'OWNER', 'body': 's: needs info', 'submittedAt': '2023-03-20T18:19:00Z', 'includesCreatedEdit': False, 'reactionGroups': [], 'state': 'COMMENTED'}]
INFO:root:Commits until 2023-03-20T08:07:42Z for pull request #6: [{'authoredDate': '2023-03-20T06:58:49Z', 'authors': [{'email': 'seb.oehms@gmail.com', 'id': 'MDQ6VXNlcjQ3MzA1ODQ1', 'login': 'soehms', 'name': 'Sebastian'}], 'committedDate': '2023-03-20T06:58:49Z', 'messageBody': '', 'messageHeadline': "Merge branch 'sync_labels' of github.com:soehms/sage into sync_labels", 'oid': '981b9d59acaee84322eb2e77eaf2fac092dda76f'}, {'authoredDate': '2023-03-20T07:12:35Z', 'authors': [{'email': 'seb.oehms@gmail.com', 'id': 'MDQ6VXNlcjQ3MzA1ODQ1', 'login': 'soehms', 'name': 'Sebastian'}], 'committedDate': '2023-03-20T07:12:35Z', 'messageBody': '', 'messageHeadline': 'sync_labels_add_on_review_comment initial', 'oid': 'e7209c42397896d1050cf5988a39ad37a5b79ebe'}, {'authoredDate': '2023-03-20T08:07:42Z', 'authors': [{'email': 'seb.oehms@gmail.com', 'id': 'MDQ6VXNlcjQ3MzA1ODQ1', 'login': 'soehms', 'name': 'Sebastian Oehms'}], 'committedDate': '2023-03-20T08:07:42Z', 'messageBody': '', 'messageHeadline': "Merge branch 'sync_labels' into sync_labels_add_on_review_comment", 'oid': '28b5d0f4058747409726292cd6cbe3192463e47b'}]
INFO:root:Proper reviews after 2023-03-20T08:07:42Z for pull request #6: [{'author': {'login': 'github-actions'}, 'authorAssociation': 'NONE', 'body': 'soehms requested changes for this PR', 'submittedAt': '2023-03-20T18:17:18Z', 'includesCreatedEdit': False, 'reactionGroups': [], 'state': 'CHANGES_REQUESTED'}]
INFO:root:Review decision for pull request #6: CHANGES_REQUESTED
INFO:root:PR pull request #6 needs work (by decision)
INFO:root:List of labels for pull request #6: ['p: minor /4', 's: needs info', 'r: worksforme']
INFO:root:Execute command: gh pr edit https://github.com/soehms/sage/pull/6 --add-label "s: needs work"
https://github.com/soehms/sage/pull/6
INFO:root:Add label to pull request #6: s: needs work
INFO:root:Execute command: gh pr edit https://github.com/soehms/sage/pull/6 --remove-label "s: needs info"
https://github.com/soehms/sage/pull/6
INFO:root:Remove label from pull request #6: s: needs info

@github-actions
Copy link
Copy Markdown

Label s: needs review can not be added. Please use the corresponding functionality of GitHub

1 similar comment
@github-actions
Copy link
Copy Markdown

Label s: needs review can not be added. Please use the corresponding functionality of GitHub

Copy link
Copy Markdown
Owner Author

@soehms soehms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s: needs info

@github-actions
Copy link
Copy Markdown

Label s: positive review can not be added. Please use the corresponding functionality of GitHub

1 similar comment
@github-actions
Copy link
Copy Markdown

Label s: positive review can not be added. Please use the corresponding functionality of GitHub

@github-actions
Copy link
Copy Markdown

Documentation preview for this PR is ready! 🎉
Built with commit: 28b5d0f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant