Reviewing files that changed from the base of the PR and between 3d63108 and 8594b43.

• pixi.lock is excluded by !**/*.lock
• pyproject.toml is excluded by !pyproject.toml

• .gitattributes (1 hunks)
• .github/workflows/release-please.yml (1 hunks)
• .github/workflows/test.yml (1 hunks)
• .gitignore (1 hunks)
• src/snakemake_interface_common/exceptions.py (1 hunks)
• src/snakemake_interface_common/plugin_registry/__init__.py (1 hunks)
• src/snakemake_interface_common/plugin_registry/plugin.py (1 hunks)
• src/snakemake_interface_common/plugin_registry/tests.py (2 hunks)
• src/snakemake_interface_common/rules.py (1 hunks)

.gitattributes (1)

1-2: LGTM: Appropriate Git attributes for pixi.lock file

This configuration correctly sets up Git attributes for the pixi.lock file, marking it as a binary file for merge purposes, setting YAML syntax highlighting, and indicating it's a generated file. This aligns with the PR objective of setting up pixi for dependency management.

.gitignore (1)

162-165: LGTM: Proper ignores for pixi environment files

Adding ignores for .pixi directory and *.egg-info files is appropriate for the transition to pixi and the new src layout. These entries ensure that environment-specific and build-related files are properly excluded from version control.

src/snakemake_interface_common/exceptions.py (1)

31-34: LGTM: Improved formatting of the conditional statement

The reformatting of the isinstance parameters improves readability while maintaining the same functionality. This change aligns with the PR objective of running ruff formatter on the codebase.

src/snakemake_interface_common/plugin_registry/__init__.py (1)

130-131:

Details

✅ Verification successful

Verify function call sites for API compatibility

Similarly, the expected_attributes method has been changed from an abstract property to a standard abstract method with inline ellipsis. Verify that all call sites have been updated accordingly.

---

🏁 Script executed:

#!/bin/bash
# Search for usages of expected_attributes as a property vs method
echo "Searching for usages of expected_attributes as a property..."
rg "\.expected_attributes\b(?!\()" -t py

echo -e "\nSearching for usages of expected_attributes as a method..."
rg "\.expected_attributes\(" -t py

Length of output: 715

---

API Call-Site Verification for expected_attributes

After reviewing the usage across the codebase, the update is verified. The abstract method is now correctly being invoked—with the call site in src/snakemake_interface_common/plugin_registry/__init__.py using self.expected_attributes(). No legacy property-style accesses were detected.

Please ensure any additional modules or future call sites also invoke it as a method.

src/snakemake_interface_common/plugin_registry/plugin.py (1)

64-64: LGTM! Style improvements aligned with formatting standardization.

The changes to abstract method declarations make the code more concise by moving the ellipsis to the same line as the method signature. This is consistent with modern Python style and aligns with the PR's objective to run ruff format.

Also applies to: 68-68, 72-72

src/snakemake_interface_common/rules.py (1)

8-8: LGTM! Consistent style improvements across the codebase.

These changes follow the same pattern as in other files, moving the ellipsis to the same line as the method signature for abstract methods. This creates a more concise code style while maintaining type annotations.

Also applies to: 12-12, 16-16

.github/workflows/release-please.yml (1)

25-28: LGTM! Successfully migrated from Poetry to Pixi for the release workflow.

The changes to the release workflow appropriately implement Pixi for dependency management and build processes:

1. Updated checkout action to v4 with full history (fetch-depth: 0)
2. Added Pixi installation with the specific environment and version
3. Updated build and publish steps to use Pixi commands
4. Used the latest PyPI publish action

These changes align with the PR's objective to set up Pixi and modernize the workflow.

Also applies to: 29-34, 35-38, 39-43

.github/workflows/test.yml (6)

10-14: LGTM! Good security practice adding explicit permissions.

Adding explicit permissions follows GitHub Actions best practices and improves the security posture of the workflow. The permissions granted are appropriate for a CI workflow.

---

17-17: LGTM! More descriptive job name.

Renaming from "formatting" to "quality-control" better reflects the expanded scope of the job, which now includes formatting, linting, and potentially type checking.

---

21-29: LGTM! Successfully migrated to Pixi for the testing workflow.

The changes appropriately set up Pixi with the development environment and caching enabled, which should improve workflow performance. Using the latest checkout action (v4) is also a good practice.

---

30-43: LGTM! Comprehensive quality control setup with Ruff.

The implementation of Ruff for both formatting and linting is well-structured:

• Using if: always() ensures all checks run regardless of previous failures
• The commented-out Mypy step aligns with the PR's goal to enforce type annotations
• These checks provide a solid foundation for code quality

---

44-45: LGTM! Good practice to add a collection step.

Adding a final step to verify all quality control checks have passed provides clear feedback on the overall status of the code quality checks.

---

50-60: LGTM! Streamlined testing setup with Pixi.

The testing job has been updated to use Pixi consistently with the rest of the workflow:

• Using the latest checkout action
• Installing Pixi with caching enabled
• Running tests with verbose output for better debugging

This approach centralizes dependency management in Pixi, making the workflow more maintainable.

src/snakemake_interface_common/plugin_registry/tests.py (2)

17-17: Consistent formatting for abstract methods looks good.

The abstract method declarations have been updated to use a more concise single-line ellipsis format rather than multiline placeholders. This change improves code readability while maintaining the same functionality and proper type annotations.

Also applies to: 20-20, 23-23, 26-26, 29-29

---

43-45: Assertion formatting change looks good.

The multi-line formatting of the assertion statement helps improve readability while preserving the original functionality.

Reviewing files that changed from the base of the PR and between 8594b43 and 7b5a037.

• .github/workflows/test.yml (1 hunks)
• .gitignore (1 hunks)

• .gitignore

.github/workflows/test.yml (10)

10-15: Permissions Block Added
The new permissions block assigns minimal required permissions (contents: read, checks: write, issues: write, pull-requests: write). This appears correct and helps enforce least privilege for the workflow.

---

17-18: Job Renaming to Quality-Control
The job previously named “formatting” has been renamed to “quality-control,” reflecting the expanded scope of quality checks. This improves clarity regarding the job’s responsibilities.

---

20-22: Checkout Step Updated
The “Check out the code” step now uses actions/checkout@v4, which is an improvement over the previous version. Ensure that this version meets the project’s needs.

---

23-28: Pixi Installation in Quality-Control Job
The new “Install Pixi” step correctly uses prefix-dev/setup-pixi@v0.8.3 with the specified environment (dev) and Pixi version (v0.42.1). This aligns with the PR objectives of shifting dependency management from Poetry to Pixi.

---

29-33: Ruff Format Step Added
The “Ruff Format” step leverages Pixi to run formatting checks (pixi run --environment dev format --check). This change appears well integrated and ensures code formatting is validated.

---

34-38: Ruff Lint Step Added
The addition of the “Ruff lint” step, executing pixi run --environment dev lint --diff, is appropriate for enforcing linting standards in the codebase.

---

43-45: Collect QC Step Looks Good
The “Collect QC” step simply echoes a confirmation message that quality control checks have passed. This step is straightforward and serves its purpose.

---

49-50: Testing Job – Checkout Step
The testing job includes a checkout step using actions/checkout@v4, ensuring consistency with the quality-control job.

---

51-56: Testing Job – Pixi Installation
The testing job mirrors the quality-control job by installing Pixi with the same configuration (prefix-dev/setup-pixi@v0.8.3, environment: dev, pixi-version: v0.42.1), which maintains consistency across the workflow.

---

57-59: Run Tests Command Configured Correctly
The “Run tests” step executes pixi run --environment dev test --show-capture=all -s -vv, enabling verbose output and capturing test details. This configuration should aid in debugging test failures.