feat: MANIFEST.in: include tests/ in sdist#3073
Merged
johanneskoester merged 1 commit intosnakemake:mainfrom Sep 7, 2024
Merged
feat: MANIFEST.in: include tests/ in sdist#3073johanneskoester merged 1 commit intosnakemake:mainfrom
johanneskoester merged 1 commit intosnakemake:mainfrom
Conversation
Contributor
WalkthroughThe changes to the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- MANIFEST.in (1 hunks)
Additional comments not posted (2)
MANIFEST.in (2)
4-6: Approved: Inclusion oftests/directory in sdist.The addition of
graft testsis correctly implemented to include the entiretests/directory in the source distribution. This change ensures that all test files are available to users, which is beneficial for verifying the package's functionality.
4-6: Verify PR checklist completion.Ensure that the PR checklist items are addressed:
- Confirm that the PR contains a test case for the changes made or that existing test cases already cover the changes.
- Ensure that the documentation in the
docs/directory is updated to reflect any changes made, or confirm that no updates are necessary if the changes do not affect the language, behavior, or functionalities of Snakemake.
johanneskoester
approved these changes
Sep 7, 2024
johanneskoester
pushed a commit
that referenced
this pull request
Sep 7, 2024
🤖 I have created a release *beep* *boop* --- ## [8.20.0](v8.19.3...v8.20.0) (2024-09-07) ### Features * allow skipping apptainer and conda tests if not available ([#3074](#3074)) ([c3cd4e0](c3cd4e0)) * MANIFEST.in: include tests/ in sdist ([#3073](#3073)) ([e24f3fc](e24f3fc)) ### Bug Fixes * add subfolders of report template to package data ([14a8f22](14a8f22)) * Inconsistent Linting Output Formatting ([#3064](#3064)) ([90e51ae](90e51ae)) * retry when downloading assets ([58e41b0](58e41b0)) * skip asset download if files are already present ([#3076](#3076)) ([0d3d1e1](0d3d1e1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QC
docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).Summary by CodeRabbit