Closed
Conversation
* Can pull out parent-child node relationship calculation into reducer, store that prop in ExperimentView
* Can also actually store sortedRunIds as a state element of ExperimentView
* Unpersisted state, since it depends on API response
* In general, no need to maintain a bunch of ordered lists of metrics/params/tags
* Can just use existing maps of run ID to metric/param/tag value, look things up in those using the sorted run IDs
* Current lookup is instead to maintain the sorted indices of run IDs within runInfos (return idx from getRowRenderMetadata), and look up runInfos[idx] etc
expose it as a prop on ExperimentView
Codecov Report
@@ Coverage Diff @@
## shift-click-runs #1 +/- ##
=================================================
Coverage 65.75% 65.75%
=================================================
Files 22 22
Lines 800 800
=================================================
Hits 526 526
Misses 274 274Continue to review full report at Codecov.
|
smurching
pushed a commit
that referenced
this pull request
Apr 12, 2019
* Preliminary Java support * Renames * Package restructuring * Add mleap python flavor - preliminary * Implement javafunc with correct loader module * Input parsing * Add missing files * Failed attempt at package installation * Fix up naming semantics, loader module impl * Server impl * Fixes - serving works * Benchmarking results * Benchmarking script * SparkML critical path lats * add batching to bmark * Remove runID from SageMakerServer * .. * Add method that allows deserialization of MLeap pipeline in native format * Move JavaFunc into protected sagemaker package * Modify pyfunc container to handle mleap * Python API changes progress * Use package protection to hide modules that we don't yet wish to expose to users * Fixes * Container mods * Remove mlflow-java directory * Serving is functional. Add sparkml module * Exception message fixes * Throw unsupportedop from attempting to load a model from runId * Remove nonfunctional PackageInstaller * Package restructuring, remove unnecessary lines * Improved error handling * Doc tweaks * JavaFunc error coherency improvements * Remove unused main method * Fix more merge conflicts * Remove invalid comments * Attempt at MLeap serialization parameter validation * Debugging * Exception tweaks * Add javafunc experimental comments * Remove javafunc line * Pom fixes * More pom fixes, make container use jar, correct version * Construct leapframe from pandas * Add missing files * Docs fixes * Comment fix * Docs fix * pom fixes * New tests * Test improvements * Fix print statement omission * Docker build, spark lib fixes * Renaming, new yaml/json utilities, prediction column selection from MLeap * Container emits json-serialized predictions column * lambda syntax fix * MLeap predictor return json * Merge docker tests * Use * Add test for correct handling of invalid inputs * helper function documentation * Pom changes, docs * Revert MLeap, sagemaker container * Remove leapframe, sagemaker java infra * Revert tests * Revert helper functions for tests * Fix spacing * revert setup py * Remove commented pom * Remove javafunc * Remove py * Add style checker to pom with correct configuration * Docs * Add tests - FOR REF LATER * Remove tests * Remove unused tracking utils * Revert "Remove tests" This reverts commit c88d6b2. * Remove pipeline deserialization test * Serialization utils docs * Add unit tests * Error message fix * Revert py changes * Revert py * Remove unnecessary test resources * Doc link fixes * Change package name in java file * Change package name in directory structure * Pom updates * Print stack trace on modeltest fail * Remove trailing from test case names * Rename tests to comply with style guide, add class argument to serialization utility * Format code * Format tests * Rename to * Update travis yml with Java tests * Remove superfluous files * Test fix * Remove swn files * Remove swm
smurching
pushed a commit
that referenced
this pull request
Apr 12, 2019
* begin R service API refactoring * fix tracking uri getting * remove old mlflow_create_experiment() * reorg files * local server registration * experiment adding * mlflow client server url attribute * delete/restore experiments * get run * log metric * fix log metric docs * set tag * log param * get param * get metric * get metric history * list and get experiment * set terminated * reorg files * refactor mlflow_log_artifact() * reorg files * remove unused mlflow_ensure_run_id * refactor mlflow_end_run() * delete old cold * fix get experiment * options for view_type for list experiments * revise tests * fix mlflow_get_run dispatch * deregister local servers in tests * fix tests * pass client to rest calls * more fixes * get or start run for all fluent * actually refresh state for tests * remove mlflow_connect() * rename mlflow_tracking_uri to mlflow_get_tracking_uri * remove mlflow_disconnect() * remove active connection code * rename mlflow_connection class to mlflow_server * remove unused mlflow_connection_url * remove mentions of connection * cosmetics * typo * remove dead code * with.mlflow_active_run condition handling * error message when client isn't specified for tracking service API * active experiment id * setting tracking uri shouldn't change other globals * refactor entities run * test server -> validate server * reorg files * reorg test files * remove run_uuid parameter from mlflow_log_model * clean up create/list experiment rest wrapper * remove unnecessary assignments in rest wrappers * set experiment id independent of run * consistent naming getters and setters * some r cmd check fixes * fix r cmd check * rename mlflow_get_active_run -> mlflow_active_run and make private mlflow_set_active_run * unexport experiment id getting/setting * add mlflow_get_experiment_by_name() and mlflow_set_experiment() * typo * with.mlflow_run * refactor create experiment * refactor list experiments * refactor get run * refactor create run * refactor get experiment * refactor get experiment by name * refactor delete experiment * refactor restore experiment * log metric * refactor client api * fluent api refactor * reorg files * tracking client docs * fluent docs * rbuildignore internal * typos * default end_time of mlflow_client_set_terminated to current time * fix mlflow_end_run() * default user * document tracking client api * shorten function name * add mlflow_client_list_artifacts() * ignore noisy lintr warnings (#1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.