Merged
Conversation
Contributor
|
Awesome, thanks Kevin! |
Contributor
Author
|
@tomasatdatabricks The fluent and tracking client functions have been separated as described above. |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change splits the tracking feature into a "fluent" component and a "client" component to be consistent with other languages and fix #432.
The explicit Tracking Service/client API, which is a thin layer on top of the internal REST wrappers, is exposed to the user in
tracking-client.R. Similar to their Python counterparts, these methods require anmlflow_clientobject (created in R viamlflow_client()) to be passed and do not depend on global state. The higher-level fluent API, which implicitly manages active runs and experiments, lives intracking-fluent.R. These are the functions we expect most users to be using.Note that the "connection" constructs, e.g.
mlflow_connect()and the "active connection" constructs have been deprecated sincemlflow_clientnow provides the necessary mechanism to track services.This PR is WIP: There are a couple methods yet to be implemented, specifically
list_run_infosanddownload_artifacts. The documentation also needs to be updated.