chore: update go and golanci lint#810
Merged
ramonpetgrave64 merged 6 commits intomainfrom Oct 10, 2024
Merged
Conversation
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
ramonpetgrave64
commented
Oct 7, 2024
.golangci.yml
Outdated
| deadline: 5m | ||
| # For generics. | ||
| go: 1.18 | ||
| # go: 1.23.1 |
Contributor
Author
There was a problem hiding this comment.
uses the go.mod file instead
There was a problem hiding this comment.
maybe no need to leave version number in here, it won't stay updated
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
7d9a402 to
9f72986
Compare
Contributor
Author
jku
approved these changes
Oct 10, 2024
.golangci.yml
Outdated
| deadline: 5m | ||
| # For generics. | ||
| go: 1.18 | ||
| # go: 1.23.1 |
There was a problem hiding this comment.
maybe no need to leave version number in here, it won't stay updated
loosebazooka
previously approved these changes
Oct 10, 2024
Contributor
loosebazooka
left a comment
There was a problem hiding this comment.
+1 to jku's comment, but LGTM
Signed-off-by: Ramon Petgrave <32398091+ramonpetgrave64@users.noreply.github.com>
Contributor
Author
removed, please +1 again. |
loosebazooka
approved these changes
Oct 10, 2024
5 tasks
ramonpetgrave64
added a commit
to slsa-framework/slsa-github-generator
that referenced
this pull request
Oct 14, 2024
# Summary Followup to slsa-framework/slsa-verifier#810 - upgrades to go 1.23.1 and golangci-lint 1.6.1 - makes necessary changes for the linter - as of go 1.22, no need to make a copy of the loop variable - change non-string use of `fmt.Errorf(err)` to `fmt.Error(err)` ## Testing Process unit tests continue to pass, as well as the linter ## Checklist - [x] Review the contributing [guidelines](https://github.com/slsa-framework/slsa-github-generator/blob/main/CONTRIBUTING.md) - [x] Add a reference to related issues in the PR description. - [x] Update documentation if applicable. - [x] Add unit tests if applicable. - [x] Add changes to the [CHANGELOG](https://github.com/slsa-framework/slsa-github-generator/blob/main/CHANGELOG.md) if applicable. --------- Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates go to 1.23.1 and updates golanci-lint to v1.61.1, while fixing new lint errors.