chore: go1.23.1 golangci lint 1.6.1#3940
Conversation
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
0701331 to
1403f7c
Compare
jku
left a comment
There was a problem hiding this comment.
Looks good to me.
The golangci-lint job looks like it should be replaced with golangci/golangci-lint-action but i'm not very familiar with this (and it's not really related to the chore here) so I'm not strongly suggesting it.
loosebazooka
left a comment
There was a problem hiding this comment.
Would be nice to address jku's suggestion in a followup sooner rather than later.
|
@jku @loosebazooka, A while ago @ianlewis and @laurentsimon and I decided it was better to keep it this way, since we get to verify the golangci-lint binary's hash. Their official action I believe still does not verify the binary of the hash, even if downloading directly from their GitHub repo's releases. We should consider updating the slsa-verifier's implementation to verify the binary, however. |
Summary
Followup to slsa-framework/slsa-verifier#810
fmt.Errorf(err)tofmt.Error(err)Testing Process
unit tests continue to pass, as well as the linter
Checklist