Fix #1302 by updating the warning logs in WebClient to be consistent with Node SDK#1303
Merged
seratch merged 2 commits intoslackapi:mainfrom Nov 18, 2022
Merged
Conversation
seratch
suggested changes
Nov 18, 2022
| attachments is not None | ||
| and isinstance(attachments, list) | ||
| and not all( | ||
| if attachments is not None and isinstance(attachments, list): |
Contributor
There was a problem hiding this comment.
Have you applied black code formatter to this change? If not, can you run pip install black && black slack_sdk/?
Contributor
Author
There was a problem hiding this comment.
I did that.
By the way, I'm editing in IntelliJ.
$pip install black && black slack_sdk/
Requirement already satisfied: black in ./venv/lib/python3.11/site-packages (22.8.0)
Requirement already satisfied: click>=8.0.0 in ./venv/lib/python3.11/site-packages (from black) (8.0.4)
Requirement already satisfied: platformdirs>=2 in ./venv/lib/python3.11/site-packages (from black) (2.5.4)
Requirement already satisfied: pathspec>=0.9.0 in ./venv/lib/python3.11/site-packages (from black) (0.10.2)
Requirement already satisfied: mypy-extensions>=0.4.3 in ./venv/lib/python3.11/site-packages (from black) (0.4.3)
All done! ✨ 🍰 ✨
113 files left unchanged.
Contributor
There was a problem hiding this comment.
Thank you!
By the way, I'm editing in IntelliJ
I like this. I am a long-time user of PyCharm for Python too!
Codecov Report
@@ Coverage Diff @@
## main #1303 +/- ##
==========================================
+ Coverage 85.73% 85.80% +0.06%
==========================================
Files 84 84
Lines 7846 7846
==========================================
+ Hits 6727 6732 +5
+ Misses 1119 1114 -5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Indeed it is, thank you! Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
seratch
approved these changes
Nov 18, 2022
Contributor
seratch
left a comment
There was a problem hiding this comment.
Thank you very much for this contribution! Once all the CI jobs pass, we can merge this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request resolves #1302
Category (place an
xin each of the[ ])/docs-src(Documents, have you run./scripts/docs.sh?)/docs-src-v2(Documents, have you run./scripts/docs-v2.sh?)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements (place an
xin each[ ])python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.