Tweaking warnings related to missing accessibility fields text and fallback#1208
Merged
Tweaking warnings related to missing accessibility fields text and fallback#1208
text and fallback#1208Conversation
…`fallback` when posting messages.
Codecov Report
@@ Coverage Diff @@
## main #1208 +/- ##
=======================================
Coverage 86.55% 86.55%
=======================================
Files 111 111
Lines 10893 10891 -2
=======================================
- Hits 9428 9427 -1
+ Misses 1465 1464 -1
Continue to review full report at Codecov.
|
seratch
approved these changes
May 5, 2022
Contributor
seratch
left a comment
There was a problem hiding this comment.
LGTM -As for the future, having mostly the same tests for WebClient and AsyncWebClient should be fine. As for the legacy client, we won't add tests for future changes. Only in the early days of slack-sdk v3 development, we tended to have tests for both legacy and current clients.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows the pattern in the solution converged on for slackapi/node-slack-sdk#1476.
Wondering if there is an opportunity to DRY the tests up here, especially across the legacy vs. the regular synchronous client code. The tests seem to be a carbon copy. I don't really have a suggestion on how to improve that though, but maybe some more Python-y folks have ideas?