Set Werkzeug major version to 1 for Flask compatibility#340
Merged
seratch merged 2 commits intoslackapi:mainfrom May 12, 2021
Merged
Set Werkzeug major version to 1 for Flask compatibility#340seratch merged 2 commits intoslackapi:mainfrom
seratch merged 2 commits intoslackapi:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #340 +/- ##
==========================================
+ Coverage 91.48% 91.54% +0.05%
==========================================
Files 167 167
Lines 5369 5367 -2
==========================================
+ Hits 4912 4913 +1
+ Misses 457 454 -3
Continue to review full report at Codecov.
|
Contributor
Author
|
Update: I've corrected the comment to be more accurate. Flask is already compatible with Werkzueug in their new major version (v2) - 51daa12 |
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continued work after #339
Werkzeug v2 was just released and Flask-Sockets, the package we use for Socket Mode testing is not yet compatible with the major version. This pull request updates the build settings to set Werkzeug's major version to 1.
see also: https://pypi.org/project/Werkzeug/#history
Category (place an
xin each of the[ ])slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements (place an
xin each[ ])Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.