Conversation
d4e31cb to
398eb8d
Compare
| * [Guide](../../staging/libraries/shared/factories/storage/README.md) | ||
| * [Example](../../staging/libraries/shared/factories/storage/EXAMPLE.md) | ||
| * [Guide](../libraries/shared/factories/storage/README.md) | ||
| * [Example](../libraries/shared/factories/storage/EXAMPLE.md) |
There was a problem hiding this comment.
What's up with this diff? Were these broken previously, or does this change what branch we look at?
There was a problem hiding this comment.
I noticed that these links weren't working - not sure entirely how staging in the link was affecting things, but I noticed when I removed it, the link would still redirect to staging. 🤔
| Execute(diff types.PersistedDiff) error | ||
| KeccakContractAddress() common.Hash | ||
| GetStorageKeysLookup() interface{} | ||
| GetStorageKeysLookup() KeysLookup |
| if !ok { | ||
| return addressToKeys, fmt.Errorf("%v type incompatible. Should be a storage.KeysLookup", keysLookup) | ||
| } | ||
| keysLookup := transformer.GetStorageKeysLookup() |
There was a problem hiding this comment.
Is it possible for this to return nil? I guess that would probably be in a catastrophic config situation, but maybe worth still tossing up an error if that happens?
There was a problem hiding this comment.
Looking at it a bit closer, we'd actually panic if the StorageKeysLookup wasn't set on the Transformer before making it here because when creating a new transformer we call SetDB on the StorageKeysLookup in NewTransformer. 🤔
Not sure I want to make this change now, but I wonder if we should consider returning an error from NewTransformer if either StorageKeysLookup or Repository are nil?
398eb8d to
26aff81
Compare
* (VDB-1164) Get node name from web3_clientVersion Use IPC path as node ID * 1189 new move transformer interfaces (#48) * Move storage Transformer interface to storage pkg * Handle new storage transformer interface in plugin writer * Add additional storage value loader logging * Move event transformer interface to factories/event pkg * Handle new event transformer interface location in plugin writer * Memoize an transformer's keccakedAddress * Update resetHeaderCheckCount docker setup (#50) * 1189 fix (#52) * Update ITransformer.GetStorageKeysLookup to return a KeysLookup * Update custom-transformers.md with new transformer paths * TO-879:docker ci (#40) * dockerhub via travis * add extract-diffs * add reset-header-check * (VDB-1207) Remove non-essential smart comments (#53) - configure via postgraphile.tags.json5 instead * Update postgres version in travis build (#54) * Update postgres version in travis build to 11.6 this is the most recent posgres version available in RDS at the moment * update travis secrets (#55) Co-authored-by: Gabe Laughlin <gabe@bistrotech.net> Co-authored-by: daimesava <56128157+daimesava@users.noreply.github.com> Co-authored-by: Rob Mulholand <rmulholand@8thlight.com>
No description provided.