1189 new move transformer interfaces#48
Merged
elizabethengelman merged 8 commits intostagingfrom Feb 18, 2020
Merged
Conversation
rmulhol
approved these changes
Feb 17, 2020
|
|
||
| type ITransformer interface { | ||
| Execute(diff types.PersistedDiff) error | ||
| KeccakContractAddress() common.Hash |
There was a problem hiding this comment.
Really minor and not a blocker to this PR but would it make sense to memoize the result for the implementation of this function on ln 56? Thinking we could have a private var on the Transformer struct and only compute the hash at runtime if it hasn't already been called and assigned
gslaughl
approved these changes
Feb 17, 2020
| return types.HexToKeccak256Hash(transformer.Address.Hex()) | ||
| emptyHash := common.Hash{} | ||
| if transformer.hashedAddress == emptyHash { | ||
| return types.HexToKeccak256Hash(transformer.Address.Hex()) |
There was a problem hiding this comment.
I think I'm missing where hashedAddress is getting set 🤔
Is it meant to happen on this line?
Author
There was a problem hiding this comment.
🤦♀ good catch! i'll push a fix up shortly.
81b6702 to
3a5ac65
Compare
elizabethengelman
pushed a commit
that referenced
this pull request
Feb 25, 2020
* (VDB-1164) Get node name from web3_clientVersion Use IPC path as node ID * 1189 new move transformer interfaces (#48) * Move storage Transformer interface to storage pkg * Handle new storage transformer interface in plugin writer * Add additional storage value loader logging * Move event transformer interface to factories/event pkg * Handle new event transformer interface location in plugin writer * Memoize an transformer's keccakedAddress * Update resetHeaderCheckCount docker setup (#50) * 1189 fix (#52) * Update ITransformer.GetStorageKeysLookup to return a KeysLookup * Update custom-transformers.md with new transformer paths * TO-879:docker ci (#40) * dockerhub via travis * add extract-diffs * add reset-header-check * (VDB-1207) Remove non-essential smart comments (#53) - configure via postgraphile.tags.json5 instead * Update postgres version in travis build (#54) * Update postgres version in travis build to 11.6 this is the most recent posgres version available in RDS at the moment * update travis secrets (#55) Co-authored-by: Gabe Laughlin <gabe@bistrotech.net> Co-authored-by: daimesava <56128157+daimesava@users.noreply.github.com> Co-authored-by: Rob Mulholand <rmulholand@8thlight.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.