WIP: add logistic growth cap and floor for fbprophet#1868
Closed
niekvanderlaan wants to merge 1 commit intosktime:mainfrom
Closed
WIP: add logistic growth cap and floor for fbprophet#1868niekvanderlaan wants to merge 1 commit intosktime:mainfrom
niekvanderlaan wants to merge 1 commit intosktime:mainfrom
Conversation
Collaborator
|
(failing with code quality errors, kindly resolve) |
This was referenced Apr 11, 2022
k1m190r
added a commit
to k1m190r/sktime
that referenced
this pull request
May 6, 2022
k1m190r
added a commit
to k1m190r/sktime
that referenced
this pull request
May 6, 2022
2 tasks
Collaborator
|
Completed in #2609 and resolved by merging. |
fkiraly
added a commit
that referenced
this pull request
Jun 11, 2022
@niekvanderlaan contributed a fix in #1868 which remained incomplete, but got eventually completed by @k1m190r and merged. Most work was already done by @niekvanderlaan, except linting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #1079
What does this implement/fix? Explain your changes.
Adds the possibility to define the required "cap" and "floor" parameters for Prophet when its growth is set to logistic.
What should a reviewer concentrate their feedback on?
Whether the proposed changes are the correct way of accepting the cap and floor parameters.
Additionally, the only check in place is a ValueError is currently raised when "cap" is not specified ("floor" is not required, as it defaults to 0). I believe Prophet will handle all other input errors, but it might be good to test certain wrong inputs.
Any other comments?
This fix is blocked by another uncovered bug in the
convert_tomethod that is used in the BaseForecaster, that leads to the output as an empty DataFrame. Will open another issue for thisFor all contributions