Conversation
ltsaprounis
previously approved these changes
May 28, 2022
Contributor
ltsaprounis
left a comment
There was a problem hiding this comment.
Seems fair.
Shall we wait for a thumbs up from @niekvanderlaan before we merge?
Collaborator
Author
|
I guess? |
Collaborator
Author
|
@niekvanderlaan, are you still around somewhere? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@niekvanderlaan contributed a fix in #1868 which remained incomplete, but got eventually completed by @k1m190r and merged.
Most work was already done by @niekvanderlaan, except linting.