Skip to content

Datatypes module consolidation - tests, fixtures, panel data containers#1225

Merged
fkiraly merged 100 commits intomainfrom
datatypes-classif
Aug 26, 2021
Merged

Datatypes module consolidation - tests, fixtures, panel data containers#1225
fkiraly merged 100 commits intomainfrom
datatypes-classif

Conversation

@fkiraly
Copy link
Copy Markdown
Collaborator

@fkiraly fkiraly commented Jul 29, 2021 •
edited
Loading

This PR further consolidates the datatypes module introduced in #1061 and #1201:

  • adding example fixtures for most important panel data containers
  • consolidated checks for "is (some type)" in module, added some missing ones
  • adding registry constants for panel data containers
  • renaming leftover "what" variables to "obj"
  • bugfix in converter from nested to multi-index
  • adding converters for list-of-data-frames panel type used in the distance module
  • added tests for checking functionality
  • adding tests for conversion functionality, testing converters against fixtures
  • adding docstrings where they were missing

@fkiraly fkiraly requested a review from mloning as a code owner July 29, 2021 22:37
@fkiraly fkiraly mentioned this pull request Jul 30, 2021
Merged
fkiraly added 25 commits August 13, 2021 14:52
@fkiraly
Merge branch 'main' into datatypes-classif
f4ac030
@fkiraly
deprecate old mtype inference
bd109c3
@fkiraly
Merge branch 'main' into datatypes-classif
8774ba8
@fkiraly
Merge branch 'main' into datatypes-classif
357d292
@fkiraly
Merge branch 'main' into datatypes-classif
fe36df7
@fkiraly
docstrings and code simplification
22f90af
@fkiraly
docstrings
e451b6b
@fkiraly
Merge branch 'main' into datatypes-classif
3d5c026
@fkiraly
added mtype_to_scitype to exports of datatypes
bd82fc1
@fkiraly
changed default as_scitype to to_type in convert, to be consistent wi…
9b9fa4d 
…th convert_to
@fkiraly
linting
8e10bc5
@fkiraly
fixed bug in - deep_equals, also check index in series/object case
b17324b
@fkiraly
docstring updates
2b49123
@fkiraly
added comment on fixtures
bd0671f
@fkiraly
some linting
4c57a67
@fkiraly
linting
d65c067
@fkiraly
fix typo in Union
39b75c3
@fkiraly
Merge branch 'main' into datatypes-classif
049ad34
@fkiraly
fixed type hint
fefa005
@fkiraly
Merge branch 'main' into datatypes-classif
63c4a79
@fkiraly
updated type hint
159c885
@fkiraly
completed docstrings for datatype module
362790d
@fkiraly
fixed error with composite type in check_is
b5f5077
@fkiraly
removed paste accident
89e12bc
@fkiraly
Merge branch 'main' into datatypes-classif
1d6cc1b
@fkiraly
Copy link
Copy Markdown
Collaborator Author

fkiraly commented Aug 26, 2021

approval extends from #1232 since this is a sub-set - see there.

@fkiraly fkiraly merged commit 105ad4c into main Aug 26, 2021
@fkiraly fkiraly deleted the datatypes-classif branch August 26, 2021 12:00
fkiraly added a commit that referenced this pull request Aug 26, 2021
@fkiraly
[DOC] data container conventions, conversions, and data sets document…
761eb15 
…ation (#1232)

Pull request on data container conventions and related functionality.

This is based on, and branching off the state of #1225 - and requests of @mloning and @TonyBagnall to document this.

The increment in this PR is the notebook `examples/AA_datatypes.ipynb` which is supposed to explain:
* the different core in-memory data container datatypes for series and panels used in `sktime`, with examples to play around with
* validity checking, conversion, register, and type functionality
* data sets loading functionality
@fkiraly fkiraly mentioned this pull request Aug 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mloning mloning Awaiting requested review from mloning

@TonyBagnall TonyBagnall Awaiting requested review from TonyBagnall

@chrisholder chrisholder Awaiting requested review from chrisholder

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@fkiraly