Skip to content

[DOC] data container conventions, conversions, and data sets documentation#1232

Merged
fkiraly merged 172 commits intomainfrom
datatypes-doc
Aug 26, 2021
Merged

[DOC] data container conventions, conversions, and data sets documentation#1232
fkiraly merged 172 commits intomainfrom
datatypes-doc

Conversation

@fkiraly
Copy link
Copy Markdown
Collaborator

@fkiraly fkiraly commented Jul 30, 2021

Pull request on data container conventions and related functionality.

This is based on, and branching off the state of #1225 - and requests of @mloning and @TonyBagnall to document this.

The increment in this PR is the notebook examples/00_datatypes.ipynb which is supposed to explain:

  • the different core in-memory data container datatypes for series and panels used in sktime, with examples to play around with
  • validity checking, conversion, register, and type functionality
  • data sets loading functionality

Ready for review

@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@fkiraly fkiraly requested a review from Lovkush-A August 23, 2021 23:47
@fkiraly fkiraly requested a review from TonyBagnall August 23, 2021 23:48
Copy link
Copy Markdown
Collaborator

@Lovkush-A Lovkush-A left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny change suggestion. mixup with type hints.

also need to add docstring for register file

@fkiraly fkiraly requested a review from Lovkush-A August 25, 2021 19:20
Lovkush-A
Lovkush-A previously approved these changes Aug 25, 2021
Copy link
Copy Markdown
Collaborator

@Lovkush-A Lovkush-A left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since last major review, the variuos minor changes have been made, so all good to go from my end.

@fkiraly
Copy link
Copy Markdown
Collaborator Author

fkiraly commented Aug 26, 2021

Ok, I'll merge this in two steps then: first #1225, which is this sans notebook, then this PR. Just to have smaller chunks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants