Skip to content

re-factoring existing forecasters to new interface #955

@fkiraly

Description

@fkiraly

We need to slowly re-factor all forecasters to be compliant with the new interface (see PR #912). i.e., no overrides of fit etc and descendant classes only implementing core logic, while the BaseForecaster implements check etc logic.

Currently this is running due to various downwards compatibility workarounds, which should be removed once all forecasters are ready (in "no-override" state)

The forecasters that still need a downstream refactor are:

For a how-to, useful resources are the forecaster extension template in extension_templates and PR #953 as an example for NaiveForecaster.

Based on discussions, we need to do the following two things in a capstone refactor that removes the last traces of the workarounds and goes over the above for consistency:

  • remove the _SktimeForecaster and mixins for good
  • go through all forecasters and check the tags for correctness

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueGood for newcomersmodule:forecastingforecasting module: forecasting, incl probabilistic and hierarchical forecasting

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions