-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Description
We need to slowly re-factor all forecasters to be compliant with the new interface (see PR #912). i.e., no overrides of fit etc and descendant classes only implementing core logic, while the BaseForecaster implements check etc logic.
Currently this is running due to various downwards compatibility workarounds, which should be removed once all forecasters are ready (in "no-override" state)
The forecasters that still need a downstream refactor are:
-
NaiveForecastersExemplary concrete estimator refactor post interface refactor, of NaiveForecaster #953 -
EnsembleForecasterRefactoring Stacking, Multiplexer, Ensembler and TransformedTarget Forecasters #977 -
MultiplexForecasterRefactoring Stacking, Multiplexer, Ensembler and TransformedTarget Forecasters #977 -
TransformedTargetForecasterRefactoring Stacking, Multiplexer, Ensembler and TransformedTarget Forecasters #977 -
_Reducerand related code Refactor reducer #1031 -
StackingForecasterRefactoring Stacking, Multiplexer, Ensembler and TransformedTarget Forecasters #977 -
ForecastingGridSearchCV,RandomizedGridSearchCV, andBaseGridSearchForecasters re-factoring: BaseGridSearch, ForecastingGridSearchCV, ForecastingRandomizedSearchCV #1034 -
OnlineEnsembleForecasterand descendants Refactors ensembler, online-ensembler-forecaster and descendants #1015 -
_PmdArimaAdapterand descendantsARIMA,AutoARIMArefactors PmdArimaAdapter #1016 - adapter only -
BATS,TBATS, and_TbatsadapterRefactors TbatAdapter #1017 adapter only -
_StatsModelAdapterand descendantsAutoETS,ExponentialSmoothing,ThetaForecasterrefactors statsmodels and theta forecaster #1029 -
HCrystalBallForecasterrefactors HCrystallBall Forecaster #1004 -
Prophetand_ProphetAdapterRefactor Prophet #1005 -
PolynomialTrendForecasterRefactors polynomial trend forecaster #1003
For a how-to, useful resources are the forecaster extension template in extension_templates and PR #953 as an example for NaiveForecaster.
Based on discussions, we need to do the following two things in a capstone refactor that removes the last traces of the workarounds and goes over the above for consistency:
- remove the
_SktimeForecasterand mixins for good - go through all forecasters and check the tags for correctness