Conversation
16 tasks
Collaborator
Author
|
@mloning, @aiwalter, would one of you mind having at least a superficial look at this? @thayeylolu is following the same pattern in #965, so it would be good to get aligned on "is this good" better earlier than later. Sorry for being pushy... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an exemplary refactor of a concrete estimator class,
NaiveForecaster, to explore how general concrete forecaster refactors would work, along the lines discussed in #912.This PR changes:
_BaseWindowForecasterstill inherits fromBaseForecasterdirectly, and already looked extension spec compliant (no overrides, no tags)NaiveForecasterinherits from_BaseWindowForecaster, and has been made extension spec compliant by adding therequires-fh-in-fittag, and moving core logic fromfitto_fit, while avoiding to overridefitBaseForecaster.fit, as a general change: thecutoffis set to the latestyindex using_set_cutoff. This is done pre-_fit, which could override the set cut-off.