Refactors ensembler, online-ensembler-forecaster and descendants#1015
Merged
fkiraly merged 4 commits intosktime:mainfrom Jun 23, 2021
Merged
Refactors ensembler, online-ensembler-forecaster and descendants#1015fkiraly merged 4 commits intosktime:mainfrom
fkiraly merged 4 commits intosktime:mainfrom
Conversation
16 tasks
fkiraly
requested changes
Jun 22, 2021
Collaborator
fkiraly
left a comment
There was a problem hiding this comment.
You should also make the changes in update if the function exists.
Collaborator
Author
|
Could you point me to where you are referring to @fkiraly |
mloning
reviewed
Jun 22, 2021
Contributor
mloning
left a comment
There was a problem hiding this comment.
Hi @thayeylolu, we also need to update the update method by removing the following I think:
self.check_is_fitted()
self._update_y_X(y, X)
Collaborator
the |
…into refactor-online-ensembleForecaster merges with main updates
fkiraly
approved these changes
Jun 23, 2021
Collaborator
fkiraly
left a comment
There was a problem hiding this comment.
looks ready to merge, I'll just wait for the checks to finish.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference : #955
We need to slowly re-factor all forecasters to be compliant with the new interface (see PR #912). i.e., no overrides of fit etc and descendant classes only implementing core logic, while the BaseForecaster implements check etc logic.
Currently this is running due to various downwards compatibility workarounds, which should be removed once all forecasters are ready (in "no-override" state)
The forecasters that still need a downstream refactor are: