[BUG] bugfixes for distribution base class default methods#281
Merged
Conversation
5 tasks
fkiraly
added a commit
that referenced
this pull request
Apr 25, 2024
By accident, the tests for distribution base class default methods, e.g., obtaining `pdf` form `log_pdf` if not implemented, were not activated. This PR remedies that, and also upgrades the test class to the new distribution extension contract. Depends on #281, for bugfixes of bugs discovered through enabling the tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes some bugs for base class default methods detected through #266:
_log_pdf,_pdf,_cdfdefaultsTestAllDistributions,_shuffle_dffunction being incorrect ifilocis not equal tolocindexFixes are tested in #266.