Skip to content

[ENH] activate tests for distribution base class defaults#266

Merged
fkiraly merged 18 commits into
mainfrom
test-defaults
Apr 25, 2024
Merged

[ENH] activate tests for distribution base class defaults#266
fkiraly merged 18 commits into
mainfrom
test-defaults

Conversation

@fkiraly

@fkiraly fkiraly commented Apr 21, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

By accident, the tests for distribution base class default methods, e.g., obtaining pdf form log_pdf if not implemented, were not activated.

This PR remedies that, and also upgrades the test class to the new distribution extension contract.

Depends on #281, for bugfixes of bugs discovered through enabling the tests.

@fkiraly fkiraly added enhancement module:probability&simulation probability distributions and simulators labels Apr 21, 2024
@fkiraly fkiraly mentioned this pull request Apr 25, 2024
Merged
fkiraly added a commit that referenced this pull request Apr 25, 2024
@fkiraly
[BUG] bugfixes for distribution base class default methods (#281)
f1ced8f 
This PR fixes some bugs for base class default methods detected through
#266:

* `_log_pdf`, `_pdf`, `_cdf` defaults
* in `TestAllDistributions`, `_shuffle_df` function being incorrect if
`iloc` is not equal to `loc` index

Fixes are tested in #266.
@fkiraly fkiraly merged commit c3ef686 into main Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement module:probability&simulation probability distributions and simulators

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@fkiraly