Distinct cache for force_feed#643
Merged
mblaney merged 3 commits intosimplepie:masterfrom Mar 30, 2020
Merged
Conversation
Ensure that feeds retrieved with the force_feed option do not share the same cache than feeds retrieved without this option. Otherwise, in a context with multiple clients, clients without the force_feed option would have a behaviour (working or not) depending entirely on what other clients with force_feed are doing. In other words, it procudes a side-effect difficult to predict, which should be avoided.
Contributor
Author
|
P.S. Tested using the default cache system |
Contributor
Author
|
Travis is successful, but apparently the status on GitHub has not received the notification |
Alkarex
added a commit
to FreshRSS/FreshRSS
that referenced
this pull request
Mar 28, 2020
#fix #2524 In general, we should avoid using the same cache for feeds that are fetched with distinct parameters / settings.. PR upstream to SimplePie simplepie/simplepie#643
Member
|
thanks @Alkarex looks like a good idea. you don't need the check in |
Contributor
Author
|
Here you are @mblaney |
Member
|
you don't need to modify |
Contributor
Author
|
Ah, sorry, it is indeed a |
Alkarex
added a commit
to Alkarex/FreshRSS
that referenced
this pull request
Apr 1, 2020
FreshRSS#2852 was merged upstream simplepie/simplepie#643 Follow-up of FreshRSS#2814
This was referenced Apr 1, 2020
Alkarex
added a commit
to FreshRSS/FreshRSS
that referenced
this pull request
Apr 1, 2020
#2852 was merged upstream simplepie/simplepie#643 Follow-up of #2814
Alkarex
added a commit
to FreshRSS/simplepie
that referenced
this pull request
Mar 28, 2021
Retrieving a feed with distinct cURL parameters such as user-agent might give different responses, which should not share the same cache. Follow-up and generalisation of simplepie#643 The code to get the cache filename is extracted in its own new fuction `SimplePie::get_cache_filename($url)` so that clients can easily get this information as well. Downstream PR: FreshRSS/FreshRSS#3502
Merged
mblaney
pushed a commit
that referenced
this pull request
Apr 12, 2021
Retrieving a feed with distinct cURL parameters such as user-agent might give different responses, which should not share the same cache. Follow-up and generalisation of #643 The code to get the cache filename is extracted in its own new fuction `SimplePie::get_cache_filename($url)` so that clients can easily get this information as well. Downstream PR: FreshRSS/FreshRSS#3502
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that feeds retrieved with the force_feed option do not share the
same cache than feeds retrieved without this option.
Otherwise, in a context with multiple clients, clients without the
force_feed option would have a behaviour (working or not) depending
entirely on what other clients with force_feed are doing. In other
words, it produces a side-effect difficult to predict, which should be
avoided.