SimplePie prevent cache pollution#3502
Merged
Alkarex merged 13 commits intoFreshRSS:masterfrom Mar 9, 2021
Merged
Conversation
Alkarex
commented
Mar 6, 2021
| $simplePie = new SimplePie(); | ||
| $simplePie->set_useragent(FRESHRSS_USERAGENT); | ||
| $simplePie->set_syslog(FreshRSS_Context::$system_conf->simplepie_syslog_enabled); | ||
| $simplePie->set_cache_name_function('sha1'); |
Member
Author
There was a problem hiding this comment.
Slight upgrade from md5 (no need to be crypto-safe, but good to reduce risks of collision)
4 tasks
Alkarex
commented
Mar 7, 2021
Member
Author
|
Let's merge to get some testing |
Alkarex
added a commit
to FreshRSS/simplepie
that referenced
this pull request
Mar 28, 2021
Retrieving a feed with distinct cURL parameters such as user-agent might give different responses, which should not share the same cache. Follow-up and generalisation of simplepie#643 The code to get the cache filename is extracted in its own new fuction `SimplePie::get_cache_filename($url)` so that clients can easily get this information as well. Downstream PR: FreshRSS/FreshRSS#3502
Member
Author
|
Upstream PR: simplepie/simplepie#675 |
mblaney
pushed a commit
to simplepie/simplepie
that referenced
this pull request
Apr 12, 2021
Retrieving a feed with distinct cURL parameters such as user-agent might give different responses, which should not share the same cache. Follow-up and generalisation of #643 The code to get the cache filename is extracted in its own new fuction `SimplePie::get_cache_filename($url)` so that clients can easily get this information as well. Downstream PR: FreshRSS/FreshRSS#3502
This was referenced May 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retrieving a feed with distinct cURL parameters such as user-agent might give different responses, which should not share the same cache:
#fix #3367 (comment)
#fix #3494 (comment)